Uh oh!
There was an error while loading. Please reload this page.
fix: Implement missing logics in exported_private_dependencies lint - #134176
fix: Implement missing logics in exported_private_dependencies lint#134176ShoyuVanilla wants to merge 2 commits into
exported_private_dependencies lint#134176Conversation
rustbot
commented
Dec 11, 2024
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
69cd0c2 to
c98257cComparec98257c to
6e8f9ddCompareexported_private_dependencies checksexported_private_dependencies lintShoyuVanilla
commented
Feb 25, 2025
r? compiler |
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Feb 25, 2025
|
Actually, I'm preparing another PR that fixes #119428 once and for all with some changes in ast path lowering and nameres resolves. |
…rom `rustc_privacy`
petrochenkov
commented
Mar 10, 2025
Yes, most likely. See, for example, the |
petrochenkov
commented
Mar 10, 2025
I started reviewing this and I was sure that Technically, the regular type privacy lints (not private dep leaks) should be reported there as well, it was just skipped due to many false positives. Closing in favor of #138317. |
…r-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
…r-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
Rollup merge of rust-lang#138317 - petrochenkov:libsearch3, r=compiler-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
Fixes some cases of #71043