Bump Fuchsia toolchain

[steven807]

try-job: dist-various-2

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[lqd]

I wonder:

• why another PR bump when Bump Fuchsia #134188 is still open and about to land? was it missing the other commit to build the toolchain/sdk?
• why try builds on dist-various-2? it's not the fuchsia builder, so I won't do the try build yet

It'd be appreciated if some description was added to similar PRs in the future.

Actually I'll take this one r? lqd

[steven807]

This is an update to the Fuchsia SDK -- #134188 was updating Fuchsia itself.

Sorry for the lack of descriptions -- I'm new to the Fuchsia Rust Toolchain rotation, and this is the first time I've submitted these. I should have followed the structure in #123881 and #132294.

[lqd]

You don’t need to land both at the same time I presume?

[lqd]

What about the other question, do you need a try build for dist-various or the fuchsia builder?

[steven807]

Correct, they did not need to be landed at the same time.

The bump-fuchsia commit was validated in the x86_64-fuchsia builder, but the instructions I have say to validate the bump-sdk PR using dist-various-2 (which does include a Fuchsia build). I'm not clear why our instructions suggest using the two different try-jobs for the two submissions.

[lqd]

Cool

@bors try

[bors]

⌛ Trying commit 06bf19b with merge cc22916...

[lqd]

If you were in https://github.com/rust-lang/team/blob/master/teams/fuchsia.toml you could run the try build yourself.

[bors]

💔 Test failed - checks-actions

[lqd]

No logs available on that failure, it could be spurious, let's @bors try

[bors]

⌛ Trying commit 06bf19b with merge 14001ba...

[bors]

☀️ Try build successful - checks-actions
Build commit: 14001ba (14001ba42f76f7a940a48e066cf691f073922a0a)

[erickt]

@lqd - looks like the test run passed, and the PR #134188 it was based on has also landed. Should we rebase this on head, or would it be okay to land as is?

[lqd]

It'll be simpler with a rebase, even if maybe not technically needed :)

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

• 4016332

[erickt]

@steven807 asked me to take this over, so I rebased it in #134581.

[lqd]

Ok then we can close this one. Superseded by #134581.