Skip to content

Clean up infer_return_ty_for_fn_sig - #134259

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:infer-ret-ty
Dec 15, 2024
Merged

Clean up infer_return_ty_for_fn_sig#134259
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:infer-ret-ty

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

The code for lowering fn signatures from HIR currently is structured to prefer the recovery path (where users write -> _) over the good path. This PR pulls the recovery code out into a separate fn.

Review w/o whitespace

@rustbot

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2024
@dtolnay

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Dec 14, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d82c520 has been approved by dtolnay

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2024
@dtolnaydtolnay assigned dtolnay and unassigned BoxyUwUDec 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#132939 (Suggest using deref in patterns)
- rust-lang#133293 (Updates Solaris target information, adds Solaris maintainer)
- rust-lang#133392 (Fix ICE when multiple supertrait substitutions need assoc but only one is provided)
- rust-lang#133986 (Add documentation for anonymous pipe module)
- rust-lang#134022 (Doc: Extend for tuples to be stabilized in 1.85.0)
- rust-lang#134259 (Clean up `infer_return_ty_for_fn_sig`)
- rust-lang#134264 (Arbitrary self types v2: Weak & NonNull diagnostics)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1fa1f30 into rust-lang:masterDec 15, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
Rollup merge of rust-lang#134259 - compiler-errors:infer-ret-ty, r=dtolnay
Clean up `infer_return_ty_for_fn_sig`
The code for lowering fn signatures from HIR currently is structured to prefer the recovery path (where users write `-> _`) over the good path. This PR pulls the recovery code out into a separate fn.
Review w/o whitespace
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors@rustbot@dtolnay@bors@BoxyUwU