Skip to content

bootstrap: make ./x test error-index work - #134331

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:bootstrap-error-index
Dec 15, 2024
Merged

bootstrap: make ./x test error-index work#134331
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:bootstrap-error-index

Conversation

@RalfJung

Copy link
Copy Markdown
Member

This makes it more likely that someone who sees an error index CI failure will be able to figure out how to reproduce that locally. Note that bootstrap already prints "Testing stage2 error-index", which is misleading since the test is actually called error_index_generator.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 15, 2024
@onur-ozkan

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 15, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4795399 has been approved by onur-ozkan

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2024
@jieyouxu

Copy link
Copy Markdown
Member

@bors rollup

@jieyouxujieyouxu mentioned this pull request Dec 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
Rollup of 4 pull requests
Successful merges:
- rust-lang#134111 (Fix `--nocapture` for run-make tests)
- rust-lang#134329 (Add m68k_target_feature)
- rust-lang#134331 (bootstrap: make ./x test error-index work)
- rust-lang#134339 (Pass `TyCtxt` to early diagostics decoration)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b5602cf into rust-lang:masterDec 15, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
Rollup merge of rust-lang#134331 - RalfJung:bootstrap-error-index, r=onur-ozkan
bootstrap: make ./x test error-index work
This makes it more likely that someone who sees an error index CI failure will be able to figure out how to reproduce that locally. Note that bootstrap already prints "Testing stage2 error-index", which is misleading since the test is actually called error_index_generator.
@RalfJung
RalfJung deleted the bootstrap-error-index branch December 15, 2024 21:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung@rustbot@onur-ozkan@bors@jieyouxu