Skip to content

Disable tests/ui/associated-consts/issue-93775.rs on windows msvc - #134372

Merged
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:disable-flaky-test
Dec 16, 2024
Merged

Disable tests/ui/associated-consts/issue-93775.rs on windows msvc#134372
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:disable-flaky-test

Conversation

@jieyouxu

Copy link
Copy Markdown
Member

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2024

@NoratriebNoratrieb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the horrors

@Noratrieb

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 1cde4a4 has been approved by Noratrieb

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2024
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#134314 (Make sure to use normalized ty for unevaluated const in default struct value)
- rust-lang#134342 (crashes: more tests)
- rust-lang#134357 (Fix `trimmed_def_paths` ICE in the function ptr comparison lint)
- rust-lang#134369 (Update spelling of "referring")
- rust-lang#134372 (Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc)
Failed merges:
- rust-lang#134365 (Rename `rustc_mir_build::build` to `builder`)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2024
Rollup merge of rust-lang#134372 - jieyouxu:disable-flaky-test, r=Noratrieb
Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc
This test seems to be quite flaky. See:
- rust-lang#132111
- rust-lang#133432
@bors
bors merged commit 0a77972 into rust-lang:masterDec 16, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 16, 2024
@jieyouxu
jieyouxu deleted the disable-flaky-test branch December 16, 2024 11:06
@jieyouxujieyouxu added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu@rustbot@Noratrieb@bors