Skip to content

Add reference annotations for the coverage attribute - #134487

Merged
bors merged 1 commit into
rust-lang:masterfrom
ehuss:reference-coverage
Dec 20, 2024
Merged

Add reference annotations for the coverage attribute#134487
bors merged 1 commit into
rust-lang:masterfrom
ehuss:reference-coverage

Conversation

@ehuss

Copy link
Copy Markdown
Contributor

This adds reference annotations for the coverage attribute.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in coverage tests.

cc @Zalathar

@compiler-errors

Copy link
Copy Markdown
Contributor

r=me when green unless you'd want a review from Zalathar

@jieyouxujieyouxu added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Dec 19, 2024
@jieyouxu

Copy link
Copy Markdown
Member

This only adds "comments" effectively, so

@bors r=@compiler-errors rollup

@bors

bors commented Dec 19, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit dbf5ae3 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
- rust-lang#134487 (Add reference annotations for the `coverage` attribute)
- rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
- rust-lang#134502 (Update std libc version to 0.2.169)
- rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
- rust-lang#134487 (Add reference annotations for the `coverage` attribute)
- rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
- rust-lang#134502 (Update std libc version to 0.2.169)
- rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#134463 (compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes)
- rust-lang#134487 (Add reference annotations for the `coverage` attribute)
- rust-lang#134497 (coverage: Store coverage source regions as `Span` until codegen (take 2))
- rust-lang#134502 (Update std libc version to 0.2.169)
- rust-lang#134506 (Remove a duplicated check that doesn't do anything anymore.)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit fc11b5a into rust-lang:masterDec 20, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134487 - ehuss:reference-coverage, r=compiler-errors
Add reference annotations for the `coverage` attribute
This adds reference annotations for the `coverage` attribute.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ehuss@rustbot@compiler-errors@jieyouxu@bors@BoxyUwU