Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #134812
Merged
Merged
Conversation
…te keys. This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
This removes boilerplate around `Arc`s and makes the code more clear.
With rust-lang#80608 the `unwinding` crate no longer builds. The upstream crate has been updated to build by manually adding directives to the naked_asm stream. Bump the dependency in Rust to get this newer version. This fixes the build for Xous, and closesrust-lang#134403. Signed-off-by: Sean Cross <sean@xobs.io>
Rustdoc has no way to show that an item is stable, but only at a different path. `std::ffi::c_str::NulError` is not stable, but `std::ffi::NulError` is. To avoid marking these types as unstable when someone just wants to follow a link from `CString`, inline them into their stable paths.
…kang [macro_metavar_expr_concat] Fixrust-lang#128346Fixrust-lang#128346Fixrust-lang#131393 The syntax is invalid in both issues so I guess that theoretically the compiler should have aborted early. This PR tries to fix a local problem but let me know if there are better options. cc `@petrochenkov` if you are interested
Add `into_array` conversion destructors for `Box`, `Rc`, and `Arc`. Tracking issue: rust-lang#133508 This PR adds the `into_array` destructor for `alloc::boxed::Box<[T]>`, `alloc::rc::Rc<[T]>`, and `alloc::sync::Arc<[T]>`. Note that this PR assumes the initial proposal of these functions returning `Option`. It is still an open question whether this should instead be `Result`. We can, however, easily change this in a follow-up PR with the necessary consensus.
Document collection `From` and `FromIterator` impls that drop duplicate keys. This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first. Followup to rust-lang#89869.
Fix forgetting to save statx availability on success Looks like we forgot to save the statx state on success which means the first failure (common when checking if a file exists) will always require spending an invalid statx to confirm the failure is real. r? `@thomcc`
Use scoped threads in `std::sync::Barrier` examples This removes boilerplate around `Arc`s and makes the code more clear.
…ark-Simulacrum Update Code Example for `Iterator::rposition` Added an additional assertion to the example to show the behavior of `iter.next_back` after using `iter.rposition`.
…5.0, r=Mark-Simulacrum unwinding: bump version to fix naked_asm on Xous With rust-lang#80608 the `unwinding` crate no longer builds. The upstream crate has been updated to build by manually adding directives to the naked_asm stream. Bump the dependency in Rust to get this newer version. This fixes the build for Xous, and closesrust-lang#134403.
…or-types, r=tgross35 docs: inline `std::ffi::c_str` types to `std::ffi` Rustdoc has no way to show that an item is stable, but only at a different path. `std::ffi::c_str::NulError` is not stable, but `std::ffi::NulError` is. To avoid marking these types as unstable when someone just wants to follow a link from `CString`, inline them into their stable paths. Fixesrust-lang#134702 r? `@tgross35`
jhpratt
commented
Dec 27, 2024
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Dec 27, 2024
Collaborator
bors
commented
Dec 27, 2024
Collaborator
bors
commented
Dec 27, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Dec 27, 2024
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 917bfa7847 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Dec 27, 2024
Collaborator
Finished benchmarking commit (207ed1b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.4%, secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.398s -> 763.9s (-0.07%) |
poliorcetics pushed a commit
to poliorcetics/rust
that referenced
this pull request
Dec 28, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#131522 ([macro_metavar_expr_concat] Fixrust-lang#128346) - rust-lang#134379 (Add `into_array` conversion destructors for `Box`, `Rc`, and `Arc`.) - rust-lang#134644 (Document collection `From` and `FromIterator` impls that drop duplicate keys.) - rust-lang#134649 (Fix forgetting to save statx availability on success) - rust-lang#134728 (Use scoped threads in `std::sync::Barrier` examples) - rust-lang#134782 (Update Code Example for `Iterator::rposition`) - rust-lang#134789 (unwinding: bump version to fix naked_asm on Xous) - rust-lang#134791 (docs: inline `std::ffi::c_str` types to `std::ffi`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
None#128346)into_arrayconversion destructors forBox,Rc, andArc. #134379 (Addinto_arrayconversion destructors forBox,Rc, andArc.)FromandFromIteratorimpls that drop duplicate keys. #134644 (Document collectionFromandFromIteratorimpls that drop duplicate keys.)std::sync::Barrierexamples #134728 (Use scoped threads instd::sync::Barrierexamples)Iterator::rposition#134782 (Update Code Example forIterator::rposition)std::ffi::c_strtypes tostd::ffi#134791 (docs: inlinestd::ffi::c_strtypes tostd::ffi)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup