Skip to content

Implement const Destruct in old solver - #134875

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:const-destruct-old-solver
Jan 9, 2025
Merged

Implement const Destruct in old solver#134875
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:const-destruct-old-solver

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Dec 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Self-explanatory. Not totally settled that this is the best structure for built-in trait impls for effect goals in the new solver, but it's almost certainly the simplest.

r? lcnr or re-roll

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2024
@rustbotrustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Dec 29, 2024
@compiler-errors

compiler-errors commented Dec 29, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 29, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
@bors
Auto merge ofrust-lang#134875- compiler-errors:const-destruct-old-s…
950b5a5
…olver, r=<try>
Implement `const Destruct` in old solver
Self-explanatory. Not totally settled that this is the best structure for built-in trait impls for effect goals in the new solver, but it's almost certainly the simplest.
r? lcnr or re-roll
@bors

bors commented Dec 29, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 42a864a with merge 950b5a5...

@compiler-errors

compiler-errors commented Dec 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Testing perf if only bc I'm getting flashbacks from #93028, but that was also before we split ~const Drop and ~const Destruct, so maybe it doesn't matter now. This technically could mean we do more work in const checking 🤔

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Dec 29, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 950b5a5 (950b5a56d1fec901bbad2e1cb2c58f5fdf134133)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Dec 29, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (950b5a5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		4.0%[4.0%, 4.0%]1
Regressions ❌
(secondary)		2.8%[2.8%, 2.8%]1
Improvements ✅
(primary)		-1.3%[-1.4%, -1.1%]2
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.5%[-1.4%, 4.0%]3

Cycles

Results (secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-1.8%[-1.8%, -1.8%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.48s -> 762.426s (-0.14%)
Artifact size: 325.50 MiB -> 325.46 MiB (-0.01%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 29, 2024
lcnr
lcnr reviewed Jan 6, 2025
View reviewed changes
Comment threadcompiler/rustc_trait_selection/src/traits/effects.rs Outdated
lcnr
lcnr reviewed Jan 6, 2025
View reviewed changes
Comment threadcompiler/rustc_trait_selection/src/traits/effects.rs
@lcnr

lcnr commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

r=me after nit

@compiler-errors
compiler-errorsforce-pushed the const-destruct-old-solver branch from 75c55f1 to ec6d5bcCompareJanuary 6, 2025 18:02
@compiler-errors

compiler-errors commented Jan 6, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors r=lcnr rollup

@bors

bors commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit ec6d5bc has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 7, 2025
@jhpratt
Rollup merge ofrust-lang#134875- compiler-errors:const-destruct-old…
6ae7a88
…-solver, r=lcnr
Implement `const Destruct` in old solver
Self-explanatory. Not totally settled that this is the best structure for built-in trait impls for effect goals in the new solver, but it's almost certainly the simplest.
r? lcnr or re-roll
@jhprattjhpratt mentioned this pull request Jan 7, 2025
Closed
@jhpratt

jhpratt commented Jan 7, 2025

Copy link
Copy Markdown
Member

@bors r-

presumptive (partial) cause of #135181 (comment)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2025
@compiler-errors
compiler-errorsforce-pushed the const-destruct-old-solver branch from ec6d5bc to c64f859CompareJanuary 8, 2025 18:15
@compiler-errors

compiler-errors commented Jan 8, 2025

Copy link
Copy Markdown
ContributorAuthor

Blessed tests.

@bors r=lcnr

@bors

bors commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c64f859 has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2025
@matthiaskrgr
Rollup merge ofrust-lang#134875- compiler-errors:const-destruct-old…
614e17b
…-solver, r=lcnr
Implement `const Destruct` in old solver
Self-explanatory. Not totally settled that this is the best structure for built-in trait impls for effect goals in the new solver, but it's almost certainly the simplest.
r? lcnr or re-roll
This was referenced Jan 8, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@bors
Auto merge ofrust-lang#135277- matthiaskrgr:rollup-0k61sf8, r=matth…
65d7296
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#128110 (Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions)
- rust-lang#134609 (Add new `{x86_64,i686}-win7-windows-gnu` targets)
- rust-lang#134875 (Implement `const Destruct` in old solver)
- rust-lang#135221 (Include rustc and rustdoc book in replace-version-placeholder)
- rust-lang#135231 (bootstrap: Add more comments to some of the test steps)
- rust-lang#135256 (Move `mod cargo` below the import statements)
Failed merges:
- rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bbf6363 into rust-lang:masterJan 9, 2025
@rustbotrustbot added this to the 1.86.0 milestone Jan 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025
@rust-timer
Unrolled build forrust-lang#134875
454955b
Rollup merge of rust-lang#134875 - compiler-errors:const-destruct-old-solver, r=lcnr
Implement `const Destruct` in old solver
Self-explanatory. Not totally settled that this is the best structure for built-in trait impls for effect goals in the new solver, but it's almost certainly the simplest.
r? lcnr or re-roll
@fmeasefmease added the PG-const-traits Project group: Const traits label Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

PG-const-traitsProject group: Const traitsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

8 participants

@compiler-errors@rust-timer@bors@rust-log-analyzer@lcnr@jhpratt@fmease@rustbot