Uh oh!
There was an error while loading. Please reload this page.
triagebot: mark tidy changes with a more specific A-tidy label - #135194
Merged
Conversation
rustbot
commented
Jan 7, 2025
Collaborator
|
Uh oh!
There was an error while loading. Please reload this page.
jieyouxuforce-pushed
the
update-tidy-label
branch
from
January 7, 2025 11:01
660e0ea to
e872297Compare| "src/tools/tier-check" | ||
| "src/tools/rustdoc-gui-test", | ||
| "src/tools/suggest-tests", | ||
| "src/tools/tier-check", |
Contributor
There was a problem hiding this comment.
I feel like this alone doesn't make sense here. I wonder if replacing this with src/bootstrap/src/core/build_steps/test.rs would be better 🤔
MemberAuthor
There was a problem hiding this comment.
Do you mean the tier-check one?
MemberAuthor
There was a problem hiding this comment.
That makes more sense to me yeah.
MemberAuthor
There was a problem hiding this comment.
Changed tier-check -> the test step
jieyouxuforce-pushed
the
update-tidy-label
branch
from
January 7, 2025 12:25
e872297 to
7b801a8Compareonur-ozkan
approved these changes
Jan 8, 2025
jieyouxu
commented
Jan 8, 2025
MemberAuthor
@bors r=@onur-ozkan rollup |
bors
commented
Jan 8, 2025
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134228 (Exhaustively handle expressions in patterns) - rust-lang#135194 (triagebot: mark tidy changes with a more specific `A-tidy` label) - rust-lang#135222 (Ensure that we don't try to access fields on a non-struct pattern type) - rust-lang#135250 (A couple simple borrowck cleanups) - rust-lang#135252 (Fix release notes link) - rust-lang#135253 (Revert rust-lang#131365) Failed merges: - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134228 (Exhaustively handle expressions in patterns) - rust-lang#135194 (triagebot: mark tidy changes with a more specific `A-tidy` label) - rust-lang#135222 (Ensure that we don't try to access fields on a non-struct pattern type) - rust-lang#135250 (A couple simple borrowck cleanups) - rust-lang#135252 (Fix release notes link) - rust-lang#135253 (Revert rust-lang#131365) Failed merges: - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
Rollup merge of rust-lang#135194 - jieyouxu:update-tidy-label, r=onur-ozkan triagebot: mark tidy changes with a more specific `A-tidy` label r? `@onur-ozkan`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @onur-ozkan