Uh oh!
There was an error while loading. Please reload this page.
docs:Update rustc-dev-guide-book - #135337
Conversation
rustbot
commented
Jan 10, 2025
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
commented
Jan 10, 2025
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
QingyaoLin
commented
Jan 10, 2025
This is the commit record for the |
QingyaoLin
commented
Jan 11, 2025
Since I'm working on Windows, I also can't build rustc-dev-guide, so I don't know why it doesn't detect that Does this mean that mdbook-linkcheck2 is a potential bug? |
This comment has been minimized.
This comment has been minimized.
QingyaoLin
commented
Jan 17, 2025
What happened here? |
Kobzol
commented
Jan 17, 2025
You pushed a merge commit; instead, you should use rebases, as per the guide in the comment above. |
Rename `StringReader` to `Lexer` and update links. The `StringReader` struct link is invalid since pr:Merge `TokenTreesReader` into `StringReader`.
51abac5 to
9b1f700CompareQingyaoLin
commented
Jan 20, 2025
Fixed in rust-lang/rustc-dev-guide#2208 |
Kobzol
commented
Jan 20, 2025
In general, if a PR only modifies rustc-dev-guide, it should be sent against that repository. |
How should this be done? I don't quite understand how a PR for a large repository containing multiple sub-repositories should be targeted to the sub-repositories. Can I do this directly in the rust-lang-rust repository, or should I clone it separately and modify the subrepo and pull the PR? |
Kobzol
commented
Jan 20, 2025
If you only modify the code of a subtree (e.g. We tried to document this better in #135770. |
QingyaoLin
commented
Jan 20, 2025
Thanks,I understand. |
…uting, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? `@Kobzol` (or anyone really)
…uting, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? ``@Kobzol`` (or anyone really)
Rollup merge of rust-lang#135770 - jieyouxu:subtree-submodule-contributing, r=Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang#135337 (comment). r? ``@Kobzol`` (or anyone really)
…Kobzol Update contributing docs for submodule/subtree changes Noticed in rust-lang/rust#135337 (comment). r? ``@Kobzol`` (or anyone really)

Rename
StringReadertoLexerand update links.The
StringReaderstruct link is invalid since pr:MergeTokenTreesReaderintoStringReader.