Uh oh!
There was an error while loading. Please reload this page.
Do not include GCC source code in source tarballs - #135658
Merged
Merged
Conversation
The licensing story is unclear, it makes the archive much larger, and we should not need it for building anything in the tarballs (yet).
Kobzol
commented
Jan 20, 2025
MemberAuthor
@bors r=jieyouxu |
bors
commented
Jan 20, 2025
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
Rollup of 5 pull requests Successful merges: - rust-lang#135433 (Add Profile Override for Non-Git Sources) - rust-lang#135626 (doc: Point to methods on `Command` as alternatives to `set/remove_var`) - rust-lang#135658 (Do not include GCC source code in source tarballs) - rust-lang#135676 (rustc_resolve: use structured fields in traces) - rust-lang#135762 (Correct counting to four in cell module docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2025
Rollup merge of rust-lang#135658 - Kobzol:src-tarball-remove-gcc, r=jieyouxu Do not include GCC source code in source tarballs The licensing story is unclear, it makes the archive much larger, and we should not need it for building anything in the tarballs (yet). ``` Before: 121s building the archive 1.3 GiB gzipped size 5.7 GiB extracted size 402519 extracted files After: 64s building the archive 961 MiB gzipped size 4.5 GiB extracted size 257719 extracfed files ``` Fixes: rust-lang#135606 r? `@ehuss`
stefson
commented
Jan 21, 2025
@Kobzol: can you please be so kind to backport this to beta and stable branch? |
jieyouxu
commented
Jan 21, 2025
Member
Nominating for beta and stable backports, poll in https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Backporting.20.23135658.20to.20beta.20and.20stable/near/494974143. @rustbot label: +beta-nominated +stable-nominated |
Kobzol
commented
Jan 21, 2025
MemberAuthor
There's no need to backport to stable, as it was just released, but beta makes sense. |
jieyouxu
commented
Jan 21, 2025
Member
Ah sorry, missed that. |
stefson
commented
Jan 21, 2025
You might want to queue it up for stable, in case there will be a point release. Like an optional fix, not sure how rust manages these. |
cuviper
commented
Feb 5, 2025
Member
The zulip poll got 3 votes for beta backport, and none against, so I'm moving the process along... @rustbot label +beta-accepted |
Merged
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2025
[beta] backports - Ensure that we don't try to access fields on a non-struct pattern type rust-lang#135222 - Do not include GCC source code in source tarballs rust-lang#135658 - Temporarily bring back `Rvalue::Len` rust-lang#135709 - Add a couple of missing `ensure_sufficient_stacks` rust-lang#136352 - Enable kernel sanitizers for aarch64-unknown-none-softfloat rust-lang#135905 r? cuviper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The licensing story is unclear, it makes the archive much larger, and we should not need it for building anything in the tarballs (yet).
Fixes: #135606
r? @ehuss