Uh oh!
There was an error while loading. Please reload this page.
override build profile for bootstrap tests - #136157
Merged
Merged
Conversation
rustbot
commented
Jan 27, 2025
Collaborator
rustbot has assigned @Mark-Simulacrum. Use |
Kobzol
commented
Jan 27, 2025
Member
This is a nice API that we can use to selectively force debug compilation for selected steps. You can r=me after CI is green :) |
This comment has been minimized.
This comment has been minimized.
onur-ozkanforce-pushed
the
override-release-profile
branch
2 times, most recently
from
January 28, 2025 14:31
16f9a16 to
e5778f0Compareonur-ozkan
commented
Jan 28, 2025
ContributorAuthor
@rustbot author (I don't like the current approach and will improve this further) |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkanforce-pushed
the
override-release-profile
branch
from
January 29, 2025 11:49
e5778f0 to
869bc2fCompareonur-ozkan
commented
Jan 29, 2025
ContributorAuthor
Kobzol
commented
Jan 29, 2025
Member
The @bors r+ |
bors
commented
Jan 29, 2025
Collaborator
ContributorAuthor
Oops, wrong page 😄 |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135026 (Cast global variables to default address space) - rust-lang#135475 (uefi: Implement path) - rust-lang#135852 (Add `AsyncFn*` to `core` prelude) - rust-lang#136004 (tests: Skip const OOM tests on aarch64-unknown-linux-gnu) - rust-lang#136157 (override build profile for bootstrap tests) - rust-lang#136180 (Introduce a wrapper for "typed valtrees" and properly check the type before extracting the value) - rust-lang#136256 (Add release notes for 1.84.1) - rust-lang#136271 (Remove minor future footgun in `impl Debug for MaybeUninit`) - rust-lang#136288 (Improve documentation for file locking) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2025
Rollup merge of rust-lang#136157 - onur-ozkan:override-release-profile, r=Kobzol override build profile for bootstrap tests Using the release profile for bootstrap self tests puts too much load on the CPU and makes it quite hot on `x test bootstrap` invocation for no good reason. It also makes the compilation take longer than usual (see rust-lang#136048 (comment)). This change turns off the release flag for bootstrap self tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the release profile for bootstrap self tests puts too much load on the CPU and makes it quite hot on
x test bootstrapinvocation for no good reason. It also makes the compilation take longer than usual (see #136048 (comment)). This change turns off the release flag for bootstrap self tests.