ci: refactor how directories are removed in free-disk-space disk by marcoieni · Pull Request #136238 · rust-lang/rust

marcoieni · 2025-01-29T11:17:41Z

refactor how directories are removed.
add set -euo pipefail to fail if there's an error in the script. This helps us realize when we make mistakes.
don't delete directory "/opt/ghc" because it doesn't exist. This directory isn't present in ubuntu 24 as well.
solve all shellcheck issues.

try-job: aarch64-gnu

rustbot · 2025-01-29T11:17:50Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

marcoieni · 2025-01-29T13:15:05Z

@rustbot ready

Kobzol · 2025-01-29T22:43:22Z

@bors r+ rollup

bors · 2025-01-29T22:43:26Z

📌 Commit 89de239 has been approved by Kobzol

It is now in the queue for this repository.

…bzol ci: refactor how directories are removed in free-disk-space disk

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133636 ([rustdoc] Add sans-serif font setting) - rust-lang#135434 (Match Ergonomics 2024: update edition 2024 behavior of feature gates) - rust-lang#135739 (Clean up uses of the unstable `dwarf_version` option) - rust-lang#135882 (simplify `similar_tokens` from `Option<Vec<_>>` to `&[_]`) - rust-lang#136179 (Allow transmuting generic pattern types to and from their base) - rust-lang#136199 (Fix a couple Emscripten tests) - rust-lang#136238 (ci: refactor how directories are removed in free-disk-space disk) - rust-lang#136251 (use impl Into<String> instead of explicit type args with bounds) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-01-30T11:46:55Z

@bors r-
this is not working #136285 (comment)

2025-01-30T11:38:35.9453186Z 3ddd26ca0e11854152de3b22030cba1560f6ca8f
2025-01-30T11:38:35.9618451Z ##[group]Run src/ci/scripts/free-disk-space.sh
2025-01-30T11:38:35.9618881Z �[36;1msrc/ci/scripts/free-disk-space.sh�[0m
2025-01-30T11:38:35.9657806Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2025-01-30T11:38:35.9658136Z env:
2025-01-30T11:38:35.9658473Z TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
2025-01-30T11:38:35.9659380Z TOOLSTATE_REPO_ACCESS_TOKEN: ***
2025-01-30T11:38:35.9659637Z CI_JOB_NAME: aarch64-gnu
2025-01-30T11:38:35.9659894Z CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
2025-01-30T11:38:35.9660202Z HEAD_SHA: 3ddd26ca0e11854152de3b22030cba1560f6ca8f
2025-01-30T11:38:35.9660570Z DOCKER_TOKEN: ***
2025-01-30T11:38:35.9660783Z SCCACHE_BUCKET: rust-lang-ci-sccache2
2025-01-30T11:38:35.9661052Z CACHE_DOMAIN: ci-caches.rust-lang.org
2025-01-30T11:38:35.9661306Z ##[endgroup]
2025-01-30T11:38:35.9756411Z ================================================================================
2025-01-30T11:38:35.9756837Z BEFORE CLEAN-UP:
2025-01-30T11:38:35.9756992Z 2025-01-30T11:38:35.9757071Z $ df -h
2025-01-30T11:38:35.9757196Z 2025-01-30T11:38:35.9766959Z Filesystem Size Used Avail Use% Mounted on
2025-01-30T11:38:35.9767330Z /dev/root 73G 27G 46G 37% /
2025-01-30T11:38:35.9767604Z tmpfs 7.8G 4.0K 7.8G 1% /dev/shm
2025-01-30T11:38:35.9767880Z tmpfs 3.2G 1000K 3.2G 1% /run
2025-01-30T11:38:35.9768166Z tmpfs 5.0M 0 5.0M 0% /run/lock
2025-01-30T11:38:35.9768481Z efivarfs 128M 16K 128M 1% /sys/firmware/efi/efivars
2025-01-30T11:38:35.9768801Z /dev/sda15 98M 6.3M 92M 7% /boot/efi
2025-01-30T11:38:35.9769093Z tmpfs 1.6G 4.0K 1.6G 1% /run/user/1001
2025-01-30T11:38:35.9771069Z ================================================================================
2025-01-30T11:38:35.9771291Z 2025-01-30T11:38:41.8955476Z E: Unable to locate package google-chrome-stable
2025-01-30T11:38:41.8955843Z E: Unable to locate package powershell
2025-01-30T11:38:41.8956165Z E: Unable to locate package google-cloud-sdk
2025-01-30T11:38:41.8956477Z E: Unable to locate package google-cloud-cli
2025-01-30T11:38:41.8987897Z ##[error]Process completed with exit code 100.
2025-01-30T11:38:41.9201938Z Post job cleanup.
2025-01-30T11:38:41.9981899Z [command]/usr/bin/git version
2025-01-30T11:38:42.0013286Z git version 2.48.1

matthiaskrgr · 2025-01-30T11:47:16Z

@bors try

bors · 2025-01-30T11:48:28Z

⌛ Trying commit 89de239 with merge 5b9c2fb...

ci: refactor how directories are removed in free-disk-space disk

marcoieni · 2025-01-30T12:56:42Z

I'll have a look, thanks!

I added aarch64-gnu to the try jobs list.

bors · 2025-01-30T13:35:51Z

☀️ Try build successful - checks-actions
Build commit: 5b9c2fb (5b9c2fb066fa7167b38d45ef0d493795a0e66f3b)

bors · 2025-01-30T14:06:23Z

💔 Test failed - checks-actions

marcoieni · 2025-01-30T14:06:41Z

@bors try

ci: refactor how directories are removed in free-disk-space disk try-job: aarch64-gnu

bors · 2025-01-30T14:07:58Z

⌛ Trying commit 053fa1c with merge 934ad23...

marcoieni · 2025-01-30T14:18:18Z

The issue was that certain packages aren't installed in the arm runners.
I think the script should work now 👍

Kobzol · 2025-01-30T14:31:38Z

@bors r+ rollup=never

bors · 2025-01-30T14:31:45Z

📌 Commit 053fa1c has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-01-30T16:08:48Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 934ad23 to master...

bors · 2025-01-30T16:09:49Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

Kobzol · 2025-01-30T16:22:48Z

Crap, I didn't notice that the try build was still running. Hopefully nothing got broken.

@bors r-

Kobzol · 2025-01-30T16:23:45Z

@bors r+

bors · 2025-01-30T16:23:48Z

📌 Commit 053fa1c has been approved by Kobzol

It is now in the queue for this repository.

bors · 2025-02-02T10:51:53Z

⌛ Testing commit 053fa1c with merge 6dd75f0...

bors · 2025-02-02T13:37:35Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 6dd75f0 to master...

rust-timer · 2025-02-02T15:11:02Z

Finished benchmarking commit (6dd75f0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.7%	[5.7%, 5.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.275s -> 778.443s (0.15%)
Artifact size: 328.69 MiB -> 328.63 MiB (-0.02%)

rustbot assigned Mark-Simulacrum Jan 29, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 29, 2025

marcoieni force-pushed the free-disk-refactor branch from e0ecabe to 89de239Compare January 29, 2025 11:35

marcoieni commented Jan 29, 2025
View reviewed changes

Comment threadsrc/ci/scripts/free-disk-space.sh

marcoieni commented Jan 29, 2025
View reviewed changes

Comment threadsrc/ci/scripts/free-disk-space.sh

marcoieni marked this pull request as ready for review January 29, 2025 11:38

marcoieni mentioned this pull request Jan 29, 2025
[experiment] ci: free more space in ubuntu 24 free runners #136247
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 30, 2025
Rollup merge ofrust-lang#136238- marcoieni:free-disk-refactor, r=Ko…
5e5537a
…bzol ci: refactor how directories are removed in free-disk-space disk

matthiaskrgr mentioned this pull request Jan 30, 2025
Rollup of 7 pull requests #136276
Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 30, 2025
Rollup merge ofrust-lang#136238- marcoieni:free-disk-refactor, r=Ko…
8923b79
…bzol ci: refactor how directories are removed in free-disk-space disk

matthiaskrgr mentioned this pull request Jan 30, 2025
Rollup of 8 pull requests #136277
Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 30, 2025
Rollup merge ofrust-lang#136238- marcoieni:free-disk-refactor, r=Ko…
2d03d79
…bzol ci: refactor how directories are removed in free-disk-space disk

matthiaskrgr mentioned this pull request Jan 30, 2025
Rollup of 8 pull requests #136285
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
Auto merge ofrust-lang#136238- marcoieni:free-disk-refactor, r=<try>
5b9c2fb
ci: refactor how directories are removed in free-disk-space disk

This comment has been minimized.
Sign in to view

ci: refactor how directories are removed in free-disk-space disk
053fa1c

marcoieni force-pushed the free-disk-refactor branch from 1fa6434 to 053fa1cCompare January 30, 2025 14:06

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2025
Auto merge ofrust-lang#136238- marcoieni:free-disk-refactor, r=<try>
934ad23
ci: refactor how directories are removed in free-disk-space disk try-job: aarch64-gnu

Kobzol reviewed Jan 30, 2025
View reviewed changes

Comment threadsrc/ci/scripts/free-disk-space.sh

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2025

Kobzol removed the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 30, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 2, 2025

bors merged commit 6dd75f0 into rust-lang:masterFeb 2, 2025

rustbot added this to the 1.86.0 milestone Feb 2, 2025

Uh oh!

Uh oh!

Conversation

marcoieni commented Jan 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 29, 2025

Uh oh!

Uh oh!

Uh oh!

marcoieni commented Jan 29, 2025

Uh oh!

Kobzol commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

matthiaskrgr commented Jan 30, 2025

Uh oh!

matthiaskrgr commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

marcoieni commented Jan 30, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jan 30, 2025

Uh oh!

This comment has been minimized.

bors commented Jan 30, 2025

Uh oh!

marcoieni commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

marcoieni commented Jan 30, 2025

Uh oh!

Uh oh!

Kobzol commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

Kobzol commented Jan 30, 2025

Uh oh!

Kobzol commented Jan 30, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

bors commented Feb 2, 2025

Uh oh!

bors commented Feb 2, 2025

Uh oh!

rust-timer commented Feb 2, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

marcoieni commented Jan 29, 2025•
edited
Loading

marcoieni commented Jan 30, 2025•
edited
Loading