Uh oh!
There was an error while loading. Please reload this page.
ping me for attribute-related changes - #136643
Merged
Merged
Conversation
rustbot
commented
Feb 6, 2025
Collaborator
|
jdonszelmann
commented
Feb 6, 2025
ContributorAuthor
I also added A-attribute autolabeling, seemed useful but lmk if you disagree |
fmease
approved these changes
Feb 6, 2025
fmease
reviewed
Feb 6, 2025
| "compiler/rustc_passes/src/check_attr.rs", | ||
| "compiler/rustc_attr_parsing", | ||
| "compiler/rustc_attr_data_structures", | ||
| "compiler/rustc_attr_validation", |
Member
There was a problem hiding this comment.
While this doesn't exist yet on master, I'd say it's fine. We can always update triagebot.toml later if things change. I just hope triagebot won't freak out ^^' but I doubt that.
ContributorAuthor
There was a problem hiding this comment.
oh yea, I added it because I know I'll add it like in my next pr so I don't forget but let's hope nothing breaks
fmease
commented
Feb 6, 2025
Member
@bors r+ rollup |
bors
commented
Feb 6, 2025
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 6, 2025
…r=fmease ping me for attribute-related changes r? `@fmease`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136592 (Make sure we don't overrun the stack in canonicalizer) - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#135973 (fix tail call checks wrt `#[track_caller]`) - rust-lang#136191 (compiler: replace few consts arrays with statics to remove const dupes) - rust-lang#136565 (compiler: Clean up weird `rustc_abi` reexports) - rust-lang#136582 (Revert "CI: build FreeBSD artifacts on FreeBSD 13.4") - rust-lang#136627 (MIR validation: add comment explaining the limitations of CfgChecker) - rust-lang#136634 (Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.) - rust-lang#136643 (ping me for attribute-related changes) - rust-lang#136644 (Add `rustc_hir_pretty::item_to_string` function) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
Rollup merge of rust-lang#136643 - jdonszelmann:add-triagebot-attrs, r=fmease ping me for attribute-related changes r? `@fmease`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @fmease