Skip to content

Add support for 64-bit Windows builds - #13692

Merged
bors merged 3 commits into
rust-lang:masterfrom
vadimcn:Win64-pre
Apr 23, 2014
Merged

Add support for 64-bit Windows builds#13692
bors merged 3 commits into
rust-lang:masterfrom
vadimcn:Win64-pre

Conversation

@vadimcn

Copy link
Copy Markdown
Contributor

Stack unwinding doesn't work yet, so this won't pass a lot of tests.

@alexcrichton

Copy link
Copy Markdown
Member

Awesome work, nice job!

Have you had much luck with backtraces?

@vadimcn

Copy link
Copy Markdown
ContributorAuthor

backtrace won't work in this version, because it requires stack unwinding. Once LLVM SEH patch is added, it works, however you don't get any symbols, because dbghelp.dll doesn't know how to use DWARF debug info.

@vadimcn

Copy link
Copy Markdown
ContributorAuthor

better?

bors added a commit that referenced this pull request Apr 23, 2014
Stack unwinding doesn't work yet, so this won't pass a lot of tests.
@borsbors closed this Apr 23, 2014
@bors
bors merged commit f686e5e into rust-lang:masterApr 23, 2014
@kud1ingkud1ing mentioned this pull request May 1, 2014
@vadimcn
vadimcn deleted the Win64-pre branch March 1, 2015 08:01
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 9, 2025
… comments (rust-lang#13911)
Fixesrust-lang#13692.
If the `vec!` macro call contains comments, we should not provide
suggestions and let users handle it however they see fit.
changelog: Only emit `useless_vec` suggestion if the macro does not
contain code comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vadimcn@alexcrichton@bors