Uh oh!
There was an error while loading. Please reload this page.
Prune dead regionck code - #137183
Merged
Merged
Conversation
rustbot
commented
Feb 17, 2025
Collaborator
lcnr
commented
Feb 17, 2025
Contributor
r=me with green ci |
compiler-errors
commented
Feb 17, 2025
ContributorAuthor
@bors r=lcnr rollup |
bors
commented
Feb 17, 2025
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 18, 2025
…, r=lcnr Prune dead regionck code We never encounter `ObligationCauseCode`s that correspond to region obligations that originate from "within" a body, since we don't do HIR regionck anymore on bodies. So prune some dead code.
bors
commented
Feb 18, 2025
Collaborator
☔ The latest upstream changes (presumably #137162) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errorsforce-pushed
the
dead-regionck-code
branch
2 times, most recently
from
February 21, 2025 18:27
057098a to
132c1b5Comparecompiler-errors
commented
Feb 21, 2025
ContributorAuthor
@bors r=lcnr rollup |
bors
commented
Feb 21, 2025
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 21, 2025
…, r=lcnr Prune dead regionck code We never encounter `ObligationCauseCode`s that correspond to region obligations that originate from "within" a body, since we don't do HIR regionck anymore on bodies. So prune some dead code.
matthiaskrgr
commented
Feb 21, 2025
Member
will probably clash with #137397 |
bors
commented
Feb 22, 2025
Collaborator
☔ The latest upstream changes (presumably #137397) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errorsforce-pushed
the
dead-regionck-code
branch
from
February 22, 2025 00:03
132c1b5 to
b2b2e53Comparecompiler-errors
commented
Feb 22, 2025
ContributorAuthor
@bors r=lcnr |
bors
commented
Feb 22, 2025
Collaborator
compiler-errors added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 22, 2025
…, r=lcnr Prune dead regionck code We never encounter `ObligationCauseCode`s that correspond to region obligations that originate from "within" a body, since we don't do HIR regionck anymore on bodies. So prune some dead code.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2025
…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#136910 (Implement feature `isolate_most_least_significant_one` for integer types) - rust-lang#137183 (Prune dead regionck code) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) - rust-lang#137356 (Ferris 🦀 Identifier naming conventions) - rust-lang#137362 (Add build step log for `run-make-support`) - rust-lang#137377 (Always allow reusing cratenum in CrateLoader::load) - rust-lang#137388 (Fix(lib/fs/tests): Disable rename POSIX semantics FS tests under Windows 7) - rust-lang#137410 (Use StableHasher + Hash64 for dep_tracking_hash) - rust-lang#137413 (jubilee cleared out the review queue) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#136910 (Implement feature `isolate_most_least_significant_one` for integer types) - rust-lang#137183 (Prune dead regionck code) - rust-lang#137333 (Use `edition = "2024"` in the compiler (redux)) - rust-lang#137356 (Ferris 🦀 Identifier naming conventions) - rust-lang#137362 (Add build step log for `run-make-support`) - rust-lang#137377 (Always allow reusing cratenum in CrateLoader::load) - rust-lang#137388 (Fix(lib/fs/tests): Disable rename POSIX semantics FS tests under Windows 7) - rust-lang#137410 (Use StableHasher + Hash64 for dep_tracking_hash) - rust-lang#137413 (jubilee cleared out the review queue) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2025
Rollup merge of rust-lang#137183 - compiler-errors:dead-regionck-code, r=lcnr Prune dead regionck code We never encounter `ObligationCauseCode`s that correspond to region obligations that originate from "within" a body, since we don't do HIR regionck anymore on bodies. So prune some dead code.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never encounter
ObligationCauseCodes that correspond to region obligations that originate from "within" a body, since we don't do HIR regionck anymore on bodies. So prune some dead code.