Teach structured errors to display short `Ty<'_>` by estebank · Pull Request #137201 · rust-lang/rust

estebank · 2025-02-18T01:52:42Z

Make it so that in every structured error annotated with #[derive(Diagnostic)] that has a field of type Ty<'_>, the printing of that value into a String will look at the thread-local storage TyCtxt in order to shorten to a length appropriate with the terminal width. When this happen, the resulting error will have a note with the file where the full type name was written to.

error[E0618]: expected function, found `((..., ..., ..., ...), ..., ..., ...)``
--> long.rs:7:5
|
6 | fn foo(x: D) { //~ `x` has type `(...
| - `x` has type `((..., ..., ..., ...), ..., ..., ...)`
7 | x(); //~ ERROR expected function, found `(...
| ^--
| |
| call expression requires function
|
= note: the full name for the type has been written to 'long.long-type-14182675702747116984.txt'
= note: consider using `--verbose` to print the full type name to the console

Follow up to and response to the comments on #136898.

r? @oli-obk

rustbot · 2025-02-18T01:52:51Z

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @rust-lang/wg-const-eval

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred in need_type_info.rs

cc @lcnr

oli-obk · 2025-02-25T08:32:33Z

@bors r+

bors · 2025-02-25T08:32:37Z

📌 Commit 2dcd85f has been approved by oli-obk

It is now in the queue for this repository.

…, r=oli-obk Teach structured errors to display short `Ty<'_>` Make it so that in every structured error annotated with `#[derive(Diagnostic)]` that has a field of type `Ty<'_>`, the printing of that value into a `String` will look at the thread-local storage `TyCtxt` in order to shorten to a length appropriate with the terminal width. When this happen, the resulting error will have a note with the file where the full type name was written to. ``` error[E0618]: expected function, found `((..., ..., ..., ...), ..., ..., ...)`` --> long.rs:7:5 | 6 | fn foo(x: D) { //~ `x` has type `(... | - `x` has type `((..., ..., ..., ...), ..., ..., ...)` 7 | x(); //~ ERROR expected function, found `(... | ^-- | | | call expression requires function | = note: the full name for the type has been written to 'long.long-type-14182675702747116984.txt' = note: consider using `--verbose` to print the full type name to the console ``` Follow up to and response to the comments on rust-lang#136898. r? `@oli-obk`

fmease · 2025-02-25T12:29:26Z

Needs rebase due to #135726 which added

implIntoDiagArgforRustcVersion{fninto_diag_arg(self) -> DiagArgValue{DiagArgValue::Str(Cow::Owned(self.to_string()))}}

to https://github.com/rust-lang/blobrust/blob/compiler/rustc_errors/src/diagnostic_impls.rs.

(CI failed in rollup #137607: #137607 (comment))

@bors r-

Make it so that every structured error annotated with `#[derive(Diagnostic)]` that has a field of type `Ty<'_>`, the printing of that value into a `String` will look at the thread-local storage `TyCtxt` in order to shorten to a length appropriate with the terminal width. When this happen, the resulting error will have a note with the file where the full type name was written to. ``` error[E0618]: expected function, found `((..., ..., ..., ...), ..., ..., ...)`` --> long.rs:7:5 | 6 | fn foo(x: D) { //~ `x` has type `(... | - `x` has type `((..., ..., ..., ...), ..., ..., ...)` 7 | x(); //~ ERROR expected function, found `(... | ^-- | | | call expression requires function | = note: the full name for the type has been written to 'long.long-type-14182675702747116984.txt' = note: consider using `--verbose` to print the full type name to the console ```

``` error[E0614]: type `(..., ..., ..., ...)` cannot be dereferenced --> $DIR/long-E0614.rs:10:5 | LL | *x; | ^^ can't be dereferenced | = note: the full name for the type has been written to '$TEST_BUILD_DIR/$FILE.long-type-hash.txt' = note: consider using `--verbose` to print the full type name to the console ```

estebank · 2025-02-26T05:06:59Z

@bors r=oli-obk

bors · 2025-02-26T05:07:02Z

📌 Commit c550bee has been approved by oli-obk

It is now in the queue for this repository.

…, r=oli-obk Teach structured errors to display short `Ty<'_>` Make it so that in every structured error annotated with `#[derive(Diagnostic)]` that has a field of type `Ty<'_>`, the printing of that value into a `String` will look at the thread-local storage `TyCtxt` in order to shorten to a length appropriate with the terminal width. When this happen, the resulting error will have a note with the file where the full type name was written to. ``` error[E0618]: expected function, found `((..., ..., ..., ...), ..., ..., ...)`` --> long.rs:7:5 | 6 | fn foo(x: D) { //~ `x` has type `(... | - `x` has type `((..., ..., ..., ...), ..., ..., ...)` 7 | x(); //~ ERROR expected function, found `(... | ^-- | | | call expression requires function | = note: the full name for the type has been written to 'long.long-type-14182675702747116984.txt' = note: consider using `--verbose` to print the full type name to the console ``` Follow up to and response to the comments on rust-lang#136898. r? `@oli-obk`

Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#137201 - estebank:structured-errors-long-ty, r=oli-obk Teach structured errors to display short `Ty<'_>` Make it so that in every structured error annotated with `#[derive(Diagnostic)]` that has a field of type `Ty<'_>`, the printing of that value into a `String` will look at the thread-local storage `TyCtxt` in order to shorten to a length appropriate with the terminal width. When this happen, the resulting error will have a note with the file where the full type name was written to. ``` error[E0618]: expected function, found `((..., ..., ..., ...), ..., ..., ...)`` --> long.rs:7:5 | 6 | fn foo(x: D) { //~ `x` has type `(... | - `x` has type `((..., ..., ..., ...), ..., ..., ...)` 7 | x(); //~ ERROR expected function, found `(... | ^-- | | | call expression requires function | = note: the full name for the type has been written to 'long.long-type-14182675702747116984.txt' = note: consider using `--verbose` to print the full type name to the console ``` Follow up to and response to the comments on rust-lang#136898. r? ``@oli-obk``

rustbot assigned oli-obk Feb 18, 2025

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Feb 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 18, 2025

RalfJung reviewed Feb 18, 2025
View reviewed changes

Comment threadcompiler/rustc_errors/src/diagnostic.rs

estebank force-pushed the structured-errors-long-ty branch from d8758cd to 56a942bCompare February 19, 2025 01:27

RalfJung reviewed Feb 19, 2025
View reviewed changes

Comment threadcompiler/rustc_errors/src/diagnostic.rs Outdated

estebank force-pushed the structured-errors-long-ty branch from 56a942b to a33d786Compare February 19, 2025 16:49

This comment has been minimized.
Sign in to view

RalfJung reviewed Feb 19, 2025
View reviewed changes

Comment threadcompiler/rustc_errors/src/diagnostic.rs Outdated

estebank mentioned this pull request Feb 19, 2025
Make some invalid codegen attr errors structured/translatable #137279
Merged

estebank force-pushed the structured-errors-long-ty branch 2 times, most recently from b19a017 to 2dcd85fCompare February 19, 2025 17:35

estebank mentioned this pull request Feb 19, 2025
Long type name emitted if the type name is part of a suggestion #135919
Open
10 tasks

oli-obk reviewed Feb 21, 2025
View reviewed changes

Comment threadcompiler/rustc_middle/src/ty/predicate.rs
Comment threadcompiler/rustc_errors/src/diagnostic.rs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2025

fmease mentioned this pull request Feb 25, 2025
Rollup of 7 pull requests #137607
Closed

fmease closed this Feb 25, 2025

fmease reopened this Feb 25, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2025

This comment has been minimized.
Sign in to view

estebank added 2 commits February 25, 2025 16:56

Add tests
693ed26

estebank added 5 commits February 25, 2025 16:56

Make E0529 a structured error
ae3a825

Make E0609 a structured error
26f74ef

add doc comment detail
a4e89de

Fix rebase
c550bee

estebank force-pushed the structured-errors-long-ty branch from 2dcd85f to c550beeCompare February 25, 2025 17:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 26, 2025

fmease mentioned this pull request Feb 26, 2025
Rollup of 10 pull requests #137672
Closed

fmease mentioned this pull request Feb 26, 2025
Rollup of 10 pull requests #137688
Merged

bors merged commit 5da5c37 into rust-lang:masterFeb 26, 2025

rustbot added this to the 1.87.0 milestone Feb 26, 2025

estebank mentioned this pull request Jul 14, 2025
const-eval error: always say in which item the error occurred #142008
Merged

Navigation Menu

Uh oh!

Uh oh!

Teach structured errors to display short `Ty<'_>` - #137201

Teach structured errors to display short `Ty<'_>`#137201
bors merged 7 commits into
rust-lang:masterfrom
estebank:structured-errors-long-ty

estebank commented Feb 18, 2025

Uh oh!

rustbot commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Feb 25, 2025

Uh oh!

bors commented Feb 25, 2025

Uh oh!

fmease commented Feb 25, 2025•
edited
Loading

Uh oh!

This comment has been minimized.

estebank commented Feb 26, 2025

Uh oh!

bors commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

estebank commented Feb 18, 2025

Uh oh!

rustbot commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

oli-obk commented Feb 25, 2025

Uh oh!

bors commented Feb 25, 2025

Uh oh!

fmease commented Feb 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

estebank commented Feb 26, 2025

Uh oh!

bors commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fmease commented Feb 25, 2025•
edited
Loading