Skip to content

fix usage of ty decl macro fragments in attributes - #137758

Merged
bors merged 1 commit into
rust-lang:masterfrom
jdonszelmann:fix-137662
Mar 7, 2025
Merged

fix usage of ty decl macro fragments in attributes#137758
bors merged 1 commit into
rust-lang:masterfrom
jdonszelmann:fix-137662

Conversation

@jdonszelmann

@jdonszelmannjdonszelmann commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

See the test case. Due to one missing code path (and also the changes in #137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.

Closes#137662

@rustbot

Copy link
Copy Markdown
Collaborator

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2025
@tgross35

tgross35 commented Feb 28, 2025

Copy link
Copy Markdown
Member

Would you mind updating the title / commit message to describe what the change is so referencing the issue isn't needed? The test's doc comment should also describe what it is testing, for the same reason.

@compiler-errors

Copy link
Copy Markdown
Contributor

Yeap, I agree with tgross35 here. I know it's a draft PR so no worries if you were planning on editing the title later, but a title like "Account for XXX in YYY so that ZZZ" is a lot more helpful than "fix issue ###" 😺.

@jdonszelmann

jdonszelmann commented Feb 28, 2025

Copy link
Copy Markdown
ContributorAuthor

That's why it's a draft, it's not ready yet. I made it in 2 minutes before going to bed yesterday evening

@jdonszelmannjdonszelmann changed the title add test to reproduce #137662 and fix itfix usage of ty decl macro fragments in attributesFeb 28, 2025
@jdonszelmann

Copy link
Copy Markdown
ContributorAuthor

Ok this is better. I just wanted to see if CI would pass overnight but you were totally right for noticing this PR needed a little more work :)

@jdonszelmann
jdonszelmann marked this pull request as ready for review March 1, 2025 06:47
@jdonszelmann

Copy link
Copy Markdown
ContributorAuthor

r? @compiler-errors

@nnethercote

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 2, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 41dd80a has been approved by nnethercote

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 3, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
@tgross35tgross35 mentioned this pull request Mar 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2025
Rollup of 6 pull requests
Successful merges:
- rust-lang#135695 (Support raw-dylib link kind on ELF)
- rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137794 (make qnx pass a test)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2025
Rollup of 6 pull requests
Successful merges:
- rust-lang#135695 (Support raw-dylib link kind on ELF)
- rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137794 (make qnx pass a test)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 4, 2025
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes)
- rust-lang#137722 (`librustdoc`: 2024 edition! 🎊)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137913 (Allow struct field default values to reference struct's generics)
- rust-lang#137963 (Add ``dyn`` keyword to `E0373` examples)
- rust-lang#137975 (Remove unused `PpMode::needs_hir`)
r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 4, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 5, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
…kingjubilee
Rollup of 20 pull requests
Successful merges:
- rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra)
- rust-lang#136764 (Make `ptr_cast_add_auto_to_object` lint into hard error)
- rust-lang#136798 (Added documentation for flushing per rust-lang#74348)
- rust-lang#136865 (Perform deeper compiletest path normalization for `$TEST_BUILD_DIR` to account for compare-mode/debugger cases, and normalize long type file filename hashes)
- rust-lang#136975 (Look for `python3` first on MacOS, not `py`)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 5, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
…kingjubilee
Rollup of 25 pull requests
Successful merges:
- rust-lang#134063 (dec2flt: Clean up float parsing modules)
- rust-lang#136581 (Retire the legacy `Makefile`-based `run-make` test infra)
- rust-lang#136662 (Count char width at most once in `Formatter::pad`)
- rust-lang#136798 (Added documentation for flushing per rust-lang#74348)
- rust-lang#137240 (Slightly reformat `std::fs::remove_dir_all` error docs)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes)
- rust-lang#137477 (uefi: Add Service Binding Protocol abstraction)
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137569 (Stabilize `string_extend_from_within`)
- rust-lang#137612 (Update bootstrap to edition 2024)
- rust-lang#137633 (Only use implied bounds hack if bevy, and use deeply normalize in implied bounds hack)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137679 (Various coretests improvements)
- rust-lang#137723 (Make `rust.description` more general-purpose and pass `CFG_VER_DESCRIPTION`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#138028 (compiler: add `ExternAbi::is_rustic_abi`)
r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 5, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
@jieyouxujieyouxu mentioned this pull request Mar 5, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
Rollup of 23 pull requests
Successful merges:
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
- rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update `compiler-builtins` to 0.1.151)
- rust-lang#138041 (bootstrap and compiletest: Use `size_of_val` from the prelude instead of imported)
- rust-lang#138046 (trim channel value in `get_closest_merge_commit`)
- rust-lang#138053 (Increase the max. custom try jobs requested to `20`)
r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 5, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
@jieyouxujieyouxu mentioned this pull request Mar 5, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2025
Rollup of 29 pull requests
Successful merges:
- rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars)
- rust-lang#137107 (Override default `Write` methods for cursor-like types)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137612 (Update bootstrap to edition 2024)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc` on x64 linux)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137827 (Add timestamp to unstable feature usage metrics)
- rust-lang#137832 (Fix crash in BufReader::peek())
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
- rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update `compiler-builtins` to 0.1.151)
- rust-lang#138046 (trim channel value in `get_closest_merge_commit`)
- rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test)
- rust-lang#138053 (Increase the max. custom try jobs requested to `20`)
r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 5, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
@jieyouxujieyouxu mentioned this pull request Mar 5, 2025
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Mar 6, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Mar 6, 2025
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
@NoratriebNoratrieb mentioned this pull request Mar 6, 2025
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Mar 6, 2025
…compiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
…mpiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
…mpiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in `mir_keys`, fix error body synthesis)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars)
- rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
- rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update `compiler-builtins` to 0.1.151)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2025
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars)
- rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
- rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update `compiler-builtins` to 0.1.151)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 34d273b into rust-lang:masterMar 7, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
Rollup merge of rust-lang#137758 - jdonszelmann:fix-137662, r=nnethercote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using $ty or other specific fragments as part of an attr wouldn't work. $tt used to work since it wouldn't be parsed anywhere along the way.
Closesrust-lang#137662
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 14, 2025
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars)
- rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove `MaybeForgetReturn` suggestion)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums)
- rust-lang#137744 (Re-add `Clone`-derive on `Thir`)
- rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in `Display` for `ByteStr`)
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT)
- rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update `compiler-builtins` to 0.1.151)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation error in the vulkano crate on nightly expected isize, found i32

7 participants

@jdonszelmann@rustbot@tgross35@compiler-errors@nnethercote@bors@cjgillot