Rollup of 8 pull requests by matthiaskrgr · Pull Request #138302 · rust-lang/rust

matthiaskrgr · 2025-03-10T08:32:17Z

Successful merges:

Update to rand 0.9.0 #136395 (Update to rand 0.9.0)
Make some invalid codegen attr errors structured/translatable #137279 (Make some invalid codegen attr errors structured/translatable)
Update documentation to consistently use 'm' in atomic synchronization example #137585 (Update documentation to consistently use 'm' in atomic synchronization example)
Add a test for -znostart-stop-gc usage with LLD #137926 (Add a test for -znostart-stop-gc usage with LLD)
Support File::seek for Hermit #138074 (Support File::seek for Hermit)
Fix dyn -> param suggestion in struct ICEs #138238 (Fix dyn -> param suggestion in struct ICEs)
chore: Fix some comments #138270 (chore: Fix some comments)
triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search (… #138286 (triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search (…)

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Signed-off-by: StevenMia <flite@foxmail.com>

…again)

…acrum Update to rand 0.9.0 Changes include: - `thread_rng` has been renamed to `rng` - `Standard` has been renamed to `StandardUniform` - `gen`, `gen_range`, `gen_bool` have been renamed to `random`, `random_range` and `random_bool` respectively.

…, r=nnethercote Make some invalid codegen attr errors structured/translatable

…bilee Update documentation to consistently use 'm' in atomic synchronization example Fixesrust-lang#135801

Add a test for `-znostart-stop-gc` usage with LLD This test replicates the behavior of https://github.com/dtolnay/linkme, to test that it still works even with LLD. Without `-znostart-stop-gc` the test fails. r? ``@lqd`` try-job: x86_64-gnu try-job: x86_64-msvc-1

…nton Support `File::seek` for Hermit `lseek` was added in `hermit-abi` in commit [87dd201](hermit-os/hermit-rs@87dd201) (add missing interface for lseek, 2024-07-15), which was just released in version 0.5.0. cc ``@mkroening,`` ``@stlankes`` Fixeshermit-os/hermit-rs#652

…struct, r=nnethercote Fix dyn -> param suggestion in struct ICEs Makes the logic from rust-lang#138042 a bit less ICEy and more clean. Also fixes an incorrect suggestion when the struct already has generics. I'll point out the major changes and observations in the code. Fixesrust-lang#138229Fixesrust-lang#138211 r? nnethercote since you reviewed the original pr, or re-roll if you don't want to review this

chore: Fix some comments Fix some comments

…3, r=compiler-errors triagebot.toml: Don't label `test/rustdoc-json` as A-rustdoc-search (… Followup to rust-lang#137958. I managed to miss a place, as shown by the questionable labeling of rust-lang#138285.

matthiaskrgr · 2025-03-10T08:32:42Z

@bors r+ rollup=never p=5

rust-log-analyzer · 2025-03-10T18:36:15Z

The job armhf-gnu failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-03-10T18:36:58Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-03-10T18:40:36Z

@bors retry
2025-03-10T18:36:02.0742736Z thread 'main' panicked at src/tools/remote-test-client/src/main.rs:309:9: 2025-03-10T18:36:02.0743637Z client.read_exact(&mut header) failed with Connection reset by peer (os error 104) 2025-03-10T18:36:02.0744533Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bors · 2025-03-10T21:44:21Z

⌛ Testing commit 49ca431 with merge bf6bf50...

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136395 (Update to rand 0.9.0) - rust-lang#137279 (Make some invalid codegen attr errors structured/translatable) - rust-lang#137585 (Update documentation to consistently use 'm' in atomic synchronization example) - rust-lang#137926 (Add a test for `-znostart-stop-gc` usage with LLD) - rust-lang#138074 (Support `File::seek` for Hermit) - rust-lang#138238 (Fix dyn -> param suggestion in struct ICEs) - rust-lang#138270 (chore: Fix some comments) - rust-lang#138286 (triagebot.toml: Don't label `test/rustdoc-json` as A-rustdoc-search (…) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-03-10T23:40:14Z

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-pe.rs#i686_pc_windows_msvc stdout ----
error in revision `i686_pc_windows_msvc`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "i686_pc_windows_msvc" "--check-cfg" "cfg(test,FALSE,aarch64_pc_windows_msvc,aarch64_pc_windows_gnullvm,aarch64_unknown_uefi,aarch64_uwp_windows_msvc,arm64ec_pc_windows_msvc,avr_none,bpfeb_unknown_none,bpfel_unknown_none,i686_pc_windows_gnu,i686_pc_windows_msvc,i686_pc_windows_gnullvm,i686_uwp_windows_gnu,i686_win7_windows_gnu,i686_unknown_uefi,i686_uwp_windows_msvc,i686_win7_windows_msvc,powerpc64_ibm_aix,thumbv7a_uwp_windows_msvc,thumbv7a_pc_windows_msvc,x86_64_pc_windows_gnu,x86_64_pc_windows_gnullvm,x86_64_pc_windows_msvc,x86_64_unknown_uefi,x86_64_uwp_windows_gnu,x86_64_win7_windows_gnu,x86_64_uwp_windows_msvc,x86_64_win7_windows_msvc,x86_64_pc_cygwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-pe.i686_pc_windows_msvc\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "--target" "i686-pc-windows-msvc" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustc5fq9rU"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 491 passed; 1 failed; 40 ignored; 0 measured; 0 filtered out; finished in 27.00s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:47:16
make: *** [Makefile:128: ci-mingw-x] Error 1
local time: Mon Mar 10 23:40:00 CUT 2025
network time: Mon, 10 Mar 2025 23:40:00 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

bors · 2025-03-10T23:40:52Z

💔 Test failed - checks-actions

jieyouxu · 2025-03-10T23:48:37Z

@bors retry (access denied spurious)

bors · 2025-03-11T00:55:29Z

⌛ Testing commit 49ca431 with merge 9038494...

bors · 2025-03-11T03:57:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9038494 to master...

rust-log-analyzer · 2025-03-11T03:58:13Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

 Compiling build_helper v0.1.0 (/home/runner/work/rust/rust/src/build_helper)
Compiling ureq v3.0.8
Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
Finished `release` profile [optimized] target(s) in 33.39s
Running `target/release/citool post-merge-analysis 9fb94b32df38073bf63d009df77ed10cb1c989d0 90384941aae4ea38de00e4702b50757e9b882a19`
error: unrecognized subcommand 'post-merge-analysis'
tip: a similar subcommand exists: 'post-merge-report'
Usage: citool <COMMAND>
For more information, try '--help'.
##[error]Process completed with exit code 2.

rust-timer · 2025-03-11T03:59:19Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#136395	Update to rand 0.9.0	`3412c2510b5378adb73ad7b193ed29dfdcbb88ac` (link)
#137279	Make some invalid codegen attr errors structured/translatab…	`9ffd216352095c6f72933b7238e9a9953bda164f` (link)
#137585	Update documentation to consistently use 'm' in atomic sync…	`7bda6add485c320b88130a7b7ba991f2a83db966` (link)
#137926	Add a test for `-znostart-stop-gc` usage with LLD	`9d6ea5f99b35d2964af38e0d81d81e7752835caf` (link)
#138074	Support `File::seek` for Hermit	`cd658cb01fc544e137b3003eb5c1803e5a34f9cb` (link)
#138238	Fix dyn -> param suggestion in struct ICEs	`8dc946dd4cb74c29bea6ef8673c87c5031414c2e` (link)
#138270	chore: Fix some comments	`acbbf91c69d476ca9bc3d77a1da8d99a696613c2` (link)
#138286	triagebot.toml: Don't label `test/rustdoc-json` as A-rustdo…	`dc170aa2ff62d61b199250227ccf801eb378252f` (link)

previous master: 9fb94b32df

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-03-11T05:48:32Z

Finished benchmarking commit (9038494): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[2.7%, 4.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.9%	[-4.9%, -4.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.019s -> 782.162s (0.40%)
Artifact size: 365.14 MiB -> 365.19 MiB (0.01%)

xizheyinand others added 20 commits February 25, 2025 13:01

fix doc in library/core/src/sync/atomic.rs
3835dc2
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

Make some invalid codegen attr errors structured/translatable
f0dec71

Add test for garbage collection of encapsulation symbols
7bf4e99

Rework maybe_suggest_add_generic_impl_trait
bca0ab8

Fix suggestion when there are generics, inline some things
ceb0401

chore: Fix some comments
3583554
Signed-off-by: StevenMia <flite@foxmail.com>

triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search (…
eecf17e
…again)

Update hermit-abi to 0.5.0
32d0c4e

Support File::seek for Hermit
1abaacd

Update rand to 0.9.0
1c7aaf9

Allow wit-bindgen-rt as compiler dependency
9b71e86

Support locking versions in permitted rustc deps
aea9ddd

Rollup merge ofrust-lang#137279- estebank:codegen-structured-errors…
c8194f1
…, r=nnethercote Make some invalid codegen attr errors structured/translatable

Rollup merge ofrust-lang#137585- xizheyin:issue-135801, r=workingju…
2270979
…bilee Update documentation to consistently use 'm' in atomic synchronization example Fixesrust-lang#135801

Rollup merge ofrust-lang#138270- StevenMia:master, r=compiler-errors
86065ac
chore: Fix some comments Fix some comments

Rollup merge ofrust-lang#138286- aDotInTheVoid:aDotInTheVoid-patch-…
49ca431
…3, r=compiler-errors triagebot.toml: Don't label `test/rustdoc-json` as A-rustdoc-search (… Followup to rust-lang#137958. I managed to miss a place, as shown by the questionable labeling of rust-lang#138285.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2025

jieyouxu added the CI-spurious-fail-mingw CI spurious failure: target env mingw label Mar 10, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2025

bors merged commit 9038494 into rust-lang:masterMar 11, 2025

rustbot added this to the 1.87.0 milestone Mar 11, 2025

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Mar 10, 2025

Uh oh!

matthiaskrgr commented Mar 10, 2025

Uh oh!

rust-log-analyzer commented Mar 10, 2025

Uh oh!

bors commented Mar 10, 2025

Uh oh!

matthiaskrgr commented Mar 10, 2025

Uh oh!

bors commented Mar 10, 2025

Uh oh!

rust-log-analyzer commented Mar 10, 2025

Uh oh!

bors commented Mar 10, 2025

Uh oh!

jieyouxu commented Mar 10, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

rust-log-analyzer commented Mar 11, 2025

Uh oh!

rust-timer commented Mar 11, 2025

Uh oh!

rust-timer commented Mar 11, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants