Skip to content

Some autodiff cleanups - #138345

Merged
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:autodiff-cleanup
Mar 12, 2025
Merged

Some autodiff cleanups#138345
bors merged 2 commits into
rust-lang:masterfrom
oli-obk:autodiff-cleanup

Conversation

@oli-obk

@oli-obkoli-obk commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

cc @ZuseZ4

just some things I noticed

@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2025
@compiler-errors

Copy link
Copy Markdown
Contributor

r? compiler-errors @bors r+ rollup

@bors

bors commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 9882eca has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
…er-errors
Some autodiff cleanups
cc `@ZuseZ4`
just some things I noticed
@jieyouxujieyouxu mentioned this pull request Mar 12, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
…er-errors
Some autodiff cleanups
cc ``@ZuseZ4``
just some things I noticed
@jieyouxujieyouxu mentioned this pull request Mar 12, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
Rollup of 25 pull requests
Successful merges:
- rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
- rust-lang#136842 (Add libstd support for Trusty targets)
- rust-lang#137314 (change definitely unproductive cycles to error)
- rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
- rust-lang#137621 (Add std support to cygwin target)
- rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
- rust-lang#138109 (make precise capturing args in rustdoc Json typed)
- rust-lang#138161 (Add PeekMut::refresh)
- rust-lang#138162 (Update the standard library to Rust 2024)
- rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`)
- rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
- rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr)
- rust-lang#138313 (Update books)
- rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138333 (Rebuild llvm spuriously less frequently)
- rust-lang#138343 (Enable `f16` tests for `powf`)
- rust-lang#138345 (Some autodiff cleanups)
- rust-lang#138346 (naked functions: on windows emit `.endef` without the symbol name)
- rust-lang#138347 (Reduce `kw::Empty` usage, part 2)
- rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint)
- rust-lang#138371 (Update compiletest's `has_asm_support` to match rustc)
- rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`)
- rust-lang#138376 (Item-related cleanups)
- rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 12, 2025
…er-errors
Some autodiff cleanups
cc ```@ZuseZ4```
just some things I noticed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#137314 (change definitely unproductive cycles to error)
- rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
- rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138345 (Some autodiff cleanups)
- rust-lang#138387 (intrinsics: remove unnecessary leading underscore from argument names)
- rust-lang#138389 (use `expect` instead of `allow`)
- rust-lang#138390 (fix incorrect tracing log)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#137314 (change definitely unproductive cycles to error)
- rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
- rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138345 (Some autodiff cleanups)
- rust-lang#138387 (intrinsics: remove unnecessary leading underscore from argument names)
- rust-lang#138390 (fix incorrect tracing log)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit de7e5e9 into rust-lang:masterMar 12, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 12, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
Rollup merge of rust-lang#138345 - oli-obk:autodiff-cleanup, r=compiler-errors
Some autodiff cleanups
cc ````@ZuseZ4````
just some things I noticed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@rustbot@compiler-errors@bors@davidtwco