Skip to content

merge TypeChecker and TypeVerifier - #138357

Merged
bors merged 4 commits into
rust-lang:masterfrom
lcnr:goodbye-TypeVerifier-rarw
Mar 13, 2025
Merged

merge TypeChecker and TypeVerifier#138357
bors merged 4 commits into
rust-lang:masterfrom
lcnr:goodbye-TypeVerifier-rarw

Conversation

@lcnr

@lcnrlcnr commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Stacked on top of #138354. Best reviewed commit by commit.

r? @compiler-errors

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2025
@lcnr

lcnr commented Mar 11, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2025
@bors
Auto merge ofrust-lang#138357- lcnr:goodbye-TypeVerifier-rarw, r=<try>
93da1b8
merge `TypeChecker` and `TypeVerifier`
Stacked on top of rust-lang#138354. Best reviewed commit by commit.
r? `@compiler-errors`
@bors

bors commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit a5eb387 with merge 93da1b8...

@bors

bors commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 93da1b8 (93da1b882b7d1f75a6957ee9a9279deae096b9f1)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (93da1b8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.2%[-0.2%, -0.2%]1
Improvements ✅
(secondary)		-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]1

Max RSS (memory usage)

Results (primary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		1.3%[1.3%, 1.3%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)1.3%[1.3%, 1.3%]1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 782.898s -> 781.518s (-0.18%)
Artifact size: 365.21 MiB -> 365.08 MiB (-0.04%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2025
@compiler-errors

compiler-errors commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

r=me after #138283 and #138354 land

@compiler-errors

compiler-errors commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

actually, I'll rebase my PR on top of this one. r=me once just the other PR lands.

@compiler-errorscompiler-errors mentioned this pull request Mar 11, 2025
Merged
@compiler-errors

compiler-errors commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Actually this can merge regardless, auto-merge should be smart enough to cherry-pick just the changed commits.

@bors r+

@bors

bors commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit a5eb387 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@compiler-errors

compiler-errors commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

pretty sure the perf is noise

@bors rollup

@ManishearthManishearth mentioned this pull request Mar 12, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@bors
Auto merge ofrust-lang#138416- Manishearth:rollup-fejor9p, r=Manish…
2357dd4
…earth
Rollup of 12 pull requests
Successful merges:
- rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
- rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
- rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
- rust-lang#138259 (Disentangle `ForwardGenericParamBan` and `ConstParamTy` ribs)
- rust-lang#138280 (fix ICE in pretty-printing `global_asm!`)
- rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138357 (merge `TypeChecker` and `TypeVerifier`)
- rust-lang#138394 (remove unnecessary variant)
- rust-lang#138403 (Delegation: one more ICE fix for `MethodCall` generation)
- rust-lang#138407 (Delegation: reject C-variadics)
- rust-lang#138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
@bors
Auto merge ofrust-lang#138416- Manishearth:rollup-fejor9p, r=Manish…
8536f20
…earth
Rollup of 12 pull requests
Successful merges:
- rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
- rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
- rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
- rust-lang#138259 (Disentangle `ForwardGenericParamBan` and `ConstParamTy` ribs)
- rust-lang#138280 (fix ICE in pretty-printing `global_asm!`)
- rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138357 (merge `TypeChecker` and `TypeVerifier`)
- rust-lang#138394 (remove unnecessary variant)
- rust-lang#138403 (Delegation: one more ICE fix for `MethodCall` generation)
- rust-lang#138407 (Delegation: reject C-variadics)
- rust-lang#138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 74c3794 into rust-lang:masterMar 13, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 13, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
@rust-timer
Unrolled build forrust-lang#138357
996af83
Rollup merge of rust-lang#138357 - lcnr:goodbye-TypeVerifier-rarw, r=compiler-errors
merge `TypeChecker` and `TypeVerifier`
Stacked on top of rust-lang#138354. Best reviewed commit by commit.
r? `@compiler-errors`
@lcnr
lcnr deleted the goodbye-TypeVerifier-rarw branch March 13, 2025 08:18
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 14, 2025
@bors
Auto merge ofrust-lang#138416- Manishearth:rollup-fejor9p, r=Manish…
b296531
…earth
Rollup of 12 pull requests
Successful merges:
- rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
- rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
- rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
- rust-lang#138259 (Disentangle `ForwardGenericParamBan` and `ConstParamTy` ribs)
- rust-lang#138280 (fix ICE in pretty-printing `global_asm!`)
- rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
- rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
- rust-lang#138357 (merge `TypeChecker` and `TypeVerifier`)
- rust-lang#138394 (remove unnecessary variant)
- rust-lang#138403 (Delegation: one more ICE fix for `MethodCall` generation)
- rust-lang#138407 (Delegation: reject C-variadics)
- rust-lang#138409 (Use sa_sigaction instead of sa_union.__su_sigaction for AIX)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lcnr@rust-timer@bors@compiler-errors@rustbot