Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #138595
Merged
Merged
Conversation
…e for the time being
Signed-off-by: Ookiineko <chiisaineko@protonmail.com>
Signed-off-by: Ookiineko <chiisaineko@protonmail.com>
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
…r=joshtriplett Stablize anonymous pipe Since rust-lang#135822 is staled, I create this PR to stablise anonymous pipe Closesrust-lang#127154 try-job: test-various
std: Mention clone-on-write mutation in Arc<T> Fixesrust-lang#138322 r? libs
…re, r=oli-obk Improve upvar analysis for deref of child capture Two fixes to the heuristic I implemented in rust-lang#123660. As I noted in the code: > Luckily, if this function is not correct, then the program is not unsound, since we still borrowck and validate the choices made from this function -- the only side-effect is that the user may receive unnecessary borrowck errors. This indeed fixes unnecessary borrowck errors. r? oli-obk --- The heuristic is only valid if we deref a `&T`, not a `&mut T` or `Box<T>`, so make sure to check the type. This fixes: ```rust struct Foo { precise: i32 } fn mut_ref_inside_mut(f: &mut Foo) { let x: impl AsyncFn() = async move || { let y = &f.precise; }; } ``` Since the capture from `f` to `&f.precise` needs to be treated as a lending borrow from the parent coroutine-closure to the child coroutine. --- The heuristic is also valid if *any* deref projection in the child capture's projections is a `&T`, but we were only looking at the last one. This ensures that this function is considered not to be lending: ```rust struct Foo { precise: i32 } fn ref_inside_mut(f: &mut &Foo) { let x: impl Fn() -> _ = async move || { let y = &f.precise; }; } ``` (Specifically, checking that `impl Fn() -> _` is satisfied is exercising that the coroutine is not considered to be lending.)
Update Rust Foundation links in Readme The Rust Foundation links in the Readme are outdated. I'm not sure if this is the best wording to use in place of the media guide, that can be changed if need be.
Document `#![register_tool]` cc rust-lang#66079
Flatten and simplify some control flow 🫓
update change entry for rust-lang#137147 r? `@RalfJung`
jhpratt
commented
Mar 17, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Mar 17, 2025
Collaborator
bors
commented
Mar 17, 2025
Collaborator
bors
commented
Mar 17, 2025
Collaborator
☀️ Test successful - checks-actions |
rust-log-analyzer
commented
Mar 17, 2025
Collaborator
A job failed! Check out the build log: (web)(plain) Click to see the possible cause of the failure (guessed by this bot) |
rust-timer
commented
Mar 17, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 9bad8ac498 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Mar 17, 2025
Collaborator
Finished benchmarking commit (9c67cec): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 1.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary 0.5%, secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 776.387s -> 774.895s (-0.19%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
*_valuemethods to proc_macro lib #136355 (Add*_valuemethods to proc_macro lib)#![register_tool]#138586 (Document#![register_tool])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup