Add unstable `--print=supported-crate-types` option by jieyouxu · Pull Request #138641 · rust-lang/rust

jieyouxu · 2025-03-18T05:48:01Z

MCP: rust-lang/compiler-team#836
Tracking issue: #138640

Test coverage

Two tests:

tests/ui/print-request/stability.rs to check that --print=supported-crate-types is -Zunstable-options-gated
tests/ui/print-request/supported-crate-types.rs is added as a basic smoke test. Observe that the compiler stdout corresponds to the below Example output section (e.g. proc-macro is unsupported on wasm32-unknown-unknown currently).

Example output

For `x86_64-unknown-linux-gnu`

Notice the presence of {c,}dylib and proc-macro:

bin
cdylib
dylib
lib
proc-macro
rlib
staticlib

For `wasm32-unknown-unknown`

Notice the absence of dylib and proc-macro:

bin
cdylib
lib
rlib
staticlib

For `x86_64-unknown-linux-musl`

Notice the absence of {c,}dylib but presence of proc-macro:

bin
lib
proc-macro
rlib
staticlib

Documentation

I added an entry in the unstable book's print request section to document this supported-crate-types print request.

Unresolved questions

(Name bikeshedding) is supported-crate-types a good name for the print request? I'm inclined to say it's good enough for an unstable print request, but may be worth revisiting at stabilization time.

Stability

This print request being added is unstable in this PR. A separate stabilization PR following the usual compiler flag stabilization procedure should be filed for stabilization after some baking time.

Review remarks

Best reviewed commit-by-commit.

r? compiler

jieyouxu · 2025-03-18T06:40:25Z

@rustbot ready

weihanglo · 2025-03-21T02:08:45Z

Really looking forward to using this in Cargo. Thank you folks!

bors · 2025-03-21T02:59:56Z

☔ The latest upstream changes (presumably #138747) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-03-21T06:11:56Z

Reblessed tests due to extra help line.
@rustbot ready

jieyouxu · 2025-03-21T06:55:36Z

-//@ check-fail
-//@ compile-flags: /dev/null --print lints


I was a bit confused by this test, it turns out we are checking for the -Whelp suggestion if the invalid print request --print=lints was specified.

jieyouxu · 2025-03-21T06:56:27Z

+//@ error-pattern: error: unknown print request: `lints`
+//@ error-pattern: help: use `-Whelp` to print a list of lints
+//@ error-pattern: help: for more information, see the rustc book


Ensure that the test intention can't be accidentally blessed away as easily.

Urgau

LGTM

Urgau · 2025-03-21T17:22:14Z

r? Urgau
@bors r+ rollup

bors · 2025-03-21T17:22:17Z

📌 Commit 405d1c4 has been approved by Urgau

It is now in the queue for this repository.

…es, r=Urgau Add unstable `--print=supported-crate-types` option MCP: rust-lang/compiler-team#836 Tracking issue: rust-lang#138640 ### Test coverage Two tests: 1. `tests/ui/print-request/stability.rs` to check that `--print=supported-crate-types` is `-Zunstable-options`-gated 2. `tests/ui/print-request/supported-crate-types.rs` is added as a basic smoke test. Observe that the compiler stdout corresponds to the below *Example output* section (e.g. `proc-macro` is unsupported on `wasm32-unknown-unknown` currently). ### Example output <details> <summary>For `x86_64-unknown-linux-gnu`</summary> Notice the presence of `{c,}dylib` and `proc-macro`: ``` bin cdylib dylib lib proc-macro rlib staticlib ``` </details> <details> <summary>For `wasm32-unknown-unknown`</summary> Notice the absence of `dylib` and `proc-macro`: ``` bin cdylib lib rlib staticlib ``` </details> <details> <summary>For `x86_64-unknown-linux-musl`</summary> Notice the absence of `{c,}dylib` but presence of `proc-macro`: ``` bin lib proc-macro rlib staticlib ``` </details> ### Documentation I added an entry in the unstable book's print request section to document this `supported-crate-types` print request. ### Unresolved questions - [ ] (Name bikeshedding) is `supported-crate-types` a good name for the print request? I'm inclined to say it's good enough for an unstable print request, but may be worth revisiting at stabilization time. ### Stability This print request being added is *unstable* in this PR. A separate stabilization PR following the usual compiler flag stabilization procedure should be filed for stabilization after some baking time. ### Review remarks Best reviewed commit-by-commit. r? compiler

Rollup of 9 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138602 (Slim `rustc_parse_format` dependencies down) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138641 (Add unstable `--print=supported-crate-types` option) - rust-lang#138662 (Implement some basics in UEFI fs) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-03-23T10:10:33Z

@bors r-
guess this failed here
#138853 (comment)

jieyouxu · 2025-03-23T11:06:35Z

Yes, it's because I wrote needs-llvm-components: wasm instead of needs-llvm-components: webassembly.

As an unstable print request.

- Document test intent to check for `-Whelp` suggestion if `--print=lints` was specified. - Move this test under `tests/ui/print-request/` and rename it to `print-lints-help.rs` to better reflect what it is checking.

jieyouxu · 2025-03-23T11:21:45Z

Fixed the llvm component name.
@bors r=Urgau

bors · 2025-03-23T11:21:47Z

📌 Commit f2cde8e has been approved by Urgau

It is now in the queue for this repository.

…mpiler-errors Rollup of 12 pull requests Successful merges: - rust-lang#136040 (Remove unused trait BoundedSize) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138545 (Add MIR pre-codegen tests to track rust-lang#138544) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138641 (Add unstable `--print=supported-crate-types` option) - rust-lang#138667 (std: uefi: fs: Implement mkdir) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) - rust-lang#138854 (Fix ICE rust-lang#138415 for invalid extern function body) - rust-lang#138858 (Say which test failed the `COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS` assertion) - rust-lang#138861 (Tweak type flags, fix missing flags from coroutine kind ty) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138641 - jieyouxu:print-supported-crate-types, r=Urgau Add unstable `--print=supported-crate-types` option MCP: rust-lang/compiler-team#836 Tracking issue: rust-lang#138640 ### Test coverage Two tests: 1. `tests/ui/print-request/stability.rs` to check that `--print=supported-crate-types` is `-Zunstable-options`-gated 2. `tests/ui/print-request/supported-crate-types.rs` is added as a basic smoke test. Observe that the compiler stdout corresponds to the below *Example output* section (e.g. `proc-macro` is unsupported on `wasm32-unknown-unknown` currently). ### Example output <details> <summary>For `x86_64-unknown-linux-gnu`</summary> Notice the presence of `{c,}dylib` and `proc-macro`: ``` bin cdylib dylib lib proc-macro rlib staticlib ``` </details> <details> <summary>For `wasm32-unknown-unknown`</summary> Notice the absence of `dylib` and `proc-macro`: ``` bin cdylib lib rlib staticlib ``` </details> <details> <summary>For `x86_64-unknown-linux-musl`</summary> Notice the absence of `{c,}dylib` but presence of `proc-macro`: ``` bin lib proc-macro rlib staticlib ``` </details> ### Documentation I added an entry in the unstable book's print request section to document this `supported-crate-types` print request. ### Unresolved questions - [ ] (Name bikeshedding) is `supported-crate-types` a good name for the print request? I'm inclined to say it's good enough for an unstable print request, but may be worth revisiting at stabilization time. ### Stability This print request being added is *unstable* in this PR. A separate stabilization PR following the usual compiler flag stabilization procedure should be filed for stabilization after some baking time. ### Review remarks Best reviewed commit-by-commit. r? compiler

rustbot assigned fee1-dead Mar 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 18, 2025

jieyouxu mentioned this pull request Mar 18, 2025
Tracking Issue for --print=supported-crate-types#138640
Open
5 tasks

This comment has been minimized.
Sign in to view

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Mar 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2025

Urgau reviewed Mar 18, 2025
View reviewed changes

Comment threadsrc/doc/rustc/src/command-line-arguments.md Outdated

jieyouxu force-pushed the print-supported-crate-types branch from 9448784 to ef06252Compare March 18, 2025 06:53

jieyouxu added the A-print-requests Area: print requests (`--print=...`) label Mar 19, 2025

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025

jieyouxu force-pushed the print-supported-crate-types branch from ef06252 to 675bfebCompare March 21, 2025 06:10

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2025

This comment has been minimized.
Sign in to view

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025

jieyouxu commented Mar 21, 2025
View reviewed changes

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2025

Urgau approved these changes Mar 21, 2025
View reviewed changes

rustbot assigned Urgau Mar 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025

rustbot unassigned fee1-dead Mar 21, 2025

jieyouxu mentioned this pull request Mar 23, 2025
Rollup of 9 pull requests #138853
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2025

jieyouxu added 4 commits March 23, 2025 19:08

Implement supported-crate-types print request
0e7dbab
As an unstable print request.

Document supported-crate-types print request in unstable book
13530af

Rebless tests with changed help due to new print request option
f1b8d89

Adjust rustc-print-info-issue-138612.rs
f2cde8e
- Document test intent to check for `-Whelp` suggestion if `--print=lints` was specified. - Move this test under `tests/ui/print-request/` and rename it to `print-lints-help.rs` to better reflect what it is checking.

jieyouxu force-pushed the print-supported-crate-types branch from 405d1c4 to f2cde8eCompare March 23, 2025 11:21

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2025

compiler-errors mentioned this pull request Mar 23, 2025
Rollup of 12 pull requests #138866
Merged

bors merged commit 21cdebc into rust-lang:masterMar 24, 2025

rustbot added this to the 1.87.0 milestone Mar 24, 2025

jieyouxu deleted the print-supported-crate-types branch March 24, 2025 01:15

obi1kenobi mentioned this pull request Mar 24, 2025
Failure targeting wasm32-unknown-unknownobi1kenobi/cargo-semver-checks-action#98
Open

Uh oh!

Uh oh!

Conversation

jieyouxu commented Mar 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test coverage

Example output

Documentation

Unresolved questions

Stability

Review remarks

Uh oh!

This comment has been minimized.

jieyouxu commented Mar 18, 2025

Uh oh!

Uh oh!

weihanglo commented Mar 21, 2025

Uh oh!

bors commented Mar 21, 2025

Uh oh!

jieyouxu commented Mar 21, 2025

Uh oh!

This comment has been minimized.

jieyouxuMar 21, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxuMar 21, 2025

Choose a reason for hiding this comment

Uh oh!

Urgau left a comment

Choose a reason for hiding this comment

Uh oh!

Urgau commented Mar 21, 2025

Uh oh!

bors commented Mar 21, 2025

Uh oh!

matthiaskrgr commented Mar 23, 2025

Uh oh!

jieyouxu commented Mar 23, 2025

Uh oh!

jieyouxu commented Mar 23, 2025

Uh oh!

bors commented Mar 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jieyouxu commented Mar 18, 2025•
edited
Loading