') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Improve suggest construct with literal syntax instead of calling by xizheyin · Pull Request #139014 · rust-lang/rust · GitHub
Skip to content

Improve suggest construct with literal syntax instead of calling - #139014

Merged
bors merged 2 commits into
rust-lang:masterfrom
xizheyin:issue-138931
Mar 27, 2025
Merged

Improve suggest construct with literal syntax instead of calling#139014
bors merged 2 commits into
rust-lang:masterfrom
xizheyin:issue-138931

Conversation

@xizheyin

@xizheyinxizheyin commented Mar 27, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#138931

When constructing a structure through a format similar to calling a constructor, we can use verbose suggestions to hint at using literal syntax for clearer advice. The case of multiple fields is also considered here, provided that the field has the same number of arguments as CallExpr.

r? compiler

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2025
@oli-obk

oli-obk commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Please make your ui test commit pass on its own so the second commit shows the difference. That makes it a bit easier to review

@xizheyin
Add ui test for struct construction by calling syntax
d0353f5
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@xizheyin

xizheyin commented Mar 27, 2025

Copy link
Copy Markdown
MemberAuthor

Ok, I submitted the test in the first commit and got it to pass on the original version of the code. In the second commit I modified the code and submitted the changes to the ui test output.
@oli-obk

oli-obk
oli-obk reviewed Mar 27, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs Outdated
@xizheyin
Improve suggest construct with literal syntax instead of calling
4648650
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@oli-obk

oli-obk commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 4648650 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2025
@jhprattjhpratt mentioned this pull request Mar 27, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2025
@bors
Auto merge ofrust-lang#139023- jhpratt:rollup-4ou6ei4, r=jhpratt
3f55023
Rollup of 7 pull requests
Successful merges:
- rust-lang#138844 (expand: Leave traces when expanding `cfg` attributes)
- rust-lang#138926 (Remove `kw::Empty` uses from `rustc_middle`.)
- rust-lang#138989 (Clean up a few things in rustc_hir_analysis::check::region)
- rust-lang#138999 (Report compiletest pass mode if forced)
- rust-lang#139014 (Improve suggest construct with literal syntax instead of calling)
- rust-lang#139015 (Remove unneeded LLVM CI test assertions)
- rust-lang#139016 (Add job duration changes to post-merge analysis report)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d517a4f into rust-lang:masterMar 27, 2025
@rustbotrustbot added this to the 1.87.0 milestone Mar 27, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2025
@rust-timer
Unrolled build forrust-lang#139014
99ed0df
Rollup merge of rust-lang#139014 - xizheyin:issue-138931, r=oli-obk
Improve suggest construct with literal syntax instead of calling
Closing rust-lang#138931
When constructing a structure through a format similar to calling a constructor, we can use verbose suggestions to hint at using literal syntax for clearer advice. The case of multiple fields is also considered here, provided that the field has the same number of arguments as CallExpr.
r? compiler
@xizheyin
xizheyin deleted the issue-138931 branch March 28, 2025 00:20
@xizheyinxizheyin mentioned this pull request May 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.87.0

Development

Successfully merging this pull request may close these issues.

Offer a suggested fix for structs with a single field

4 participants

@xizheyin@oli-obk@bors@rustbot