Skip to content

Remove aux_build run-make rustc helpers - #139239

Merged
bors merged 2 commits into
rust-lang:masterfrom
jieyouxu:run-make-aux-build
Apr 2, 2025
Merged

Remove aux_build run-make rustc helpers#139239
bors merged 2 commits into
rust-lang:masterfrom
jieyouxu:run-make-aux-build

Conversation

@jieyouxu

@jieyouxujieyouxu commented Apr 2, 2025

Copy link
Copy Markdown
Member

They provide very little value and makes it more confusing than is
helpful.

Helps with #138066.

r? @Kobzol

@jieyouxu
Drop aux_build rustc helpers
b591eb0
They provide very little value and makes it more confusing than is
helpful.
@jieyouxu
Update run-make tests to no longer use aux_build
f31bd74
@rustbotrustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@Kobzol

Kobzol commented Apr 2, 2025

Copy link
Copy Markdown
Member

Yeah I was wondering why do we even need that anymore. Thanks! You can r=me once CI is green.

@jieyouxujieyouxu mentioned this pull request Apr 2, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
a0afa67
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: i686-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
@jieyouxu

jieyouxu commented Apr 2, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=@Kobzol rollup

@bors

bors commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f31bd74 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
@TaKO8KiTaKO8Ki mentioned this pull request Apr 2, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@bors
Auto merge ofrust-lang#139257- TaKO8Ki:rollup-vjzdas7, r=TaKO8Ki
4f0de4c
Rollup of 5 pull requests
Successful merges:
- rust-lang#139178 (Remove cjgillot from automated review assignment)
- rust-lang#139184 (Add unstable `--print=crate-root-lint-levels`)
- rust-lang#139215 (Add `opt-level = "s"` for more std symbolication crates)
- rust-lang#139232 (Move methods from `Map` to `TyCtxt`, part 5.)
- rust-lang#139239 (Remove `aux_build` run-make rustc helpers)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit abcfc3e into rust-lang:masterApr 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
@rust-timer
Unrolled build forrust-lang#139239
6074778
Rollup merge of rust-lang#139239 - jieyouxu:run-make-aux-build, r=Kobzol
Remove `aux_build` run-make rustc helpers
They provide very little value and makes it more confusing than is
helpful.
Helps with rust-lang#138066.
r? `@Kobzol`
@rustbotrustbot added this to the 1.88.0 milestone Apr 2, 2025
@jieyouxu
jieyouxu deleted the run-make-aux-build branch April 2, 2025 23:30
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
a58362d
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: i686-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
8efb167
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
f999cf7
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
5a77c4a
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
@bors
Auto merge ofrust-lang#139244- jieyouxu:exp/auto-cross-run-make, r=…
a24bb16
…<try>
[WIP] [WIP] Enable automatic cross-compilation in run-make tests
WIP for the WIP rust-lang#138066.
Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
rust-borsBot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
fb25ca8
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
6f53d16
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
9394804
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
e68f86e
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 16, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
6ba5524
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
6de3fd8
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
0f81339
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Stacked on top of #142414, needs rebase.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
rust-borsBot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of#139244- jieyouxu:exp/auto-cross-run-make, r=<try>
ac749ee
[WIP] Enable automatic cross-compilation in run-make tests
> [!CAUTION]
>
> Conflicts with #142563.
Supersedes #138066.
Blocker for #141856.
Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes.
r? `@ghost`
try-job: armhf-gnu
try-job: test-various
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KobzolKobzol

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu@Kobzol@bors@rustbot