Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)

[matthiaskrgr]

Successful merges:

• rm RegionInferenceContext::var_infos #139476 (rm RegionInferenceContext::var_infos)
• compiletest: Stricter parsing for diagnostic kinds #139485 (compiletest: Stricter parsing for diagnostic kinds)
• Update books #139491 (Update books)
• document panic behavior of Vec::resize and Vec::resize_with #139500 (document panic behavior of Vec::resize and Vec::resize_with)
• Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types #139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types)
• add missing word in doc comment #139504 (add missing word in doc comment)
• clean: remove Deref<Target=RegionKind> impl for Region and use .kind() #139509 (clean: remove Deref<Target=RegionKind> impl for Region and use .kind())

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[rustbot]

⚠️Warning⚠️

• These commits modify submodules.

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 1cbf8b5 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1cbf8b5 with merge b258537...

[rust-log-analyzer]

The job x86_64-mingw-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- [assembly] tests\assembly\targets\targets-macho.rs#aarch64_apple_tvos stdout ----
error in revision `aarch64_apple_tvos`: auxiliary build of "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" failed to compile: status: exit code: 1
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\bin;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw64\bin;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.3.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.442-6\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.9.9\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "D:\\a\\rust\\rust\\tests\\auxiliary\\minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=D:\\a\\rust\\rust\\vendor" "--sysroot" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2" "--cfg" "aarch64_apple_tvos" "--check-cfg" "cfg(test,FALSE,aarch64_apple_darwin,aarch64_apple_ios,aarch64_apple_ios_macabi,aarch64_apple_ios_sim,aarch64_apple_tvos,aarch64_apple_tvos_sim,arm64e_apple_tvos,aarch64_apple_watchos,aarch64_apple_watchos_sim,arm64_32_apple_watchos,aarch64_apple_visionos,aarch64_apple_visionos_sim,arm64e_apple_darwin,arm64e_apple_ios,armv7k_apple_watchos,armv7s_apple_ios,i386_apple_ios,i686_apple_darwin,x86_64_apple_darwin,x86_64_apple_ios,x86_64_apple_ios_macabi,x86_64_apple_tvos,x86_64_apple_watchos_sim,x86_64h_apple_darwin)" "-O" "-Cdebug-assertions=no" "-C" "prefer-dynamic" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\assembly\\targets\\targets-macho.aarch64_apple_tvos\\libminicore.rlib" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "--target" "aarch64-apple-tvos" "-Cpanic=abort" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\rustcECAiCb"
error: aborting due to 1 previous error
------------------------------------------
---
test result: FAILED. 494 passed; 1 failed; 43 ignored; 0 measured; 0 filtered out; finished in 24.06s
Some tests failed in compiletest suite=assembly mode=assembly host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
Build completed unsuccessfully in 1:37:23
make: *** [Makefile:124: ci-mingw-x] Error 1
local time: Tue Apr 8 20:59:26 CUT 2025
network time: Tue, 08 Apr 2025 20:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 1cbf8b5 with merge de5b8a4...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing de5b8a4 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d4f880f (parent) -> de5b8a4 (this PR)

Test differences

Show 142 test diffs

Stage 1

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J0)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#current: [missing] -> pass (J1)
• [ui] tests/ui/impl-trait/recursive-in-exhaustiveness.rs#next: [missing] -> pass (J1)

Additionally, 138 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3
• J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Job duration changes

1. x86_64-apple-2: 3880.2s -> 5557.9s (43.2%)
2. dist-x86_64-apple: 9468.0s -> 11839.2s (25.0%)
3. dist-s390x-linux: 5371.1s -> 6276.4s (16.9%)
4. x86_64-gnu-aux: 6052.4s -> 6504.5s (7.5%)
5. x86_64-apple-1: 8293.0s -> 8732.9s (5.3%)
6. dist-android: 2540.5s -> 2655.5s (4.5%)
7. x86_64-msvc-1: 8600.3s -> 8936.3s (3.9%)
8. x86_64-msvc-ext2: 5820.3s -> 6045.0s (3.9%)
9. dist-aarch64-msvc: 8391.7s -> 8707.6s (3.8%)
10. dist-i586-gnu-i586-i686-musl: 5173.5s -> 5365.7s (3.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139476	rm RegionInferenceContext::var_infos	f0f43929a0bc91cae7e4a6ab0ed02b85d3fc1e57 (link)
#139485	compiletest: Stricter parsing for diagnostic kinds	ee0632043069bbf6dd791501a579f8a728698f7f (link)
#139491	Update books	c3f3e68afe4fa031eb2b434ae8a79075b678f5d6 (link)
#139500	document panic behavior of Vec::resize and Vec::resize_with	9cb3732f8faef45beba8778d7e8370805edb0a47 (link)
#139501	Fix stack overflow in exhaustiveness due to recursive HIR o…	38e7ee23825e8e60e2fdaee3b16b253f6baa1c57 (link)
#139504	add missing word in doc comment	5dc90f81e8bdfa5e2a4d546b0aa60239503f5677 (link)
#139509	clean: remove Deref<Target=RegionKind> impl for Region and …	9ecbcfed6bb8d31a9c6c800bd5523f045da65a3e (link)

previous master: d4f880f8ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (de5b8a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 7.2%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.7%	[-1.6%, 7.2%]	7

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-6.3%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.796s -> 778.068s (-0.35%)
Artifact size: 366.15 MiB -> 366.11 MiB (-0.01%)