Uh oh!
There was an error while loading. Please reload this page.
Correctly display stdout and stderr in case a doctest is failing - #140291
Merged
Conversation
Kobzol
reviewed
Apr 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomezforce-pushed
the
doctest-2024-stdout
branch
from
April 25, 2025 13:56
7022a2f to
c44068bCompareGuillaumeGomez
commented
Apr 25, 2025
MemberAuthor
Ok I think this time I didn't forget some normalization. :') |
GuillaumeGomezforce-pushed
the
doctest-2024-stdout
branch
2 times, most recently
from
April 25, 2025 20:06
3ef98a5 to
c44068bComparenotriddle
commented
Apr 26, 2025
Contributor
@bors r+ |
bors
commented
Apr 26, 2025
Collaborator
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 26, 2025
…, r=notriddle Correctly display stdout and stderr in case a doctest is failing Fixesrust-lang#140289. Since the doctest is actually running itself, we need to handle the output directly inside it. cc `@fmease` r? `@notriddle`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2025
Rollup of 4 pull requests Successful merges: - rust-lang#139308 (add autodiff inline) - rust-lang#140291 (Correctly display stdout and stderr in case a doctest is failing) - rust-lang#140297 (Update example to use CStr::to_string_lossy) - rust-lang#140339 (session: Cleanup `CanonicalizedPath::new`) r? `@ghost` `@rustbot` modify labels: rollup
tgross35 added a commit
to tgross35/rust
that referenced
this pull request
Apr 27, 2025
…, r=notriddle Correctly display stdout and stderr in case a doctest is failing Fixesrust-lang#140289. Since the doctest is actually running itself, we need to handle the output directly inside it. cc ``@fmease`` r? ``@notriddle``
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#137439 (Stabilise `std::ffi::c_str`) - rust-lang#138737 (uefi: Update r-efi) - rust-lang#139646 (check types of const param defaults) - rust-lang#140220 (Fix detection of main function if there are expressions around it) - rust-lang#140291 (Correctly display stdout and stderr in case a doctest is failing) - rust-lang#140297 (Update example to use CStr::to_string_lossy) - rust-lang#140330 (Clarified bootstrap optimization "true" argument) r? `@ghost` `@rustbot` modify labels: rollup
bors
commented
Apr 27, 2025
Collaborator
bors
commented
Apr 27, 2025
Collaborator
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 496145b (parent) -> 8947e16 (this PR) Test differencesShow 33070 test diffsStage 1
Stage 2
(and 16452 additional test diffs) Additionally, 16518 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8947e167e58c5c4f23cae94585301f8eb90d93ea --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Apr 27, 2025
Collaborator
Finished benchmarking commit (8947e16): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.8%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.349s -> 763.457s (-0.12%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#140289.
Since the doctest is actually running itself, we need to handle the output directly inside it.
cc @fmease
r? @notriddle