Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #140503
Merged
Merged
Conversation
Most notably, the `FIXME` for suboptimal printing of `use` groups in `tests/ui/macros/stringify.rs` is fixed. And all other test output changes result in pretty printed output being closer to the original formatting in the source code.
…homcc
Remove backticks from `ShouldPanic::YesWithMessage`'s `TrFailedMsg`
More legible imo
```rs
#[test]
#[should_panic = "love"]
fn foo() {
assert!(1 == 2);
}
```
Before:
```
note: panic did not contain expected string
panic message: `"assertion failed: 1 == 2"`,
expected substring: `"love"`
```
After:
```
note: panic did not contain expected string
panic message: "assertion failed: 1 == 2"
expected substring: "love"
```
Also removed the comma as `assert_eq!` / `assert_ne!` don't use one.
``@rustbot`` label +A-libtest…agisa uses_power_alignment: wording tweaks Slightly improves the wording introduced with rust-lang#135552.
…provenance-139008, r=RalfJung mention provenance in the pointer::wrapping_offset docs fixesrust-lang#139008
…etrochenkov Improve pretty-printing of braces r? ````@petrochenkov````
…=compiler-errors rm `TypeVistable` impls for `Canonical` similar to `EarlyBinder`, you generally do not want to fold a canonical value directly without first instantiating it. In places where you do want to look into the `Canonical`, it's likely better to do so manually. r? ```@compiler-errors```
…s-msa, r=jieyouxu enable msa feature for mips in codegen tests Fix codegen unit tests for mips by enabling the msa target feature.
…s, r=Kobzol Add `rust.debug-assertions-tools` option Before this PR, the two only options to configure the presence of debug assertions were the `rust.debug-assertions` and `rust.debug-assertions-std` options. The former applied to everything, and the latter allowed to override the setting just for the standard library. This combination of settings doesn't allow to enable debug assertions for the std and the compiler but not tools. Some tools (like Cargo) are not really meant to be executed with debug assertions enabled, and in Ferrocene we hit some debug assertions in it that are exclusively meant for its test suite. We'd thus like to enable debug assertions everywhere but in tools. This PR adds a `rust.debug-assertions-tools` setting that does exactly this.
…et, r=oli-obk miri: algebraic intrinsics: bring back float non-determinism Fixesrust-lang/miri#4289 Cc ```@bjoernager``` r? ```@oli-obk```
…1-dead Treat ManuallyDrop as ~const Destruct cc rust-lang#133214 (comment) r? ```@compiler-errors``` cc ```@fee1-dead```
chore: fix some tests
…errors Rename `rustc_query_append!` to `rustc_with_all_queries!` Whenever I'm trying to make sense of the query system internals, I always get tripped up on this unhelpfully-named macro. The fact that it's a higher-order proc macro is already mind-melting enough on its own. This new name, `rustc_with_all_queries!`, forms a much more intuitive combination with the helper macros that it invokes. And only one of the call sites was even making use of the “append” part of its old name. This PR also reformats the parameters matched by the helper macros, to make the actual argument syntax a bit easier to see. --- Renaming and reformatting only; no functional changes.
matthiaskrgr
commented
Apr 30, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Apr 30, 2025
Collaborator
bors
commented
Apr 30, 2025
Collaborator
bors
commented
Apr 30, 2025
Collaborator
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d2eadb7 (parent) -> 7188f45 (this PR) Test differencesShow 202 test diffsStage 1
Stage 2
Additionally, 186 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7188f453111502962326022740e2657fce0a6939 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Apr 30, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: d2eadb7a94 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 30, 2025
rust-timer
commented
Apr 30, 2025
Collaborator
Finished benchmarking commit (7188f45): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 770.233s -> 770.688s (0.06%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ShouldPanic::YesWithMessage'sTrFailedMsg#136160 (Remove backticks fromShouldPanic::YesWithMessage'sTrFailedMsg)TypeVistableimpls forCanonical#140404 (rmTypeVistableimpls forCanonical)rust.debug-assertions-toolsoption #140438 (Addrust.debug-assertions-toolsoption)rustc_query_append!torustc_with_all_queries!#140448 (Renamerustc_query_append!torustc_with_all_queries!)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup