Uh oh!
There was an error while loading. Please reload this page.
Improve hir pretty printing - #140606
Merged
Merged
Conversation
They don't appear to do anything -- no test output is affected -- and no other pretty-printing code looks like this.
As far as I can tell, this code is not actually reachable.
One of the boxes isn't closed, and this causes everything after it to be over-indented.
All the box open/close issues have been fixed.
rustbot
commented
May 3, 2025
Collaborator
Some changes occurred in tests/rustdoc-json |
dtolnay
commented
May 3, 2025
Member
@bors r+ |
bors
commented
May 3, 2025
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#139343 (Change signature of File::try_lock and File::try_lock_shared) - rust-lang#140505 (linker: Quote symbol names in .def files) - rust-lang#140534 (PassWrapper: adapt for llvm/llvm-project@f137c3d592e96330e450a8fd63ef…) - rust-lang#140546 (Remove backtrace dep from anyhow in features status dump tool) - rust-lang#140548 (Emit user type annotations for free consts in pattern position) - rust-lang#140564 (Use present indicative tense in std::io::pipe() API docs) - rust-lang#140568 (Add regression test for rust-lang#140545) - rust-lang#140606 (Improve hir pretty printing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2025
Rollup merge of rust-lang#140606 - nnethercote:hir-pp, r=dtolnay Improve hir pretty printing It's currently pretty bad, so a few small improvements can make a big difference. r? `@dtolnay`
jyn514
commented
May 5, 2025
Member
hey @nnethercote, please don't just --bless away changes to rustdoc-json - this broke cargo semver-checks |
jyn514
commented
May 5, 2025
Member
cc #137645 |
nnethercote
commented
May 5, 2025
ContributorAuthor
Sorry for the breakage. Why are there no cargo semver-checks to catch this? |
jyn514
commented
May 5, 2025
Member
it's OK. @aDotInTheVoid is going to change the ping message to make it more clear this is a public API. |
Member
It was caught by the test suites of cargo-semver-checks and its components. Their test suites are fairly extensive (a decent bit larger than the rustdoc JSON tests) and at one point there was discussion about running them in rustdoc's own CI to catch rustdoc JSON bugs (#110815). At the time that seemed like a lot of work for not much gain, but perhaps it's an idea to revisit. I opened #140689 to track recovering the original behavior, unless we decide to roll forward instead and just bump the format version number. That would be a bit inconvenient, but I can deal with it if it's preferable. |
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
May 8, 2025
…dtolnay triagebot: Better message for changes to `tests/rustdoc-json` Followup to rust-lang#140689 / rust-lang#140606 Adds a message to changes to `tests/rustdoc-json`, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored. Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here. cc `@jyn514` `@obi1kenobi` r? `@GuillaumeGomez`
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 8, 2025
…dtolnay triagebot: Better message for changes to `tests/rustdoc-json` Followup to rust-lang#140689 / rust-lang#140606 Adds a message to changes to `tests/rustdoc-json`, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored. Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here. cc ``@jyn514`` ``@obi1kenobi`` r? ``@GuillaumeGomez``
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2025
Rollup merge of rust-lang#140773 - aDotInTheVoid:rdj-triagdfsadgs, r=dtolnay triagebot: Better message for changes to `tests/rustdoc-json` Followup to rust-lang#140689 / rust-lang#140606 Adds a message to changes to `tests/rustdoc-json`, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored. Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here. cc ``@jyn514`` ``@obi1kenobi`` r? ``@GuillaumeGomez``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently pretty bad, so a few small improvements can make a big difference.
r? @dtolnay