Uh oh!
There was an error while loading. Please reload this page.
Structurally normalize in range pattern checking in HIR typeck - #140707
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
May 6, 2025
| // be peeled to `str` while ty here is still `&str`, if we don't | ||
| // err early here, a rather confusing unification error will be | ||
| // emitted instead). | ||
| let ty = self.structurally_resolve_type(expr.span, ty); |
Contributor
There was a problem hiding this comment.
do we need to do the same in fn calc_adjust_mode given that this also structurally matches on check_pat_expr_unadjusted?
compiler-errorsforce-pushed
the
range-pat-struct-norm
branch
from
May 8, 2025 15:00
d7eddef to
9af6ee5Comparelcnr
commented
May 8, 2025
Contributor
@bors r+ rollup |
bors
commented
May 8, 2025
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 8, 2025
…orm, r=lcnr Structurally normalize in range pattern checking in HIR typeck Fixesrust-lang/trait-system-refactor-initiative#200 r? lcnr
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#140095 (Eliminate `word_and_empty` methods.) - rust-lang#140341 (Clarify black_box warning a bit) - rust-lang#140684 (Only include `dyn Trait<Assoc = ...>` associated type bounds for `Self: Sized` associated types if they are provided) - rust-lang#140707 (Structurally normalize in range pattern checking in HIR typeck) - rust-lang#140716 (Improve `-Zremap-path-scope` tests with dependency) - rust-lang#140800 (Make `rustdoc-tempdir-removal` run-make tests work on other platforms than linux) - rust-lang#140802 (Add release notes for 1.87.0) - rust-lang#140811 (Enable triagebot note functionality for rust-lang/rust) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2025
Rollup merge of rust-lang#140707 - compiler-errors:range-pat-struct-norm, r=lcnr Structurally normalize in range pattern checking in HIR typeck Fixesrust-lang/trait-system-refactor-initiative#200 r? lcnr
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixesrust-lang/trait-system-refactor-initiative#200
r? lcnr