Skip to content

Reduce special casing for the panic runtime - #140809

Merged
bors merged 8 commits into
rust-lang:masterfrom
bjorn3:panic_runtime_cleanup
Jun 28, 2025
Merged

Reduce special casing for the panic runtime#140809
bors merged 8 commits into
rust-lang:masterfrom
bjorn3:panic_runtime_cleanup

Conversation

@bjorn3

@bjorn3bjorn3 commented May 8, 2025

Copy link
Copy Markdown
Member

See the individual commits for more info.

@rustbot

rustbot commented May 8, 2025

Copy link
Copy Markdown
Collaborator

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 8, 2025
@rustbot

rustbot commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@bjorn3

bjorn3 commented May 8, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I was looking at making panic_abort and panic_unwind depend on libstd (#139103 (comment)). These changes make this easier, though is still blocked on the fact that when compiling libstd as dylib, panic_unwind already needs to be present.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from 6d4613c to c7e8663CompareMay 8, 2025 16:10
@rustbot

rustbot commented May 8, 2025

Copy link
Copy Markdown
Collaborator

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from c7e8663 to 93cf365CompareMay 8, 2025 17:55
@bors

This comment was marked as resolved.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from 93cf365 to a9d5498CompareMay 9, 2025 09:41
@bors

This comment was marked as resolved.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from d730005 to 7d0f158CompareMay 18, 2025 14:16
@bors

This comment was marked as resolved.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from 7d0f158 to 0dfacc7CompareMay 19, 2025 09:54
@bors

This comment was marked as resolved.

Sign in to view
@bjorn3
bjorn3force-pushed the panic_runtime_cleanup branch from 0dfacc7 to 6df5456CompareJune 3, 2025 09:01
@wesleywiser

wesleywiser commented Jun 5, 2025

Copy link
Copy Markdown
Member

r? wesleywiser

@wesleywiser

wesleywiser commented Jun 6, 2025

Copy link
Copy Markdown
Member

Compiler changes look good to me but I'd like someone from libs to review the change in exposed standard library features to make sure there's no concerns there.

r? libs

@ibraheemdev

ibraheemdev commented Jun 15, 2025

Copy link
Copy Markdown
Member

Looks fine to me. @bors r=wesleywiser,ibraheemdev

@bors

bors commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6df5456 has been approved by wesleywiser,ibraheemdev

It is now in the queue for this repository.

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2025
@ibraheemdev

ibraheemdev commented Jun 25, 2025

Copy link
Copy Markdown
Member

r? compiler

@rustbotrustbot assigned fee1-dead and unassigned wesleywiserJun 25, 2025
@fee1-dead

fee1-dead commented Jun 26, 2025

Copy link
Copy Markdown
Member

r? compiler

petrochenkov
petrochenkov reviewed Jun 26, 2025
View reviewed changes
Comment threadcompiler/rustc_codegen_ssa/src/back/linker.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025
@bjorn3

bjorn3 commented Jun 27, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025
@petrochenkov

petrochenkov commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Thanks!
@bors r+

@bors

bors commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 4b77115 has been approved by petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2025
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
@compiler-errors
Rollup merge ofrust-lang#140809- bjorn3:panic_runtime_cleanup, r=pe…
4125bee
…trochenkov
Reduce special casing for the panic runtime
See the individual commits for more info.
@compiler-errorscompiler-errors mentioned this pull request Jun 27, 2025
Closed
bors added a commit that referenced this pull request Jun 27, 2025
@bors
Auto merge of#143105- compiler-errors:rollup-68jh88u, r=compiler-er…
b69da27
…rors
Rollup of 8 pull requests
Successful merges:
- #139858 (New const traits syntax)
- #140809 (Reduce special casing for the panic runtime)
- #142963 (Skip unnecessary components in x64 try builds)
- #142974 (Update stage0 to 1.89.0-beta.1)
- #142987 (rustdoc: show attributes on enum variants)
- #143002 (tests: Require `run-fail` ui tests to have an exit code (`SIGABRT` not ok))
- #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
- #143096 (tag_for_variant: properly pass TypingEnv)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 27, 2025
Merged
bors added a commit that referenced this pull request Jun 27, 2025
@bors
Auto merge of#143116- matthiaskrgr:rollup-zy9ez06, r=matthiaskrgr
d41e12f
Rollup of 9 pull requests
Successful merges:
- #139858 (New const traits syntax)
- #140809 (Reduce special casing for the panic runtime)
- #142730 (suggest declaring modules when file found but module not defined)
- #142806 (Normalize before computing ConstArgHasType goal in new solver)
- #143046 (const validation: properly ignore zero-sized UnsafeCell)
- #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
- #143096 (tag_for_variant: properly pass TypingEnv)
- #143104 (hir_analysis: prohibit `dyn PointeeSized`)
- #143106 (gce: don't ICE on non-local const)
Failed merges:
- #143036 (Remove support for `dyn*` from the compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9d15167 into rust-lang:masterJun 28, 2025
@rustbotrustbot added this to the 1.90.0 milestone Jun 28, 2025
rust-timer added a commit that referenced this pull request Jun 28, 2025
@rust-timer
Unrolled build for#140809
e7c4378
Rollup merge of #140809 - bjorn3:panic_runtime_cleanup, r=petrochenkov
Reduce special casing for the panic runtime
See the individual commits for more info.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143116 - matthiaskrgr:rollup-zy9ez06, r=matthiaskrgr
9a007c9
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#139858 (New const traits syntax)
- rust-lang/rust#140809 (Reduce special casing for the panic runtime)
- rust-lang/rust#142730 (suggest declaring modules when file found but module not defined)
- rust-lang/rust#142806 (Normalize before computing ConstArgHasType goal in new solver)
- rust-lang/rust#143046 (const validation: properly ignore zero-sized UnsafeCell)
- rust-lang/rust#143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
- rust-lang/rust#143096 (tag_for_variant: properly pass TypingEnv)
- rust-lang/rust#143104 (hir_analysis: prohibit `dyn PointeeSized`)
- rust-lang/rust#143106 (gce: don't ICE on non-local const)
Failed merges:
- rust-lang/rust#143036 (Remove support for `dyn*` from the compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
@bjorn3
bjorn3 deleted the panic_runtime_cleanup branch June 28, 2025 09:52
@purplesyringapurplesyringa mentioned this pull request Jun 30, 2025
Closed
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 4, 2025
@matthiaskrgr
Rollup merge ofrust-lang#140809- bjorn3:panic_runtime_cleanup, r=pe…
6967ac3
…trochenkov
Reduce special casing for the panic runtime
See the individual commits for more info.
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jul 10, 2025
@bors
Auto merge of #143116 - matthiaskrgr:rollup-zy9ez06, r=matthiaskrgr
06a87e9
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#139858 (New const traits syntax)
- rust-lang/rust#140809 (Reduce special casing for the panic runtime)
- rust-lang/rust#142730 (suggest declaring modules when file found but module not defined)
- rust-lang/rust#142806 (Normalize before computing ConstArgHasType goal in new solver)
- rust-lang/rust#143046 (const validation: properly ignore zero-sized UnsafeCell)
- rust-lang/rust#143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
- rust-lang/rust#143096 (tag_for_variant: properly pass TypingEnv)
- rust-lang/rust#143104 (hir_analysis: prohibit `dyn PointeeSized`)
- rust-lang/rust#143106 (gce: don't ICE on non-local const)
Failed merges:
- rust-lang/rust#143036 (Remove support for `dyn*` from the compiler)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@petrochenkovpetrochenkov

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

10 participants

@bjorn3@rustbot@rust-log-analyzer@bors@wesleywiser@ibraheemdev@workingjubilee@fee1-dead@petrochenkov@compiler-errors