Uh oh!
There was an error while loading. Please reload this page.
Add negative test coverage for -Clink-self-contained and -Zlinker-features - #140997
Merged
Conversation
lqd
reviewed
May 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
lqd
commented
May 15, 2025
Member
Sweet, thank you! Since these tests are about unstable features, I'd have to modify them to integrate into the stabilization PR anyways, so let's just land them now. r=me with the first commit removed |
jieyouxuforce-pushed
the
link-flags-negative-tests
branch
from
May 15, 2025 08:47
11819c8 to
a716f1aComparejieyouxu
commented
May 15, 2025
MemberAuthor
bors
commented
May 15, 2025
Collaborator
bors
commented
May 15, 2025
Collaborator
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#140791 (std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function) - rust-lang#140834 (move (or remove) some impl Trait tests) - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at) - rust-lang#140984 (fix doc for UnixStream) - rust-lang#140997 (Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features`) - rust-lang#141003 (Improve ternary operator recovery) - rust-lang#141009 (Migrate to modern datetime API) - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows) - rust-lang#141026 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
hkBst added a commit
to hkBst/rust
that referenced
this pull request
May 16, 2025
…, r=lqd Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features` Noticed while reviewing stabilization rust-lang#140525 that we don't have any negative test coverage for these flags. Feel free to cherry-pick these tests into the stabilization PR, or we can land these before separately. r? ``@lqd``
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2025
Rollup merge of rust-lang#140997 - jieyouxu:link-flags-negative-tests, r=lqd Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features` Noticed while reviewing stabilization rust-lang#140525 that we don't have any negative test coverage for these flags. Feel free to cherry-pick these tests into the stabilization PR, or we can land these before separately. r? `@lqd`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing stabilization #140525 that we don't have any negative test coverage for these flags. Feel free to cherry-pick these tests into the stabilization PR, or we can land these before separately.
r? @lqd