Skip to content

Add compiler-builtins to bootstrap - #142106

Closed
tgross35 wants to merge 2 commits into
rust-lang:mainfrom
tgross35:test-builtins
Closed

Add compiler-builtins to bootstrap#142106
tgross35 wants to merge 2 commits into
rust-lang:mainfrom
tgross35:test-builtins

Conversation

@tgross35

Copy link
Copy Markdown
Member

No description provided.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 6, 2025
@tgross35
tgross35 marked this pull request as draft June 6, 2025 05:09
@tgross35
tgross35 marked this pull request as ready for review June 6, 2025 05:10
@tgross35

tgross35 commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

Bootstrap people, I think I need some help here making this actually work :) ideally these tests should probably run via path (./x t compiler-builtins, ./x t library/compiler-builtins) as well as under ./x library, but I can't quite figure that out.

It would be good for this to run on CI, as well.

@rust-log-analyzer

This comment has been minimized.

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I noticed that compiler-builtins has its own workspace, but at the same time, it doesn't have a Cargo.lock file. I wonder how do we want to deal with that, the dependencies probably should be locked. Either we should add a lockfile to it, or we should somehow make it a part of the root workspace? 🤔

Comment threadsrc/bootstrap/src/core/build_steps/test.rs Outdated
Comment threadsrc/bootstrap/src/core/build_steps/test.rs
Comment threadsrc/bootstrap/src/core/build_steps/test.rs Outdated
Comment threadsrc/bootstrap/src/core/build_steps/test.rs Outdated
Comment threadsrc/bootstrap/src/core/build_steps/test.rs Outdated
Comment threadsrc/bootstrap/src/core/build_steps/test.rs
Comment threadsrc/bootstrap/src/core/build_steps/test.rs Outdated
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #145663) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPCDylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025
@JohnCSimon

Copy link
Copy Markdown

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@rustbotrustbot added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tgross35@rustbot@rust-log-analyzer@bors@JohnCSimon@Kobzol@Dylan-DPC