Skip to content

Rollup of 11 pull requests - #142133

Merged
bors merged 29 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged

Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup-fvzdren

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jun 6, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tgross35and others added 29 commits April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2025
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 6, 2025
@GuillaumeGomez

GuillaumeGomez commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5 rollup=never

@bors

bors commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 22d53ad has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025
@bors

bors commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 22d53ad with merge 775e0c8...

@bors

bors commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 775e0c8 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025
@bors
bors merged commit 775e0c8 into rust-lang:masterJun 7, 2025
@rustbotrustbot added this to the 1.89.0 milestone Jun 7, 2025
@github-actions

github-actionsBot commented Jun 7, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)

Test differences

Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)

previous master: 868bf2da31

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
Merged
Merged
Merged
@rust-timer

rust-timer commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (775e0c8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅
(secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4

Max RSS (memory usage)

Results (primary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)

@GuillaumeGomez
GuillaumeGomez deleted the rollup-fvzdren branch June 7, 2025 10:02
@panstromekpanstromek mentioned this pull request Jun 9, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Rollup of 11 pull requests by GuillaumeGomez · Pull Request #142133 · rust-lang/rust · GitHub
Skip to content
Rollup of 11 pull requests - #142133
Merged
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Jun 7, 2025
Merged
Rollup of 11 pull requests#142133
bors merged 29 commits into
rust-lang:masterfrom 
GuillaumeGomez:rollup-fvzdren
Conversation
@GuillaumeGomez
@GuillaumeGomezGuillaumeGomez
commented
Jun 6, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
tgross35and others
added 29 commits
April 28, 2025 19:57
@tgross35
Reexport types from c_size_t in std
8db68da
These are unstably available in `core` and should be in `std` too, but
are not currently reexported. Resolve this here.
@nnethercote
Remove 'static bounds on P.
a35675d
These date back to 2014. I don't think they're needed any more.
@nnethercote
Remove P::map.
6973fa0
It's barely used, and the places that use it are better if they don't.
@nnethercote
Remove the one use of P<[T]>.
0f285e3
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't
matter here.
@nnethercote
Remove support for P<[T]>.
6859750
It's no longer used.
@nnethercote
Remove unused P stuff.
c42d1fc
@nnethercote
Reduce P<T> to a typedef of Box<T>.
991c91f
Keep the `P` constructor function for now, to minimize immediate churn.
All the `into_inner` calls are removed, which is nice.
@estebank
Verbose suggestion to make param const
35cb28b
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
@fee1-dead
use helper macro for flat_map vs visit_list, initial dedups
91b77e0
@scottmcm
Update InterpCx::project_field to take FieldIdx
8bce225
As suggested by Ralf in 142005.
@tshepang
remove extraneous text
0ffff46
"Basic usage" implies there is an example that shows advanced usage
@fee1-dead
deduplicate more walk_* methods in AST visit
8a7262c
@scottmcm@RalfJung
Update compiler/rustc_abi/src/layout/ty.rs
f9cf096
Co-authored-by: Ralf Jung <post@ralfj.de>
@ada4a
fix typo
b285908
@GuillaumeGomez
Compute number of digits instead of relying on constant value for u12…
28a2e1e
…8 display code
@shepmaster
Reduce confusion of some drop order tests
8fc1bed
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
@hkBst
rustc_lexer: typo fix + small cleanups
2a5225a
@RalfJung
unsafe keyword docs: emphasize that an unsafe fn in a trait does not …
910a59d
…get to choose its safety contract
@GuillaumeGomez
Rollup merge ofrust-lang#140418- tgross35:std-c-size_t, r=workingju…
3fee6cc
…bilee
Reexport types from `c_size_t` in `std`
These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.
Tracking issue: rust-lang#88345
@GuillaumeGomez
Rollup merge ofrust-lang#141471- RalfJung:unsafe-fn-in-trait, r=tra…
15d9b96
…viscross
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract
Inspired by discussion in rust-lang#139368.
Cc `@hanna-kruppe`
@GuillaumeGomez
Rollup merge ofrust-lang#141603- nnethercote:reduce-P, r=fee1-dead
93ca0af
Reduce `ast::ptr::P` to a typedef of `Box`
As per the MCP at rust-lang/compiler-team#878.
r? `@fee1-dead`
@GuillaumeGomez
Rollup merge ofrust-lang#142043- estebank:const-suggestion, r=wesle…
4ce2db5
…ywiser
Verbose suggestion to make param `const`
```
error[E0747]: type provided when a constant was expected
--> $DIR/invalid-const-arguments.rs:10:19
|
LL | impl<N> Foo for B<N> {}
| ^
|
help: consider changing this type parameter to a const parameter
|
LL - impl<N> Foo for B<N> {}
LL + impl<const N: u8> Foo for B<N> {}
|
```
Part of rust-lang#141973.
@GuillaumeGomez
Rollup merge ofrust-lang#142086- fee1-dead-contrib:ast-visitor-dedu…
2946ce2
…p, r=oli-obk
duduplicate more AST visitor methods
r? oli-obk
@GuillaumeGomez
Rollup merge ofrust-lang#142103- scottmcm:fieldidx-in-interp, r=oli…
3a6f1b0
…-obk
Update `InterpCx::project_field` to take `FieldIdx`
As suggested by Ralf in rust-lang#142005 (comment)
@GuillaumeGomez
Rollup merge ofrust-lang#142105- tshepang:basic-usage, r=workingjub…
b4b2d0e
…ilee
remove extraneous text
@GuillaumeGomez
Rollup merge ofrust-lang#142112- ada4a:patch-1, r=wesleywiser
c1e67ad
fix typo
@GuillaumeGomez
Rollup merge ofrust-lang#142113- shepmaster:drop-order-test-confusi…
b6ace05
…on, r=jieyouxu
Reduce confusion of some drop order tests
In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.
Closesrust-lang#141604
r? `@jieyouxu`
@GuillaumeGomez
Rollup merge ofrust-lang#142114- GuillaumeGomez:u128-const, r=Urgau
6bbef98
Compute number of digits instead of relying on constant value for u128 display code
As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value.
r? `@tamird`
@GuillaumeGomez
Rollup merge ofrust-lang#142118- hkBst:lexer-patch1, r=oli-obk
22d53ad
rustc_lexer: typo fix + small cleanups
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 6, 2025
@rustbotrustbot
added

T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jun 6, 2025
@GuillaumeGomez
GuillaumeGomez
commented
Jun 6, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ p=5 rollup=never
@bors
bors
commented
Jun 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 22d53ad has been approved by GuillaumeGomez
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 6, 2025
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 22d53ad with merge 775e0c8...
@bors
bors
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: GuillaumeGomez

Pushing 775e0c8 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Jun 7, 2025
@bors
bors
merged commit 775e0c8
into
rust-lang:masterJun 7, 2025
@rustbotrustbot
added this to the 1.89.0 milestone
Jun 7, 2025
@github-actions
github-actionsBot
commented
Jun 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)
Test differences
Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
  2. x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
  3. mingw-check-1: 1614.7s -> 1922.6s (19.1%)
  4. x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
  5. dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
  6. x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
  7. x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
  8. i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
  9. x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
  10. i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#140418Reexport types from c_size_t in std8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17 (link)
#141471unsafe keyword docs: emphasize that an unsafe fn in a trait…636a6c289ec21f92c080aeac42d2130a48df374e (link)
#141603Reduce ast::ptr::P to a typedef of Box4c6f6479549402e21b57f02d8548ac588878f969 (link)
#142043Verbose suggestion to make param const771b39b47657188be5100681e664ad6be220f8d8 (link)
#142086duduplicate more AST visitor methods4846a434969011bac1675d5cc7069ed411d70267 (link)
#142103Update InterpCx::project_field to take FieldIdx7e2ca660f9d06e3750229a03bdf74c8361aba661 (link)
#142105remove extraneous text0c4095ee85ee57352efec94486314a0b4af70d1f (link)
#142112fix typoded656c69df38b2786c7c6b225e394edafd2fc40 (link)
#142113Reduce confusion of some drop order testsee65e8741364322cefde961fecd45bb37a4d1c5e (link)
#142114Compute number of digits instead of relying on constant val…58b768fa7d96a97796ffa7f28b03d8ab20defe8c (link)
#142118rustc_lexer: typo fix + small cleanups23f1d0b78dc397b6566e479e13c94674acaaa284 (link)
previous master: 868bf2da31
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Jun 7, 2025
 Merged

 Merged

 Merged

@rust-timer
rust-timer
commented
Jun 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (775e0c8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.2%]4
Improvements ✅ 
 (secondary)		-0.3%[-0.4%, -0.2%]8
All ❌✅ (primary)-0.2%[-0.2%, -0.2%]4
Max RSS (memory usage)
Results (primary -2.6%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.6%[-4.2%, -1.0%]2
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.6%[-4.2%, -1.0%]2
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)
@GuillaumeGomez
GuillaumeGomez
deleted the

rollup-fvzdren

branch
June 7, 2025 10:02
@panstromekpanstromek
mentioned this pull request
Jun 9, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

14 participants

@GuillaumeGomez@bors@rust-timer@rustbot@tgross35@nnethercote@estebank@fee1-dead@scottmcm@tshepang@ada4a@shepmaster@hkBst@RalfJung