Add `Vec::into_chunks` - #142138

Merged

bors merged 4 commits into

rust-lang:masterfrom

ashivaram23:vec_into_chunks

Jul 2, 2025

ashivaram23 commented Jun 7, 2025•
edited by rustbot
Loading

Contributor

Tracking issue #142137

Add into_chunks

230b55d

rustbot assigned thomcc

rustbot commented Jun 7, 2025

Collaborator

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-libs labels

ashivaram23 mentioned this pull request

Tracking Issue for vec_into_chunks#142137

Open

3 tasks

This comment has been minimized.

Sign in to view

put feature attribute in example

e4e7773

This comment has been minimized.

Sign in to view

cfg for no no_global_oom_handling

343db27

lukaslueg reviewed

View reviewed changes

library/alloc/src/vec/mod.rs Outdated

+ #[unstable(feature = "vec_into_chunks", issue = "142137")]
+ pub fn into_chunks<const N: usize>(mut self) -> Vec<[T; N], A> {
+ const {
+ assert!(N != 0, "chunk size should be greater than zero");

lukasluegJun 7, 2025

Contributor

language nit: "must be" instead of "should be", as this is not an advisory suggestion.

fix wording in assert

c1d32d8

scottmcm reviewed

View reviewed changes

library/alloc/src/vec/mod.rs

Comment on lines +3036 to +3044

+ let len_remainder = len % N;
+ if len_remainder != 0 {
+ self.truncate(len - len_remainder);
+ }
+ let cap_remainder = cap % N;
+ if !T::IS_ZST && cap_remainder != 0 {
+ self.buf.shrink_to_fit(cap - cap_remainder);
+ }

scottmcmJul 1, 2025

Member

I was debating whether the != 0 checks here are useful, since the methods called will immediately do similar checks, but I think I ended up at 🤷 might as well leave it as-is.

scottmcm commented Jul 1, 2025

Member

I'm personally unsure about whether the infallible-but-possible-reallocating version is the right thing to do for this API, but it matches the ACP so that sounds like a tracking issue problem, not a this-PR problem.

Code change itself looks good to me, so
@bors r+ rollup
r? scottmcm

rustbot assigned scottmcm

bors commented Jul 1, 2025

Collaborator

📌 Commit c1d32d8 has been approved by scottmcm

It is now in the queue for this repository.

rustbot unassigned thomcc

bors added S-waiting-on-bors and removed S-waiting-on-review labels

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

31e6410

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

jhpratt mentioned this pull request

Rollup of 12 pull requests #143305

Closed

bors added a commit that referenced this pull request

Auto merge of#143305- jhpratt:rollup-t7e7uhj, r=jhpratt

5264bc9

Rollup of 12 pull requests
Successful merges:
- #141829 (Specialize sleep_until implementation for unix (except mac))
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142568 (Use the .drectve section for exporting symbols from dlls on Windows)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143038 (avoid suggesting traits from private dependencies)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143206 (Align attr fixes)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

e1c6e93

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

jhpratt mentioned this pull request

Rollup of 11 pull requests #143311

Closed

bors added a commit that referenced this pull request

Auto merge of#143311- jhpratt:rollup-vjx4zoy, r=jhpratt

77b41b0

Rollup of 11 pull requests
Successful merges:
- #141829 (Specialize sleep_until implementation for unix (except mac))
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143038 (avoid suggesting traits from private dependencies)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143206 (Align attr fixes)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

686efaa

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

jhpratt mentioned this pull request

Rollup of 12 pull requests #143313

Closed

bors added a commit that referenced this pull request

Auto merge of#143313- jhpratt:rollup-55h4nj0, r=jhpratt

4d9342a

Rollup of 12 pull requests
Successful merges:
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143038 (avoid suggesting traits from private dependencies)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143206 (Align attr fixes)
- #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
- #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

4aedc00

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

matthiaskrgr mentioned this pull request

Rollup of 11 pull requests #143317

Closed

bors added a commit that referenced this pull request

Auto merge of#143317- matthiaskrgr:rollup-isq1wbb, r=matthiaskrgr

28c341e

Rollup of 11 pull requests
Successful merges:
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143038 (avoid suggesting traits from private dependencies)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
- #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

fb8421f

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

matthiaskrgr mentioned this pull request

Rollup of 10 pull requests #143322

Closed

bors added a commit that referenced this pull request

Auto merge of#143322- matthiaskrgr:rollup-h6xw7i5, r=matthiaskrgr

58dd450

Rollup of 10 pull requests
Successful merges:
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
- #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143260 (Use the correct export kind for __rust_alloc_error_handler_should_panic)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr mentioned this pull request

Rollup of 9 pull requests #143337

Merged

bors added a commit that referenced this pull request

Auto merge of#143337- matthiaskrgr:rollup-lqwhe0i, r=matthiaskrgr

6677875

Rollup of 9 pull requests
Successful merges:
- #141847 (Explain `TOCTOU` on the top of `std::fs`, and reference it in functions)
- #142138 (Add `Vec::into_chunks`)
- #142321 (Expose elf abi on ppc64 targets)
- #142886 (ci: aarch64-gnu: Stop skipping `panic_abort_doc_tests`)
- #143194 (fix bitcast of single-element SIMD vectors)
- #143231 (Suggest use another lifetime specifier instead of underscore lifetime)
- #143232 ([COMPILETEST-UNTANGLE 3/N] Use "directives" consistently within compiletest)
- #143258 (Don't recompute `DisambiguatorState` for every RPITIT in trait definition)
- #143274 (ci: support optional jobs)
r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit 6a31e69 into rust-lang:master

rustbot added this to the 1.90.0 milestone

rust-timer added a commit that referenced this pull request

Unrolled build for#142138

45734e3

Rollup merge of #142138 - ashivaram23:vec_into_chunks, r=scottmcm
Add `Vec::into_chunks`
Tracking issue #142137

github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Rollup merge ofrust-lang#142138- ashivaram23:vec_into_chunks, r=sco…

ce9f750

…ttmcm
Add `Vec::into_chunks`
Tracking issue rust-lang#142137

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsT-libs