Skip to content

compiler: Treat ForceWarning as a Warning for diagnostic level - #142148

Merged
bors merged 1 commit into
rust-lang:masterfrom
workingjubilee:dont-ice-on-force-warn
Jun 8, 2025
Merged

compiler: Treat ForceWarning as a Warning for diagnostic level#142148
bors merged 1 commit into
rust-lang:masterfrom
workingjubilee:dont-ice-on-force-warn

Conversation

@workingjubilee

@workingjubileeworkingjubilee commented Jun 7, 2025

Copy link
Copy Markdown
Member

This silences an ICE.

No idea if this is the correct solution though tbh.

Fixes#142144

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2025
@Urgau

Urgau commented Jun 7, 2025

Copy link
Copy Markdown
Member

ForceWarning is just a specialized version of Warning, so it make sense to me to allow it.

r? Urgau r=me when CI is green

@rustbotrustbot assigned Urgau and unassigned oli-obkJun 7, 2025
@Urgau

Urgau commented Jun 7, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5bab0d2 has been approved by Urgau

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 7, 2025
…arn, r=Urgau
compiler: Treat ForceWarning as a Warning for diagnostic level
This silences an ICE.
No idea if this is the correct solution though tbh.
r? `@oli-obk`
Fixesrust-lang#142144
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 7, 2025
…arn, r=Urgau
compiler: Treat ForceWarning as a Warning for diagnostic level
This silences an ICE.
No idea if this is the correct solution though tbh.
Fixesrust-lang#142144
bors added a commit that referenced this pull request Jun 7, 2025
Rollup of 14 pull requests
Successful merges:
- #138062 (Enable Non-determinism of float operations in Miri and change std tests )
- #140560 (Allow `#![doc(test(attr(..)))]` everywhere)
- #141001 (Make NonZero<char> possible)
- #141295 (Stabilize `if let` guards (`feature(if_let_guard)`))
- #141435 (Add (back) `unsupported_calling_conventions` lint to reject more invalid calling conventions)
- #141447 (Document representation of `Option<unsafe fn()>`)
- #142008 (const-eval error: always say in which item the error occurred)
- #142053 (Add new Tier-3 targets: `loongarch32-unknown-none*`)
- #142065 (Stabilize `const_eq_ignore_ascii_case`)
- #142116 (Fix bootstrap tracing imports)
- #142126 (Treat normalizing consts like normalizing types in deeply normalize)
- #142140 (compiler: Sort and doc ExternAbi variants)
- #142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
- #142154 (get rid of spurious cfg(bootstrap))
r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 7, 2025
…arn, r=Urgau
compiler: Treat ForceWarning as a Warning for diagnostic level
This silences an ICE.
No idea if this is the correct solution though tbh.
Fixesrust-lang#142144
This was referenced Jun 7, 2025
bors added a commit that referenced this pull request Jun 7, 2025
Rollup of 9 pull requests
Successful merges:
- #140560 (Allow `#![doc(test(attr(..)))]` everywhere)
- #141447 (Document representation of `Option<unsafe fn()>`)
- #141661 (Make the `dangerous_implicit_autorefs` lint deny-by-default)
- #142065 (Stabilize `const_eq_ignore_ascii_case`)
- #142116 (Fix bootstrap tracing imports)
- #142126 (Treat normalizing consts like normalizing types in deeply normalize)
- #142140 (compiler: Sort and doc ExternAbi variants)
- #142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
- #142154 (get rid of spurious cfg(bootstrap))
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3c860e3 into rust-lang:masterJun 8, 2025
@rustbotrustbot added this to the 1.89.0 milestone Jun 8, 2025
rust-timer added a commit that referenced this pull request Jun 8, 2025
Rollup merge of #142148 - workingjubilee:dont-ice-on-force-warn, r=Urgau
compiler: Treat ForceWarning as a Warning for diagnostic level
This silences an ICE.
No idea if this is the correct solution though tbh.
Fixes#142144
@workingjubilee
workingjubilee deleted the dont-ice-on-force-warn branch June 8, 2025 05:18
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jun 9, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#140560 (Allow `#![doc(test(attr(..)))]` everywhere)
- rust-lang/rust#141447 (Document representation of `Option<unsafe fn()>`)
- rust-lang/rust#141661 (Make the `dangerous_implicit_autorefs` lint deny-by-default)
- rust-lang/rust#142065 (Stabilize `const_eq_ignore_ascii_case`)
- rust-lang/rust#142116 (Fix bootstrap tracing imports)
- rust-lang/rust#142126 (Treat normalizing consts like normalizing types in deeply normalize)
- rust-lang/rust#142140 (compiler: Sort and doc ExternAbi variants)
- rust-lang/rust#142148 (compiler: Treat ForceWarning as a Warning for diagnostic level)
- rust-lang/rust#142154 (get rid of spurious cfg(bootstrap))
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE ForceWarning != Error | Warning | Allow | Expect

5 participants

@workingjubilee@Urgau@bors@oli-obk@rustbot