Skip to content

tests: Split dont-shuffle-bswaps along opt-levels and arches - #142176

Merged
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:dont-shuffle-bswaps-per-arch
Jun 13, 2025
Merged

tests: Split dont-shuffle-bswaps along opt-levels and arches#142176
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:dont-shuffle-bswaps-per-arch

Conversation

@workingjubilee

@workingjubileeworkingjubilee commented Jun 7, 2025

Copy link
Copy Markdown
Member

This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.

Fixes#142068

r? @nikic

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2025
@rust-log-analyzer

This comment has been minimized.

@workingjubilee
workingjubileeforce-pushed the dont-shuffle-bswaps-per-arch branch from 863f870 to 786f88bCompareJune 7, 2025 19:10
// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 12
// CHECK-NEXT: store i16
// CHECK-NEXT: getelementptr inbounds{{( nuw)?}} i8, {{.+}} 14
// CHECK-NEXT: store i16

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously only had the CHECK-NOT: shufflevector. I don't think we actually want to insist that -Copt-level=2never vectorizes this code?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, well! I believe this was the version of the test that you committed, but I am happy to apply Nikita's disagreements with Nikita :^)

@workingjubilee
workingjubileeforce-pushed the dont-shuffle-bswaps-per-arch branch from 786f88b to d87c672CompareJune 8, 2025 15:32

@nikicnikic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit resolved.

@@ -0,0 +1,32 @@
//@ revisions: OPT2
//@[OPT2] compile-flags: -Copt-level=2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need a revision here anymore, as there's just one now...

@workingjubilee
workingjubileeforce-pushed the dont-shuffle-bswaps-per-arch branch from d87c672 to c7fd742CompareJune 10, 2025 00:40
@workingjubilee

Copy link
Copy Markdown
MemberAuthor

@bors r=nikic rollup

@bors

bors commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c7fd742 has been approved by nikic

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 10, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
bors added a commit that referenced this pull request Jun 10, 2025
Rollup of 13 pull requests
Successful merges:
- #134442 (Specify the behavior of `file!`)
- #134841 (Look at proc-macro attributes when encountering unknown attribute)
- #140372 (Exhaustively handle parsed attributes in CheckAttr)
- #140766 (Stabilize keylocker)
- #141061 (Change __rust_no_alloc_shim_is_unstable to be a function)
- #142042 (Make E0621 missing lifetime suggestion verbose)
- #142101 (core::ptr: deduplicate more method docs)
- #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- #142258 (platform-support.md: Mention specific Linux kernel version or later)
- #142260 (Miri subtree update)
- #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`)
- #142272 (tests: Change ABIs in tests to more future-resilient ones)
- #142275 (rustdoc: Refractor `clean_ty_generics`)
r? `@ghost`
`@rustbot` modify labels: rollup
Some architectures gain target-cpu minimums in doing so.
@workingjubilee
workingjubileeforce-pushed the dont-shuffle-bswaps-per-arch branch from c7fd742 to 6b0deb2CompareJune 10, 2025 06:15
@workingjubilee

Copy link
Copy Markdown
MemberAuthor

...sigh. I had somehow left in a revision that I thought I removed.

@bors r=nikic

@bors

bors commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6b0deb2 has been approved by nikic

It is now in the queue for this repository.

fmease added a commit to fmease/rust that referenced this pull request Jun 10, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
@fmeasefmease mentioned this pull request Jun 10, 2025
bors added a commit that referenced this pull request Jun 11, 2025
Rollup of 13 pull requests
Successful merges:
- #128425 (Make `missing_fragment_specifier` an unconditional error)
- #141639 (Expose discriminant values in stable_mir)
- #141967 (Configure bootstrap backport nominations through triagebot)
- #142042 (Make E0621 missing lifetime suggestion verbose)
- #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- #142235 (Build rustc with assertions in `dist-alt` jobs)
- #142248 (Add supported asm types for LoongArch32)
- #142272 (tests: Change ABIs in tests to more future-resilient ones)
- #142282 (Only run `citool` tests on the `auto` branch)
- #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
- #142297 (Implement `//@ needs-target-std` compiletest directive)
- #142298 (Make loongarch-none target maintainers more easily pingable)
- #142306 (Dont unwrap and re-wrap typing envs)
Failed merges:
- #141942 (Implement representation options to smir)
r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
bors added a commit that referenced this pull request Jun 11, 2025
Rollup of 13 pull requests
Successful merges:
- #134841 (Look at proc-macro attributes when encountering unknown attribute)
- #141639 (Expose discriminant values in stable_mir)
- #141967 (Configure bootstrap backport nominations through triagebot)
- #142042 (Make E0621 missing lifetime suggestion verbose)
- #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- #142248 (Add supported asm types for LoongArch32)
- #142272 (tests: Change ABIs in tests to more future-resilient ones)
- #142282 (Only run `citool` tests on the `auto` branch)
- #142297 (Implement `//@ needs-target-std` compiletest directive)
- #142298 (Make loongarch-none target maintainers more easily pingable)
- #142306 (Dont unwrap and re-wrap typing envs)
- #142324 (Remove unneeded `FunctionCx` from some codegen methods)
- #142328 (feat: Add `bit_width` for unsigned integer types)
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubileeworkingjubilee added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jun 11, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025
…-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
bors added a commit that referenced this pull request Jun 13, 2025
Rollup of 9 pull requests
Successful merges:
- #128425 (Make `missing_fragment_specifier` an unconditional error)
- #135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- #140770 (add `extern "custom"` functions)
- #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- #142248 (Add supported asm types for LoongArch32)
- #142267 (assert more in release in `rustc_ast_lowering`)
- #142274 (Update the stdarch submodule)
- #142276 (Update dependencies in `library/Cargo.lock`)
- #142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- #140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
bors added a commit that referenced this pull request Jun 13, 2025
Rollup of 9 pull requests
Successful merges:
- #128425 (Make `missing_fragment_specifier` an unconditional error)
- #135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- #140770 (add `extern "custom"` functions)
- #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- #142248 (Add supported asm types for LoongArch32)
- #142267 (assert more in release in `rustc_ast_lowering`)
- #142274 (Update the stdarch submodule)
- #142276 (Update dependencies in `library/Cargo.lock`)
- #142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- #140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@bors
bors merged commit 9daf8ea into rust-lang:masterJun 13, 2025
@rustbotrustbot added this to the 1.89.0 milestone Jun 13, 2025
rust-timer added a commit that referenced this pull request Jun 13, 2025
Rollup merge of #142176 - workingjubilee:dont-shuffle-bswaps-per-arch, r=nikic
tests: Split dont-shuffle-bswaps along opt-levels and arches
This duplicates dont-shuffle-bswaps in order to make each opt level its own test. Then -opt3.rs gets split into a revision per arch we want to test, with certain architectures gaining new target-cpu minimums.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jun 14, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Jun 14, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 16, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 18, 2025
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang#140770 (add `extern "custom"` functions)
- rust-lang#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang#142248 (Add supported asm types for LoongArch32)
- rust-lang#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang#142274 (Update the stdarch submodule)
- rust-lang#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request Jun 28, 2025
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#128425 (Make `missing_fragment_specifier` an unconditional error)
- rust-lang/rust#135927 (retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features)
- rust-lang/rust#140770 (add `extern "custom"` functions)
- rust-lang/rust#142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
- rust-lang/rust#142248 (Add supported asm types for LoongArch32)
- rust-lang/rust#142267 (assert more in release in `rustc_ast_lowering`)
- rust-lang/rust#142274 (Update the stdarch submodule)
- rust-lang/rust#142276 (Update dependencies in `library/Cargo.lock`)
- rust-lang/rust#142308 (Upgrade `object`, `addr2line`, and `unwinding` in the standard library)
Failed merges:
- rust-lang/rust#140920 (Extract some shared code from codegen backend target feature handling)
r? `@ghost`
`@rustbot` modify labels: rollup
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dont-shuffle-bswaps codegen test broken on none-x86_64/arm64 archs

5 participants

@workingjubilee@rust-log-analyzer@bors@nikic@rustbot