Skip to content

tests/ui: A New Order [8/N] - #142200

Merged
bors merged 1 commit into
rust-lang:masterfrom
Kivooeo:tf8
Jun 26, 2025
Merged

tests/ui: A New Order [8/N]#142200
bors merged 1 commit into
rust-lang:masterfrom
Kivooeo:tf8

Conversation

@Kivooeo

@KivooeoKivooeo commented Jun 8, 2025•
edited by jieyouxu
Loading

Copy link
Copy Markdown
Member

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

@rustbot

rustbot commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@KivooeoKivooeo mentioned this pull request Jun 11, 2025
Merged
@jieyouxu

jieyouxu commented Jun 11, 2025

Copy link
Copy Markdown
Member

r? jieyouxu

@rustbotrustbot assigned jieyouxu and unassigned davidtwcoJun 11, 2025
jieyouxu
jieyouxu requested changes Jun 23, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and sorry for the delay. I have some feedback.

Comment threadtests/ui/generics/default-type-params-well-formedness.rs Outdated
Comment threadtests/ui/deprecation-in-force-unstable.rs
Comment threadtests/ui/deref-rc.rs
Comment threadtests/ui/deref.rs
Comment threadtests/ui/derives/derive-debug-uninhabited-enum.rs Outdated
Comment threadtests/ui/derives/derive-debug-uninhabited-enum.rs
Comment threadtests/ui/typeck/inference-method-chain-diverging-fallback.rs Outdated
Comment threadtests/ui/diverging-fallback-option.rs
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rustbot

rustbot commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@Kivooeo

Kivooeo commented Jun 23, 2025

Copy link
Copy Markdown
MemberAuthor

@jieyouxu should i care about this warning above if there is no conflicts and im not touching anything compiler related?

@jieyouxu

jieyouxu commented Jun 23, 2025

Copy link
Copy Markdown
Member

Nah, it's just advisory

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo

Kivooeo commented Jun 23, 2025

Copy link
Copy Markdown
MemberAuthor

wow, really? but how it works without explicit type

@Kivooeo

Kivooeo commented Jun 23, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
jieyouxu
jieyouxu approved these changes Jun 25, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu

jieyouxu commented Jun 25, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7936070 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
scimind2460 added a commit to scimind2460/rust that referenced this pull request Jun 25, 2025
@scimind2460
Rollup merge ofrust-lang#142200- Kivooeo:tf8, r=jieyouxu
837c35c
`tests/ui`: A New Order [8/N]
Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.
@scimind2460scimind2460 mentioned this pull request Jun 25, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 25, 2025
@matthiaskrgr
Rollup merge ofrust-lang#142200- Kivooeo:tf8, r=jieyouxu
e43dc11
`tests/ui`: A New Order [8/N]
Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 25, 2025
Closed
@jdonszelmannjdonszelmann mentioned this pull request Jun 25, 2025
Merged
bors added a commit that referenced this pull request Jun 25, 2025
@bors
Auto merge of#143026- jdonszelmann:rollup-z7mkuyt, r=jdonszelmann
bc4376f
Rollup of 7 pull requests
Successful merges:
- #142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`)
- #142200 (`tests/ui`: A New Order [8/N])
- #142724 (Add runtime check to avoid overwrite arg in `Diag`)
- #142809 (Add PrintTAFn flag for targeted type analysis printing)
- #142976 (Check CoerceUnsized impl validity before coercing)
- #142992 (Convert some ABI tests to use `extern "rust-invalid"`)
- #143000 (Make `Sub`, `Mul`, `Div` and `Rem` `const_traits`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 131a2e4 into rust-lang:masterJun 26, 2025
@rustbotrustbot added this to the 1.90.0 milestone Jun 26, 2025
rust-timer added a commit that referenced this pull request Jun 26, 2025
@rust-timer
Unrolled build for#142200
237096c
Rollup merge of #142200 - Kivooeo:tf8, r=jieyouxu
`tests/ui`: A New Order [8/N]
Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 26, 2025
@bors
Auto merge of #143026 - jdonszelmann:rollup-z7mkuyt, r=jdonszelmann
c6ba365
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#142146 (Withdraw the claim `extern "C-cmse-nonsecure-*"` always matches `extern "C"`)
- rust-lang/rust#142200 (`tests/ui`: A New Order [8/N])
- rust-lang/rust#142724 (Add runtime check to avoid overwrite arg in `Diag`)
- rust-lang/rust#142809 (Add PrintTAFn flag for targeted type analysis printing)
- rust-lang/rust#142976 (Check CoerceUnsized impl validity before coercing)
- rust-lang/rust#142992 (Convert some ABI tests to use `extern "rust-invalid"`)
- rust-lang/rust#143000 (Make `Sub`, `Mul`, `Div` and `Rem` `const_traits`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnselicEnselicEnselic left review comments
@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Kivooeo@rustbot@rust-log-analyzer@jieyouxu@bors@Enselic@davidtwco