Skip to content

Ban projecting into SIMD types [MCP838] - #143833

Merged
bors merged 5 commits into
rust-lang:masterfrom
scottmcm:final-mcp-838
Jul 21, 2025
Merged

Ban projecting into SIMD types [MCP838]#143833
bors merged 5 commits into
rust-lang:masterfrom
scottmcm:final-mcp-838

Conversation

@scottmcm

@scottmcmscottmcm commented Jul 12, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Closesrust-lang/compiler-team#838

The actual compiler change here is tiny; there's just a bazillion tests to update.

Since I'm sure I've missed some, for now
r ghost

try-job: test-various
try-job: x86_64-gnu-nopt

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcmscottmcm mentioned this pull request Jul 12, 2025
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm

scottmcm commented Jul 13, 2025

Copy link
Copy Markdown
MemberAuthor

Since you previously commented on 138036, how about
r? @compiler-errors

@scottmcm
scottmcm marked this pull request as ready for review July 13, 2025 19:47
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2025
@rustbot

rustbot commented Jul 13, 2025

Copy link
Copy Markdown
Collaborator

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@workingjubileeworkingjubilee mentioned this pull request Jul 14, 2025
Merged
@compiler-errors

compiler-errors commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit fa7734a has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 17, 2025
@fmease
Rollup merge ofrust-lang#143833- scottmcm:final-mcp-838, r=compiler…
97b0851
…-errors
Ban projecting into SIMD types [MCP838]
Closesrust-lang/compiler-team#838
The actual compiler change here is tiny; there's just a bazillion tests to update.
Since I'm sure I've missed some, for now
r? ghost
@fmeasefmease mentioned this pull request Jul 17, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request Jul 17, 2025
@fmease
Rollup merge ofrust-lang#143833- scottmcm:final-mcp-838, r=compiler…
de1bb37
…-errors
Ban projecting into SIMD types [MCP838]
Closesrust-lang/compiler-team#838
The actual compiler change here is tiny; there's just a bazillion tests to update.
Since I'm sure I've missed some, for now
r? ghost
@fmeasefmease mentioned this pull request Jul 17, 2025
Closed
@bors

bors commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 41ce1ed with merge 4dc4ab1...

bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of#143833- scottmcm:final-mcp-838, r=<try>
4dc4ab1
Ban projecting into SIMD types [MCP838]
Closesrust-lang/compiler-team#838
The actual compiler change here is tiny; there's just a bazillion tests to update.
~~Since I'm sure I've missed some, for now~~
~~r ghost~~
try-job: test-various
try-job: x86_64-gnu-nopt
@bors

bors commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 4dc4ab1 (4dc4ab197770cfd2da11fb83b224df924e7e594f)

@scottmcm

scottmcm commented Jul 20, 2025

Copy link
Copy Markdown
MemberAuthor

Both jobs that have failed in bors on this in the past just succeeded in that last try run, so let's give it another shot 🤞
@bors r=compiler-errors

@bors

bors commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 41ce1ed has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2025
@bors

bors commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 41ce1ed with merge e05ab47...

github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 21, 2025
@GuillaumeGomez
Rollup merge of #144190 - scottmcm:spanned-errors-in-mir-validation, …
933b567
…r=RalfJung
Give a message with a span on MIR validation error
It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement.
r? mir
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
@GuillaumeGomez
Rollup merge of #144190 - scottmcm:spanned-errors-in-mir-validation, …
ac0f697
…r=RalfJung
Give a message with a span on MIR validation error
It was handy to get a source+line link for rust-lang/rust#143833, even if it's just to the function and not necessarily to the statement.
r? mir
@bors

bors commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e05ab47 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2025
@bors
bors merged commit e05ab47 into rust-lang:masterJul 21, 2025
@rustbotrustbot added this to the 1.90.0 milestone Jul 21, 2025
@github-actions

github-actionsBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 460259d (parent) -> e05ab47 (this PR)

Test differences

Show 7 test diffs

Stage 1

  • [codegen] tests/codegen/simd/project-to-simd-array-field.rs: pass -> [missing] (J0)
  • [ui] tests/ui/mir/validate/project-into-simd.rs: [missing] -> pass (J0)

Stage 2

  • [codegen] tests/codegen/simd/project-to-simd-array-field.rs: pass -> [missing] (J1)
  • [ui] tests/ui/mir/validate/project-into-simd.rs: [missing] -> pass (J2)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

  • J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
  • J1: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
  • J2: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e05ab47e6c418fb2b9faa2eae9a7e70c65c98eaa --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 7318.3s -> 5588.6s (-23.6%)
  2. aarch64-apple: 4203.8s -> 5193.2s (23.5%)
  3. x86_64-apple-2: 5373.1s -> 4143.1s (-22.9%)
  4. test-various: 4522.2s -> 5035.3s (11.3%)
  5. dist-aarch64-apple: 5238.1s -> 5752.6s (9.8%)
  6. aarch64-msvc-1: 6968.7s -> 7642.9s (9.7%)
  7. dist-ohos-armv7: 3763.3s -> 4089.4s (8.7%)
  8. x86_64-msvc-1: 7906.6s -> 8586.6s (8.6%)
  9. x86_64-gnu-debug: 6468.4s -> 5934.8s (-8.2%)
  10. armhf-gnu: 4885.6s -> 5273.4s (7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@scottmcm

scottmcm commented Jul 21, 2025

Copy link
Copy Markdown
MemberAuthor

I'm glad it worked, but it figures that as soon as I give up on rollups I get it right 🤦

@scottmcm
scottmcm deleted the final-mcp-838 branch July 21, 2025 05:49
@scottmcmscottmcm mentioned this pull request Jul 21, 2025
Closed
3 tasks
@rust-timer

rust-timer commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e05ab47): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.1%[0.1%, 0.1%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary -3.2%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-3.2%[-5.4%, -1.0%]2
Improvements ✅
(secondary)		-4.1%[-6.6%, -2.3%]6
All ❌✅ (primary)-3.2%[-5.4%, -1.0%]2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.025s -> 466.006s (-0.00%)
Artifact size: 374.56 MiB -> 374.60 MiB (0.01%)

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@GuillaumeGomez@Muscraft
Rollup merge ofrust-lang#144190- scottmcm:spanned-errors-in-mir-val…
9516fdd
…idation, r=RalfJung
Give a message with a span on MIR validation error
It was handy to get a source+line link for rust-lang#143833, even if it's just to the function and not necessarily to the statement.
r? mir
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors@Muscraft
Auto merge ofrust-lang#143833- scottmcm:final-mcp-838, r=compiler-e…
f4d52a5
…rrors
Ban projecting into SIMD types [MCP838]
Closesrust-lang/compiler-team#838
The actual compiler change here is tiny; there's just a bazillion tests to update.
~~Since I'm sure I've missed some, for now~~
~~r ghost~~
try-job: test-various
try-job: x86_64-gnu-nopt
@folkertdevfolkertdev mentioned this pull request Jul 22, 2025
Merged
@scottmcmscottmcm mentioned this pull request Jul 29, 2025
Closed
tautschnig added a commit to tautschnig/kani that referenced this pull request Jul 29, 2025
@tautschnig
Upgrade Rust toolchain to 2025-07-24
7cd7f52
Relevant upstream PR:
- rust-lang/rust#143833 (Ban projecting into SIMD types
[MCP838])
@tautschnigtautschnig mentioned this pull request Jul 29, 2025
Merged
github-merge-queueBot pushed a commit to model-checking/kani that referenced this pull request Jul 29, 2025
@tautschnig
Upgrade Rust toolchain to 2025-07-24 (#4244)
313f9b1
Relevant upstream PR:
- rust-lang/rust#143833 (Ban projecting into
SIMD types [MCP838])
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
@madsmtmmadsmtm mentioned this pull request Nov 15, 2025
Closed
@davidtwcodavidtwco mentioned this pull request Aug 7, 2026
Merged
RalfJung
RalfJung reviewed Aug 23, 2026
View reviewed changes
Comment threadtests/codegen/simd-intrinsic/simd-intrinsic-transmute-array.rs
#[derive(Copy, Clone)]
pub struct T([f32; 4]);
pub type S<const N: usize> = Simd<f32, N>;
pub type T = Simd<f32, 4>;

@RalfJungRalfJungAug 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now S<4> and T are the exact same type so IMO it is pointless to test both of them. Just makes this test harder to maintain.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

Assignees

@compiler-errorscompiler-errors

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

Ban projecting into repr(simd) types

8 participants

@scottmcm@rust-log-analyzer@rustbot@compiler-errors@bors@matthiaskrgr@rust-timer@RalfJung