Add new `ignore-backends` and `needs-backends` tests annotations by GuillaumeGomez · Pull Request #144125 · rust-lang/rust

GuillaumeGomez · 2025-07-18T10:07:10Z

Next step will be to add these annotations in the files where either the output is different based on the codegen (like asm tests) or that are known to fail in the GCC backend.

cc @oli-obk @antoyo
r? @Kobzol

rustbot · 2025-07-18T10:07:18Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

bjorn3 · 2025-07-18T11:35:15Z

For asm tests I think adding //@ needs-backends: llvm to every test is a bad idea. Rather I think gating the entire asm test suite behind the LLVM backend inside compiletest itself or moving the test assertions to backend specific files would be better options. For ui tests these test annotations do make sense to me however.

GuillaumeGomez · 2025-07-18T11:37:44Z

I didn't look how many tests were there but you're right, would make more sense to just ignore these tests completely if it's not llvm backend. I think I'll rename the folder to better express it (asm -> asm-llvm). It could also allow to add a more generic check for this folder by directly checking if the backend name matches the current one, allowing to add asm tests for cranelift and gcc backends.

Kobzol

CC @jieyouxu

jieyouxu · 2025-07-18T13:41:43Z

For asm tests I think adding //@ needs-backends: llvm to every test is a bad idea. Rather I think gating the entire asm test suite behind the LLVM backend inside compiletest itself or moving the test assertions to backend specific files would be better options. For ui tests these test annotations do make sense to me however.

Yeah, I think this is for the best.

GuillaumeGomez · 2025-07-18T15:00:19Z

Applied suggestion.

bors · 2025-07-20T04:52:32Z

☔ The latest upstream changes (presumably #143002) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2025-07-20T12:44:30Z

Fixed merge conflict. Was there anything else to be done here?

Kobzol · 2025-07-20T13:30:30Z

Fine by me.

@bors r+

bors · 2025-07-20T13:30:33Z

📌 Commit 4a35a9f has been approved by Kobzol

It is now in the queue for this repository.

Rollup of 9 pull requests Successful merges: - #143282 (Add `uX::strict_sub_signed`) - #143423 (address clippy formatting nits) - #143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - #144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - #144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - #144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - #144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - #144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - #144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144125 - GuillaumeGomez:new-annotations, r=Kobzol Add new `ignore-backends` and `needs-backends` tests annotations Part of rust-lang/compiler-team#891. Next step will be to add these annotations in the files where either the output is different based on the codegen (like `asm` tests) or that are known to fail in the GCC backend. cc `@oli-obk` `@antoyo` r? `@Kobzol`

Rollup of 9 pull requests Successful merges: - rust-lang/rust#143282 (Add `uX::strict_sub_signed`) - rust-lang/rust#143423 (address clippy formatting nits) - rust-lang/rust#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang/rust#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang/rust#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang/rust#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang/rust#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang/rust#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang/rust#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

…Kobzol Add new `ignore-backends` and `needs-backends` tests annotations Part of rust-lang/compiler-team#891. Next step will be to add these annotations in the files where either the output is different based on the codegen (like `asm` tests) or that are known to fail in the GCC backend. cc `@oli-obk` `@antoyo` r? `@Kobzol`

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#143282 (Add `uX::strict_sub_signed`) - rust-lang#143423 (address clippy formatting nits) - rust-lang#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

Rename `tests/{assembly,codegen}` into `tests/{assembly,codegen}-llvm` and ignore these testsuites if configured backend doesn't match Follow-up of #144125. This PR changes `compiletest` so that `asm` tests are only run if they match the current codegen backend. To better reflect it, I renamed the `tests/ui/asm` folder into `tests/ui/asm-llvm`. Like that, we can add new asm tests for other backends if we want without needing to add extra code to `compiletest`. Next step will be to use the new code annotations added in #144125 to ignore ui tests failing in cg_gcc until it's fixed on our side. cc `@antoyo` `@oli-obk` r? `@Kobzol`

Rename `tests/{assembly,codegen}` into `tests/{assembly,codegen}-llvm` and ignore these testsuites if configured backend doesn't match Follow-up of rust-lang/rust#144125. This PR changes `compiletest` so that `asm` tests are only run if they match the current codegen backend. To better reflect it, I renamed the `tests/ui/asm` folder into `tests/ui/asm-llvm`. Like that, we can add new asm tests for other backends if we want without needing to add extra code to `compiletest`. Next step will be to use the new code annotations added in rust-lang/rust#144125 to ignore ui tests failing in cg_gcc until it's fixed on our side. cc `@antoyo` `@oli-obk` r? `@Kobzol`

…=jieyouxu Add `ignore-backends` annotations in failing GCC backend ui tests Follow-up of rust-lang#144125. In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt). This PR adds the `ignore-backends` annotations to the corresponding ui tests. The second commit is a fix to compiletest, complaining about `ignore-backends`. r? `@jieyouxu`

…=jieyouxu Add `ignore-backends` annotations in failing GCC backend ui tests Follow-up of rust-lang#144125. In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt). This PR adds the `ignore-backends` annotations to the corresponding ui tests. The second commit is a fix to compiletest, complaining about `ignore-backends`. r? ``@jieyouxu``

…=jieyouxu Add `ignore-backends` annotations in failing GCC backend ui tests Follow-up of rust-lang#144125. In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt). This PR adds the `ignore-backends` annotations to the corresponding ui tests. The second commit is a fix to compiletest, complaining about `ignore-backends`. r? ```@jieyouxu```

Rollup merge of #144356 - GuillaumeGomez:gcc-ignore-tests, r=jieyouxu Add `ignore-backends` annotations in failing GCC backend ui tests Follow-up of #144125. In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt). This PR adds the `ignore-backends` annotations to the corresponding ui tests. The second commit is a fix to compiletest, complaining about `ignore-backends`. r? ```@jieyouxu```

Rename `tests/{assembly,codegen}` into `tests/{assembly,codegen}-llvm` and ignore these testsuites if configured backend doesn't match Follow-up of rust-lang#144125. This PR changes `compiletest` so that `asm` tests are only run if they match the current codegen backend. To better reflect it, I renamed the `tests/ui/asm` folder into `tests/ui/asm-llvm`. Like that, we can add new asm tests for other backends if we want without needing to add extra code to `compiletest`. Next step will be to use the new code annotations added in rust-lang#144125 to ignore ui tests failing in cg_gcc until it's fixed on our side. cc `@antoyo` `@oli-obk` r? `@Kobzol`

Rename `tests/{assembly,codegen}` into `tests/{assembly,codegen}-llvm` and ignore these testsuites if configured backend doesn't match Follow-up of rust-lang/rust#144125. This PR changes `compiletest` so that `asm` tests are only run if they match the current codegen backend. To better reflect it, I renamed the `tests/ui/asm` folder into `tests/ui/asm-llvm`. Like that, we can add new asm tests for other backends if we want without needing to add extra code to `compiletest`. Next step will be to use the new code annotations added in rust-lang/rust#144125 to ignore ui tests failing in cg_gcc until it's fixed on our side. cc `@antoyo` `@oli-obk` r? `@Kobzol`

rustbot assigned Kobzol Jul 18, 2025

Kobzol reviewed Jul 18, 2025
View reviewed changes

Comment threadsrc/tools/compiletest/src/directives.rs Outdated

GuillaumeGomez force-pushed the new-annotations branch from e93ac26 to 83786e7Compare July 18, 2025 15:00

jieyouxu assigned jieyouxu and unassigned jieyouxu Jul 18, 2025

GuillaumeGomez added 2 commits July 20, 2025 14:43

Add new ignore-backends tests annotations
9944139

Add new needs-backends tests annotations
4a35a9f

GuillaumeGomez force-pushed the new-annotations branch from 83786e7 to 4a35a9fCompare July 20, 2025 12:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025

GuillaumeGomez mentioned this pull request Jul 20, 2025
Rollup of 9 pull requests #144219
Merged

bors merged commit 2abca9c into rust-lang:masterJul 20, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 20, 2025

GuillaumeGomez deleted the new-annotations branch July 21, 2025 08:55

GuillaumeGomez mentioned this pull request Jul 21, 2025
Rename tests/{assembly,codegen} into tests/{assembly,codegen}-llvm and ignore these testsuites if configured backend doesn't match #144249
Merged

GuillaumeGomez mentioned this pull request Jul 23, 2025
Add ignore-backends annotations in failing GCC backend ui tests #144356
Merged

eggyal mentioned this pull request Jan 21, 2026
Fix SourceFile::normalized_byte_pos#151455
Merged

Navigation Menu

Uh oh!

Uh oh!

Add new `ignore-backends` and `needs-backends` tests annotations - #144125

Add new `ignore-backends` and `needs-backends` tests annotations#144125
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:new-annotations

GuillaumeGomez commented Jul 18, 2025

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

bjorn3 commented Jul 18, 2025

Uh oh!

GuillaumeGomez commented Jul 18, 2025

Uh oh!

Kobzol left a comment

Uh oh!

Uh oh!

jieyouxu commented Jul 18, 2025

Uh oh!

GuillaumeGomez commented Jul 18, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

Kobzol commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Jul 18, 2025

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

bjorn3 commented Jul 18, 2025

Uh oh!

GuillaumeGomez commented Jul 18, 2025

Uh oh!

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Jul 18, 2025

Uh oh!

GuillaumeGomez commented Jul 18, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

Kobzol commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants