Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #144145
Merged
Merged
Conversation
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Only relevant to the internal feature `more_maybe_bounds`.
We no longer move trait predicates where the self ty is a ty param to "the bounds of a ty param".
adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized will be already built in Stage 1, so my previous PR should be addressed for this change
* The phrasing "only does something for" made sense back when this diagnostic was a (hard) warning. Now however, it's simply a hard error and thus completely rules out "doing something". * The primary message was way too long * The new wording more closely mirrors the wording we use for applying other bound modifiers (like `const` and `async`) to incompatible traits. * "all other traits are not bound by default" is no longer accurate under Sized Hierarchy. E.g., traits and assoc tys are (currently) bounded by `MetaSized` by default but can't be relaxed using `?MetaSized` (instead, you relax it by adding `PointeeSized`). * I've decided against adding any diagnositic notes or suggestions for now like "trait `Trait` can't be relaxed as it's not bound by default" which would be incorrect for `MetaSized` and assoc tys as mentioned above) or "consider changing `?MetaSized` to `PointeeSized`" as the Sized Hierarchy impl is still WIP)
Having multiple relaxed bounds like `?Sized + ?Iterator` is actually *fine*. We actually want to reject *duplicate* relaxed bounds like `?Sized + ?Sized` because these most certainly represent a user error. Note that this doesn't mean that we accept more code because a bound like `?Iterator` is still invalid as it's not relaxing a *default* trait and the only way to define / use more default bounds is under the experimental and internal feature `more_maybe_bounds` plus `lang_items` plus unstable flag `-Zexperimental-default-bounds` (historical context: for the longest time, bounds like `?Iterator` were actually allowed and lead to a hard warning). Ultimately, this simply *reframes* the diagnostic. The scope of `more_maybe_bounds` / `-Zexperimental-default-bounds` remains unchanged as well.
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Distinguish delim kind to decide whether to emit unexpected closing delimiter Fixesrust-lang#138401
Show the offset, length and memory of uninit read errors r? ``@RalfJung`` I want to improve memory dumps in general. Not sure yet how to do so best within rust diagnostics, but in a perfect world I could generate a dummy in-memory file (that contains the rendered memory dump) that we then can then provide regular rustc `Span`s to. So we'd basically report normal diagnostics for them with squiggly lines and everything.
…er-errors More robustly deal with relaxed bounds and improve their diagnostics Scaffolding for rust-lang#135229 (CC rust-lang#135331) Fixesrust-lang#136944 (6th commit). Fixesrust-lang#142718 (8th commit).
…z, r=jhpratt stabilize `const_slice_reverse` cc rust-lang#135120, needs FCP.
opt-dist: make llvm builds optional adds command line option for disabling llvm builds. it's useful in case of user having their own optimized LLVM, so they won't waste time for (at least) 3 LLVM builds. in this case PGO optimized rustc will be already built in Stage 1, so rust-lang#143898 should be addressed for this change couldn't test locally on Linux laptop due to small SSD storage, will try now with windows-msvc host r? ``@Kobzol`` try-job: dist-x86_64-linux try-job: dist-x86_64-msvc
…, r=rcvalle Correct which exploit mitigations are enabled by default This was brought up by ``@Noratrieb`` in [#project-exploit-mitigations > Incorrect table in the rustc book](https://rust-lang.zulipchat.com/#narrow/channel/343119-project-exploit-mitigations/topic/Incorrect.20table.20in.20the.20rustc.20book/with/523684203). Thanks! :) [Rendered](https://github.com/rust-lang/rust/blob/132a47e72316b60e99c3e5fefb9c3a06641138e4/src/doc/rustc/src/exploit-mitigations.md) r? ``@rcvalle``
…rt, r=jdonszelmann Fix encoding of link_section and no_mangle cross crate Fixesrust-lang#144004 ``@bjorn3`` suggested using the `codegen_fn_attrs` query but given that these attributes are not that common it's probably fine to just always encode them. I can also go for that solution if it is preferred but that would require more changes. r? ``@jdonszelmann`` ``@fmease`` (whoever feels like it)
…er, r=petrochenkov Refactor `CrateLoader` into the `CStore` Removes the `CrateLoader` and moves the code to `CStore`. Now, if you want to use the `CrateLoader`, you can just use `CStore`. Should we rename `creader.rs` to `cstore.rs`? r? ``@petrochenkov``
Generalize `unsize` and `unsize_into` destinations Just something that I noticed during other work. We do this for most such functions, so let's do it here, too. r? ``@RalfJung``
rust-log-analyzer
commented
Jul 19, 2025
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Jul 19, 2025
Collaborator
💔 Test failed - checks-actions |
matthiaskrgr
commented
Jul 19, 2025
MemberAuthor
@bors retry |
bors
commented
Jul 19, 2025
Collaborator
bors
commented
Jul 19, 2025
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Jul 19, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: ebd8557637 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing ebd8557 (parent) -> 1079c5e (this PR) Test differencesShow 335 test diffsStage 1
Stage 2
Additionally, 248 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1079c5edb2bd837e5c4cf8c7db2892db359a3862 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jul 19, 2025
rust-timer
commented
Jul 19, 2025
Collaborator
Finished benchmarking commit (1079c5e): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.3%, secondary 6.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.449s -> 464.831s (-0.13%) |
Muscraft pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#138554 (Distinguish delim kind to decide whether to emit unexpected closing delimiter) - rust-lang#142673 (Show the offset, length and memory of uninit read errors) - rust-lang#142693 (More robustly deal with relaxed bounds and improve their diagnostics) - rust-lang#143382 (stabilize `const_slice_reverse`) - rust-lang#143928 (opt-dist: make llvm builds optional) - rust-lang#143961 (Correct which exploit mitigations are enabled by default) - rust-lang#144050 (Fix encoding of link_section and no_mangle cross crate) - rust-lang#144059 (Refactor `CrateLoader` into the `CStore`) - rust-lang#144123 (Generalize `unsize` and `unsize_into` destinations) r? `@ghost` `@rustbot` modify labels: rollup
rylev
commented
Jul 22, 2025
Member
@rust-timer build cc3dceb |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Jul 22, 2025
Collaborator
Finished benchmarking commit (cc3dceb): comparison URL. Overall result: ✅ improvements - no action neededInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.1%, secondary 4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 465.449s -> 464.898s (-0.12%) |
lqd
commented
Jul 22, 2025
Member
@rust-timer build 939057b |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Jul 22, 2025
Collaborator
Finished benchmarking commit (939057b): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%, secondary 6.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 465.449s -> 466.099s (0.14%) |
lqd
commented
Jul 22, 2025
Member
The regressions in large-workspace are from #144059 cc @petrochenkov for awareness/triage etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_slice_reverse#143382 (stabilizeconst_slice_reverse)CrateLoaderinto theCStore#144059 (RefactorCrateLoaderinto theCStore)unsizeandunsize_intodestinations #144123 (Generalizeunsizeandunsize_intodestinations)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup