Skip to content

Debug impls for DropElaborators - #144162

Merged
bors merged 1 commit into
rust-lang:masterfrom
beepster4096:drop_elaborator_debug_impls
Jul 21, 2025
Merged

Debug impls for DropElaborators#144162
bors merged 1 commit into
rust-lang:masterfrom
beepster4096:drop_elaborator_debug_impls

Conversation

@beepster4096

Copy link
Copy Markdown
Contributor

It's a little weird that these just have a completely empty Debug impl. Now they're ElaborateDropsCtxt { .. } and DropShimElaborator { .. }.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jul 20, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2a03750 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 20, 2025
…_impls, r=compiler-errors
Debug impls for DropElaborators
It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.
bors added a commit that referenced this pull request Jul 20, 2025
Rollup of 7 pull requests
Successful merges:
- #142097 (gpu offload host code generation)
- #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
- #144144 (tests: Skip supported-crate-types test on musl hosts)
- #144159 (opt-dist: change build_dir field to be an actual build dir)
- #144162 (Debug impls for DropElaborators)
- #144189 (Add non-regression test for #144168)
- #144216 (Don't consider unstable fields always-inhabited)
r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 20, 2025
…_impls, r=compiler-errors
Debug impls for DropElaborators
It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.
bors added a commit that referenced this pull request Jul 21, 2025
Rollup of 6 pull requests
Successful merges:
- #142097 (gpu offload host code generation)
- #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
- #144144 (tests: Skip supported-crate-types test on musl hosts)
- #144162 (Debug impls for DropElaborators)
- #144189 (Add non-regression test for #144168)
- #144216 (Don't consider unstable fields always-inhabited)
r? `@ghost`
`@rustbot` modify labels: rollup
@jhprattjhpratt mentioned this pull request Jul 21, 2025
bors added a commit that referenced this pull request Jul 21, 2025
Rollup of 8 pull requests
Successful merges:
- #144144 (tests: Skip supported-crate-types test on musl hosts)
- #144159 (opt-dist: change build_dir field to be an actual build dir)
- #144162 (Debug impls for DropElaborators)
- #144189 (Add non-regression test for #144168)
- #144216 (Don't consider unstable fields always-inhabited)
- #144229 (Miri subtree update)
- #144230 (Option::as_slice: fix comment)
- #144235 (Fix run-make tests on musl hosts)
r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 21, 2025
…_impls, r=compiler-errors
Debug impls for DropElaborators
It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.
@jieyouxujieyouxu mentioned this pull request Jul 21, 2025
bors added a commit that referenced this pull request Jul 21, 2025
Rollup of 8 pull requests
Successful merges:
- #144144 (tests: Skip supported-crate-types test on musl hosts)
- #144159 (opt-dist: change build_dir field to be an actual build dir)
- #144162 (Debug impls for DropElaborators)
- #144189 (Add non-regression test for #144168)
- #144216 (Don't consider unstable fields always-inhabited)
- #144229 (Miri subtree update)
- #144230 (Option::as_slice: fix comment)
- #144235 (Fix run-make tests on musl hosts)
r? `@ghost`
`@rustbot` modify labels: rollup
@lcnrlcnr assigned compiler-errors and unassigned lcnrJul 21, 2025
@bors
bors merged commit 7d0c7b2 into rust-lang:masterJul 21, 2025
11 checks passed
@rustbotrustbot added this to the 1.90.0 milestone Jul 21, 2025
rust-timer added a commit that referenced this pull request Jul 21, 2025
Rollup merge of #144162 - beepster4096:drop_elaborator_debug_impls, r=compiler-errors
Debug impls for DropElaborators
It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
…_impls, r=compiler-errors
Debug impls for DropElaborators
It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang#144144 (tests: Skip supported-crate-types test on musl hosts)
- rust-lang#144159 (opt-dist: change build_dir field to be an actual build dir)
- rust-lang#144162 (Debug impls for DropElaborators)
- rust-lang#144189 (Add non-regression test for rust-lang#144168)
- rust-lang#144216 (Don't consider unstable fields always-inhabited)
- rust-lang#144229 (Miri subtree update)
- rust-lang#144230 (Option::as_slice: fix comment)
- rust-lang#144235 (Fix run-make tests on musl hosts)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Jul 22, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#144144 (tests: Skip supported-crate-types test on musl hosts)
- rust-lang/rust#144159 (opt-dist: change build_dir field to be an actual build dir)
- rust-lang/rust#144162 (Debug impls for DropElaborators)
- rust-lang/rust#144189 (Add non-regression test for rust-lang/rust#144168)
- rust-lang/rust#144216 (Don't consider unstable fields always-inhabited)
- rust-lang/rust#144229 (Miri subtree update)
- rust-lang/rust#144230 (Option::as_slice: fix comment)
- rust-lang/rust#144235 (Fix run-make tests on musl hosts)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#144144 (tests: Skip supported-crate-types test on musl hosts)
- rust-lang/rust#144159 (opt-dist: change build_dir field to be an actual build dir)
- rust-lang/rust#144162 (Debug impls for DropElaborators)
- rust-lang/rust#144189 (Add non-regression test for rust-lang/rust#144168)
- rust-lang/rust#144216 (Don't consider unstable fields always-inhabited)
- rust-lang/rust#144229 (Miri subtree update)
- rust-lang/rust#144230 (Option::as_slice: fix comment)
- rust-lang/rust#144235 (Fix run-make tests on musl hosts)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@beepster4096@rustbot@compiler-errors@bors@lcnr