Skip to content

opt-dist: add an option for setting path to stage0 root - #144164

Merged
bors merged 1 commit into
rust-lang:masterfrom
ognevny:opt-dist-stage0-root
Jul 22, 2025
Merged

opt-dist: add an option for setting path to stage0 root#144164
bors merged 1 commit into
rust-lang:masterfrom
ognevny:opt-dist-stage0-root

Conversation

@ognevny

@ognevnyognevny commented Jul 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config

r? Kobzol

try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux

@rustbotrustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 19, 2025
@ognevnyognevny changed the title Opt dist stage0 root opt-dist: add an option for setting path to stage0 rootJul 19, 2025
@ognevny
ognevny marked this pull request as ready for review July 19, 2025 06:49
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2025
@rustbot

rustbot commented Jul 19, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@ognevny
ognevnyforce-pushed the opt-dist-stage0-root branch 2 times, most recently from 38f8102 to 0d8e7c1CompareJuly 21, 2025 12:38
@ognevny

ognevny commented Jul 21, 2025

Copy link
Copy Markdown
ContributorAuthor

@Kobzol rebased

Kobzol
Kobzol reviewed Jul 21, 2025
View reviewed changes

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try.

@bors try

Comment threadsrc/tools/opt-dist/src/environment.rs
@Kobzol

Kobzol commented Jul 21, 2025

Copy link
Copy Markdown
Member

@bors2 try

@rust-bors

rust-borsBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

⌛ Trying commit 0d8e7c1 with merge d14f82b…

To cancel the try build, run the command @bors2 try cancel.

rust-borsBot added a commit that referenced this pull request Jul 21, 2025
@rust-bors
Auto merge of#144164- ognevny:opt-dist-stage0-root, r=<try>
d14f82b
 opt-dist: add an option for setting path to stage0 root
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.
This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using
r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol
try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors

rust-borsBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

💔 Test failed

@ognevny

ognevny commented Jul 21, 2025

Copy link
Copy Markdown
ContributorAuthor

oh I see

@ognevny
opt-dist: add an option for setting path to stage0 root
fa92464
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
@ognevny
ognevnyforce-pushed the opt-dist-stage0-root branch from 0d8e7c1 to fa92464CompareJuly 21, 2025 12:58
@Kobzol

Kobzol commented Jul 21, 2025

Copy link
Copy Markdown
Member

@bors2 try

@rust-bors

rust-borsBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

⌛ Trying commit fa92464 with merge b5b89d4…

To cancel the try build, run the command @bors2 try cancel.

rust-borsBot added a commit that referenced this pull request Jul 21, 2025
@rust-bors
Auto merge of#144164- ognevny:opt-dist-stage0-root, r=<try>
b5b89d4
 opt-dist: add an option for setting path to stage0 root
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.
This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using
r? <reviewer name>
-->
<!-- homu-ignore:end -->
r? Kobzol
try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@rust-bors

rust-borsBot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b5b89d4 (b5b89d44539e233a14d265614e2cbe813ba7443c, parent: 67819923ac8ea353aaa775303f4c3aacbf41d010)

@Kobzol

Kobzol commented Jul 21, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit fa92464 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#144164- ognevny:opt-dist-stage0-root, r=Ko…
dc0b46d
…bzol
opt-dist: add an option for setting path to stage0 root
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
r? Kobzol
try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@matthiaskrgrmatthiaskrgr mentioned this pull request Jul 22, 2025
Closed
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of#144286- matthiaskrgr:rollup-1h1nn6b, r=matthiaskrgr
0d50eab
Rollup of 8 pull requests
Successful merges:
- #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
- #142924 (tidy: move rustdoc js stuff into a tidy extra check)
- #143373 (Unquerify maybe_unused_trait_imports.)
- #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
- #144082 (tests: cover more `exported_private_dependencies` cases)
- #144126 (Fix empty target_config in apply_rust_config bootstrap)
- #144164 ( opt-dist: add an option for setting path to stage0 root)
- #144265 (Dont ICE on copy error being suppressed due to overflow)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Jul 22, 2025
Merged
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of#144294- matthiaskrgr:rollup-ybvall3, r=matthiaskrgr
35487a2
Rollup of 7 pull requests
Successful merges:
- #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
- #142924 (tidy: move rustdoc js stuff into a tidy extra check)
- #143373 (Unquerify maybe_unused_trait_imports.)
- #144082 (tests: cover more `exported_private_dependencies` cases)
- #144126 (Fix empty target_config in apply_rust_config bootstrap)
- #144164 ( opt-dist: add an option for setting path to stage0 root)
- #144265 (Dont ICE on copy error being suppressed due to overflow)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5c9a37f into rust-lang:masterJul 22, 2025
12 checks passed
@rustbotrustbot added this to the 1.90.0 milestone Jul 22, 2025
rust-timer added a commit that referenced this pull request Jul 22, 2025
@rust-timer
Unrolled build for#144164
78245f5
Rollup merge of #144164 - ognevny:opt-dist-stage0-root, r=Kobzol
opt-dist: add an option for setting path to stage0 root
in MSYS2 we have problems with stage0 for *-gnullvm hosts because prebuilt dist tarballs will be
available starting from 1.90.0-beta. also this change helps to match bootstrap.toml config
r? Kobzol
try-job: dist-x86_64-msvc
try-job: dist-x86_64-linux
@ognevny
ognevny deleted the opt-dist-stage0-root branch July 26, 2025 06:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KobzolKobzolKobzol left review comments

Assignees

@KobzolKobzol

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ognevny@rustbot@Kobzol@bors