Skip to content

Enable const-vector.rs test on RISC-V (riscv64) - #144341

Merged
bors merged 1 commit into
rust-lang:masterfrom
CaiWeiran:const-vector_test
Jul 26, 2025
Merged

Enable const-vector.rs test on RISC-V (riscv64)#144341
bors merged 1 commit into
rust-lang:masterfrom
CaiWeiran:const-vector_test

Conversation

@CaiWeiran

@CaiWeiranCaiWeiran commented Jul 23, 2025

Copy link
Copy Markdown

This PR replaces #144283 to resolve merge conflicts.

This PR adds support for running the tests/codegen/const-vector.rs test on the RISC-V (riscv64) architecture.

Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.

The change has been tested locally using ./x test on a riscv64 target, and the test now passes as expected.

Notes:

  • This change is scoped specifically to improve RISC-V compatibility.
  • It does not affect behavior or test results on other architectures.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2025
@CaiWeiran

Copy link
Copy Markdown
Author

r? @wesleywiser

@rustbot

Copy link
Copy Markdown
Collaborator

wesleywiser is not on the review rotation at the moment.
They may take a while to respond.

@wesleywiser

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2e49c52 has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2025
Kobzol added a commit to Kobzol/rust that referenced this pull request Jul 25, 2025
…leywiser
Enable const-vector.rs test on RISC-V (riscv64)
This PR replaces [rust-lang#144283](rust-lang#144283) to resolve merge conflicts.
This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture.
Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.
The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected.
### Notes:
- This change is scoped specifically to improve RISC-V compatibility.
- It does not affect behavior or test results on other architectures.
@KobzolKobzol mentioned this pull request Jul 25, 2025
@tgross35tgross35 mentioned this pull request Jul 26, 2025
bors added a commit that referenced this pull request Jul 26, 2025
Rollup of 9 pull requests
Successful merges:
- #144089 (Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- #144171 (pattern_analysis: add option to get a full set of witnesses)
- #144201 (Mention type that could be `Clone` but isn't in more cases)
- #144316 (bootstrap: Move musl-root fallback out of sanity check)
- #144339 (Enable dwarf-mixed-versions-lto.rs test on RISC-V (riscv64))
- #144341 (Enable const-vector.rs test on RISC-V (riscv64))
- #144352 (RustWrapper: Suppress getNextNonDebugInfoInstruction)
- #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
- #144364 (Update `dlmalloc` dependency of libstd)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a262dad into rust-lang:masterJul 26, 2025
11 checks passed
@rustbotrustbot added this to the 1.90.0 milestone Jul 26, 2025
rust-timer added a commit that referenced this pull request Jul 26, 2025
Rollup merge of #144341 - CaiWeiran:const-vector_test, r=wesleywiser
Enable const-vector.rs test on RISC-V (riscv64)
This PR replaces [#144283](#144283) to resolve merge conflicts.
This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture.
Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.
The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected.
### Notes:
- This change is scoped specifically to improve RISC-V compatibility.
- It does not affect behavior or test results on other architectures.
@CaiWeiran
CaiWeiran deleted the const-vector_test branch July 28, 2025 06:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@CaiWeiran@rustbot@wesleywiser@bors@Mark-Simulacrum