Skip to content

rustc_public: Remove movability from RigidTy/AggregateKind::Coroutine - #144392

Merged
bors merged 1 commit into
rust-lang:masterfrom
makai410:rm-mov
Jul 25, 2025
Merged

rustc_public: Remove movability from RigidTy/AggregateKind::Coroutine#144392
bors merged 1 commit into
rust-lang:masterfrom
makai410:rm-mov

Conversation

@makai410

@makai410makai410 commented Jul 24, 2025

Copy link
Copy Markdown
Member

Part of #119174 .
I think we should be good now to sync this change in rustc_public.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@scottmcm

Copy link
Copy Markdown
Member

Looks good to me. Always nice to see FIXMEs fixed :)

@bors r+

@bors

bors commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 642deb3 has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
@fmeasefmease mentioned this pull request Jul 24, 2025
bors added a commit that referenced this pull request Jul 24, 2025
Rollup of 16 pull requests
Successful merges:
- #142569 (Suggest clone in user-write-code instead of inside macro)
- #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- #143424 (clippy fix: rely on autoderef)
- #143970 (Update core::mem::copy documentation)
- #143979 (Test fixes for Arm64EC Windows)
- #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
- #144200 (Tweak output for non-`Clone` values moved into closures)
- #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- #144225 (Don't special-case llvm.* as nounwind)
- #144314 (Hint that choose_pivot returns index in bounds)
- #144316 (bootstrap: Move musl-root fallback out of sanity check)
- #144364 (Update `dlmalloc` dependency of libstd)
- #144368 (resolve: Remove `Scope::CrateRoot`)
- #144373 (remove deprecated Error::description in impls)
- #144390 (Remove dead code and extend test coverage and diagnostics around it)
- #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jul 25, 2025
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
@fmeasefmease mentioned this pull request Jul 25, 2025
bors added a commit that referenced this pull request Jul 25, 2025
Rollup of 17 pull requests
Successful merges:
- #142569 (Suggest clone in user-write-code instead of inside macro)
- #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- #143424 (clippy fix: rely on autoderef)
- #143970 (Update core::mem::copy documentation)
- #143979 (Test fixes for Arm64EC Windows)
- #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
- #144200 (Tweak output for non-`Clone` values moved into closures)
- #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- #144225 (Don't special-case llvm.* as nounwind)
- #144314 (Hint that choose_pivot returns index in bounds)
- #144316 (bootstrap: Move musl-root fallback out of sanity check)
- #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- #144364 (Update `dlmalloc` dependency of libstd)
- #144368 (resolve: Remove `Scope::CrateRoot`)
- #144390 (Remove dead code and extend test coverage and diagnostics around it)
- #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
- #144424 (Allow setting `release-blog-post` label with rustbot)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 25, 2025
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
This was referenced Jul 25, 2025
bors added a commit that referenced this pull request Jul 25, 2025
Rollup of 16 pull requests
Successful merges:
- #142569 (Suggest clone in user-write-code instead of inside macro)
- #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- #143424 (clippy fix: rely on autoderef)
- #143970 (Update core::mem::copy documentation)
- #143979 (Test fixes for Arm64EC Windows)
- #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
- #144200 (Tweak output for non-`Clone` values moved into closures)
- #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- #144314 (Hint that choose_pivot returns index in bounds)
- #144316 (bootstrap: Move musl-root fallback out of sanity check)
- #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- #144364 (Update `dlmalloc` dependency of libstd)
- #144368 (resolve: Remove `Scope::CrateRoot`)
- #144390 (Remove dead code and extend test coverage and diagnostics around it)
- #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
- #144424 (Allow setting `release-blog-post` label with rustbot)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 25, 2025
Rollup of 12 pull requests
Successful merges:
- #142569 (Suggest clone in user-write-code instead of inside macro)
- #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- #143424 (clippy fix: rely on autoderef)
- #143970 (Update core::mem::copy documentation)
- #143979 (Test fixes for Arm64EC Windows)
- #144200 (Tweak output for non-`Clone` values moved into closures)
- #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- #144314 (Hint that choose_pivot returns index in bounds)
- #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- #144368 (resolve: Remove `Scope::CrateRoot`)
- #144390 (Remove dead code and extend test coverage and diagnostics around it)
- #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1caf701 into rust-lang:masterJul 25, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jul 25, 2025
Rollup merge of #144392 - makai410:rm-mov, r=scottmcm
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of #119174 .
I think we should be good now to sync this change in rustc_public.
@rustbotrustbot added this to the 1.90.0 milestone Jul 25, 2025
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 28, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jul 28, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
tautschnig added a commit to tautschnig/kani that referenced this pull request Jul 29, 2025
Relevant upstream PRs:
- rust-lang/rust#144389 (MIR-build: No longer
emit assumes in enum-as casting)
- rust-lang/rust#144392 (rustc_public: Remove
movability from `RigidTy/AggregateKind::Coroutine`)
- rust-lang/rust#144377 (Rename impl_of_method
and trait_of_item)
Resolves: model-checking#4246
github-merge-queueBot pushed a commit to model-checking/kani that referenced this pull request Jul 29, 2025
Relevant upstream PRs:
- rust-lang/rust#144389 (MIR-build: No longer
emit assumes in enum-as casting)
- rust-lang/rust#144392 (rustc_public: Remove
movability from `RigidTy/AggregateKind::Coroutine`)
- rust-lang/rust#144377 (Rename impl_of_method
and trait_of_item)
Resolves: #4246
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
@makai410
makai410 deleted the rm-mov branch August 5, 2025 14:00
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang#143424 (clippy fix: rely on autoderef)
- rust-lang#143970 (Update core::mem::copy documentation)
- rust-lang#143979 (Test fixes for Arm64EC Windows)
- rust-lang#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`
Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang#143424 (clippy fix: rely on autoderef)
- rust-lang#143970 (Update core::mem::copy documentation)
- rust-lang#143979 (Test fixes for Arm64EC Windows)
- rust-lang#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
- rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
- rust-lang/rust#143424 (clippy fix: rely on autoderef)
- rust-lang/rust#143970 (Update core::mem::copy documentation)
- rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
- rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
- rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
- rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
- rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
- rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
- rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
- rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@makai410@rustbot@scottmcm@bors