Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #144502
Merged
Merged
Conversation
…tocol add rdg push git config entry for git protocol pushers (again)
Now all our Josh subtrees should be using josh-sync.
Given
```rust
fn main() {
let maybe_vec = Some(vec![1,2,3]);
assert_eq!(maybe_vec.len(), 3);
}
```
suggest unwraping `maybe_vec` to call `.len()` on the `Vec<_>`.
```
error[E0624]: method `len` is private
--> $DIR/enum-method-probe.rs:61:9
|
LL | res.len();
| ^^^ private method
--> $SRC_DIR/core/src/option.rs:LL:COL
|
= note: private method defined here
|
note: the method `len` exists on the type `Vec<{integer}>`
--> $SRC_DIR/alloc/src/vec/mod.rs:LL:COL
help: consider using `Option::expect` to unwrap the `Vec<{integer}>` value, panicking if the value is an `Option::None`
|
LL | res.expect("REASON").len();
| +++++++++++++++++
```This updates the rust-version file to efd420c.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: efd420c Filtered ref: d11dbbb02905535a89393e80c24274bee81fa928 This merge was created using https://github.com/rust-lang/josh-sync.
Update josh sync documentation
…sed attributes manually
Rustc pull update
this makes the triagebot pings for this module simpler
there is no `llvm.lld` option
…ve_omitted_patterns, r=Nadrieril Disable non_exhaustive_omitted_patterns within matches! macro Closesrust-lang#117304. I believe I can skip all of the bootstrap stuff mentioned in rust-lang#117304 (comment) due to https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/, right? cc `@Jules-Bertholet`
Suggest unwrapping when private method name is available in inner type
Given
```rust
fn main() {
let maybe_vec = Some(vec![1,2,3]);
assert_eq!(maybe_vec.len(), 3);
}
```
suggest unwraping `maybe_vec` to call `.len()` on the `Vec<_>`.
```
error[E0624]: method `len` is private
--> $DIR/enum-method-probe.rs:61:9
|
LL | res.len();
| ^^^ private method
--> $SRC_DIR/core/src/option.rs:LL:COL
|
= note: private method defined here
|
note: the method `len` exists on the type `Vec<{integer}>`
--> $SRC_DIR/alloc/src/vec/mod.rs:LL:COL
help: consider using `Option::expect` to unwrap the `Vec<{integer}>` value, panicking if the value is an `Option::None`
|
LL | res.expect("REASON").len();
| +++++++++++++++++
```
When a method isn't available, we emit E0599, but when it is private we emit E0624. We now just invoke the same suggestion logic from the later that we already did in the former.
Fixrust-lang#143795.…list, r=oli-obk Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually r? ```@oli-obk``` Nicer code & will prevent issues like rust-lang#144358 in the future
…ized_users, r=cuviper Allow setting `release-blog-post` label with rustbot r? release I forgot to do this when we originally added the label and updated the generated description for relnotes issues
…ame, r=Kobzol rename ext_tool_checks to extra_checks and use mod.rs this makes the triagebot pings for this module simpler discussed in https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/rename.20and.20reorganize.20ext_tool_checks.20module.3F/with/528398253 r? `@Kobzol`
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@4e31088. Created using https://github.com/rust-lang/josh-sync. r? ```@ghost```
…only, r=compiler-errors Limit defaultness query to impl of trait I separated this out from rust-lang#144386.
…rgs, r=RalfJung Allow pretty printing paths with `-Zself-profile-events=args` `-Zself-profile-events=args` is pretty heavy and can pretty print a lot of stuff. Rather than hunting down specific cases where this happens, I'd just allow calling `trimmed_def_paths` in this mode. Fixes: rust-lang#144457 r? `@RalfJung`
change_tracker: fix a typo there is no `llvm.lld` option r? `@Kobzol`
…rrowLii resolve: Do not create `NameResolutions` on access unless necessary `fn resolution` now just performs the access, and `fn resolution_or_default` will insert a default entry if the entry is missing.
matthiaskrgr
commented
Jul 26, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Jul 26, 2025
Collaborator
bors
commented
Jul 26, 2025
Collaborator
bors
commented
Jul 26, 2025
Collaborator
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 8708f3c (parent) -> 133798f (this PR) Test differencesShow 83 test diffsStage 1
Stage 2
Additionally, 81 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 133798f9fb2887bcccf1098937540e280dd58465 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Jul 26, 2025
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 8708f3cd1f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jul 26, 2025
Collaborator
Finished benchmarking commit (133798f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.1%, secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.3%, secondary -4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 468.031s -> 466.195s (-0.39%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_parsed_attributerather than keeping track of a list of parsed attributes manually #144421 (Callis_parsed_attributerather than keeping track of a list of parsed attributes manually)release-blog-postlabel with rustbot #144424 (Allow settingrelease-blog-postlabel with rustbot)-Zself-profile-events=args#144462 (Allow pretty printing paths with-Zself-profile-events=args)NameResolutionson access unless necessary #144468 (resolve: Do not createNameResolutionson access unless necessary)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup