Skip to content

coverage: Various small cleanups - #144877

Merged
bors merged 6 commits into
rust-lang:masterfrom
Zalathar:coverage-various
Aug 5, 2025
Merged

coverage: Various small cleanups#144877
bors merged 6 commits into
rust-lang:masterfrom
Zalathar:coverage-various

Conversation

@Zalathar

@ZalatharZalathar commented Aug 4, 2025

Copy link
Copy Markdown
Member

This PR is a collection of small coverage-related changes that I accumulated while working towards other coverage improvements.

Each change should hopefully be fairly straightforward.

@Zalathar
coverage: Include an Instance in CovfunRecord for debug messages
33706fc
@Zalathar
coverage: Hoist counter_for_bcb out of its loop
16843ce
Having this helper function in the loop was confusing, because it doesn't rely
on anything that changes between loop iterations.
@ZalatharZalathar added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Aug 4, 2025
@rustbot

rustbot commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@rustbot

rustbot commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zalathar
coverage: Remove -Zcoverage-options=no-mir-spans
51e62a0
This flag turned out to be less useful than anticipated, and interferes with
work towards expansion support.
@Zalathar
coverage: Push async special case down into extract_refined_covspans
fb39d3e
@Zalathar
coverage: Simplify access to debug/testing -Zcoverage-options flags
f496e83
@Zalathar
coverage: Represent CovmapVersion as an enum
b37c214
Using an enum here was historically not worth the extra hassle, but now we can
lean on `#[derive(TryFromU32)]` to hide most of the boilerplate.
@lcnr

lcnr commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

this all looks reasonable and like improvements to me. The changes are minor enough that even if I misjudged them due to a lack of familiarity with this code, they're also easy to revert

@bors r+ rollup

@bors

bors commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit b37c214 has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 4, 2025
@samueltardieu
Rollup merge ofrust-lang#144877- Zalathar:coverage-various, r=lcnr
d6e8cc2
coverage: Various small cleanups
This PR is a collection of small coverage-related changes that I accumulated while working towards other coverage improvements.
Each change should hopefully be fairly straightforward.
@samueltardieusamueltardieu mentioned this pull request Aug 4, 2025
Closed
bors added a commit that referenced this pull request Aug 4, 2025
@bors
Auto merge of#144929- samueltardieu:rollup-n2c14p7, r=samueltardieu
5bd6cac
Rollup of 18 pull requests
Successful merges:
- #144467 (rustdoc template font links only emit `crossorigin` when needed)
- #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- #144596 (libtest: print the type of test being run)
- #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions)
- #144776 (`Printer` cleanups)
- #144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
- #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`)
- #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`)
- #144852 (Rename `rust_panic_without_hook` to `resume_unwind` )
- #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`)
- #144867 (Use `as_array` in PartialEq for arrays)
- #144872 (Document Poisoning in `LazyCell` and `LazyLock`)
- #144877 (coverage: Various small cleanups)
- #144887 (`rust-analyzer` subtree update)
- #144890 (Add `InterpCx::project_fields`)
- #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`)
- #144905 (rustc-dev-guide subtree update)
- #144920 (Dont print arg span in MIR dump for tail call)
r? `@ghost`
`@rustbot` modify labels: rollup
@samueltardieusamueltardieu mentioned this pull request Aug 5, 2025
Merged
bors added a commit that referenced this pull request Aug 5, 2025
@bors
Auto merge of#144934- samueltardieu:rollup-25jvb9g, r=samueltardieu
0f35336
Rollup of 17 pull requests
Successful merges:
- #144467 (rustdoc template font links only emit `crossorigin` when needed)
- #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions)
- #144776 (`Printer` cleanups)
- #144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
- #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`)
- #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`)
- #144852 (Rename `rust_panic_without_hook` to `resume_unwind` )
- #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`)
- #144867 (Use `as_array` in PartialEq for arrays)
- #144872 (Document Poisoning in `LazyCell` and `LazyLock`)
- #144877 (coverage: Various small cleanups)
- #144887 (`rust-analyzer` subtree update)
- #144890 (Add `InterpCx::project_fields`)
- #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`)
- #144905 (rustc-dev-guide subtree update)
- #144920 (Dont print arg span in MIR dump for tail call)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7ad5281 into rust-lang:masterAug 5, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 5, 2025
rust-timer added a commit that referenced this pull request Aug 5, 2025
@rust-timer
Unrolled build for#144877
5a4b5fd
Rollup merge of #144877 - Zalathar:coverage-various, r=lcnr
coverage: Various small cleanups
This PR is a collection of small coverage-related changes that I accumulated while working towards other coverage improvements.
Each change should hopefully be fairly straightforward.
@Zalathar
Zalathar deleted the coverage-various branch August 5, 2025 05:13
@KobzolKobzol mentioned this pull request Aug 5, 2025
Closed
@samueltardieusamueltardieu mentioned this pull request Aug 5, 2025
Closed
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 7, 2025
@bors
Auto merge of #144934 - samueltardieu:rollup-25jvb9g, r=samueltardieu
811f376
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#144467 (rustdoc template font links only emit `crossorigin` when needed)
- rust-lang/rust#144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- rust-lang/rust#144741 (fix: Error on illegal `[const]`s inside blocks within legal positions)
- rust-lang/rust#144776 (`Printer` cleanups)
- rust-lang/rust#144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
- rust-lang/rust#144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`)
- rust-lang/rust#144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`)
- rust-lang/rust#144852 (Rename `rust_panic_without_hook` to `resume_unwind` )
- rust-lang/rust#144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`)
- rust-lang/rust#144867 (Use `as_array` in PartialEq for arrays)
- rust-lang/rust#144872 (Document Poisoning in `LazyCell` and `LazyLock`)
- rust-lang/rust#144877 (coverage: Various small cleanups)
- rust-lang/rust#144887 (`rust-analyzer` subtree update)
- rust-lang/rust#144890 (Add `InterpCx::project_fields`)
- rust-lang/rust#144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`)
- rust-lang/rust#144905 (rustc-dev-guide subtree update)
- rust-lang/rust#144920 (Dont print arg span in MIR dump for tail call)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Aug 11, 2025
@bors
Auto merge of #144934 - samueltardieu:rollup-25jvb9g, r=samueltardieu
6e3ab74
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#144467 (rustdoc template font links only emit `crossorigin` when needed)
- rust-lang/rust#144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- rust-lang/rust#144741 (fix: Error on illegal `[const]`s inside blocks within legal positions)
- rust-lang/rust#144776 (`Printer` cleanups)
- rust-lang/rust#144779 (Implement debugging output of the bootstrap Step graph into a DOT file)
- rust-lang/rust#144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`)
- rust-lang/rust#144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`)
- rust-lang/rust#144852 (Rename `rust_panic_without_hook` to `resume_unwind` )
- rust-lang/rust#144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`)
- rust-lang/rust#144867 (Use `as_array` in PartialEq for arrays)
- rust-lang/rust#144872 (Document Poisoning in `LazyCell` and `LazyLock`)
- rust-lang/rust#144877 (coverage: Various small cleanups)
- rust-lang/rust#144887 (`rust-analyzer` subtree update)
- rust-lang/rust#144890 (Add `InterpCx::project_fields`)
- rust-lang/rust#144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`)
- rust-lang/rust#144905 (rustc-dev-guide subtree update)
- rust-lang/rust#144920 (Dont print arg span in MIR dump for tail call)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnrlcnr

Labels

A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar@rustbot@rust-log-analyzer@lcnr@bors