Skip to content

bump bootstrap compiler to 1.90 beta - #144997

Merged
bors merged 4 commits into
rust-lang:masterfrom
BoxyUwU:bootstrap_bump
Aug 7, 2025
Merged

bump bootstrap compiler to 1.90 beta#144997
bors merged 4 commits into
rust-lang:masterfrom
BoxyUwU:bootstrap_bump

Conversation

@BoxyUwU

@BoxyUwUBoxyUwU commented Aug 6, 2025

Copy link
Copy Markdown
Member

There were significantly less cfg(bootstrap) and cfg(not(bootstrap)) this release. Presumably due to the fact that we change the bootstrap stage orderings to reduce the need for them and it was successful 🙏

@rustbot

rustbot commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 6, 2025
@BoxyUwU

BoxyUwU commented Aug 6, 2025

Copy link
Copy Markdown
MemberAuthor

r? release

@rustbotrustbot assigned emilyalbini and unassigned thomccAug 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Aug 6, 2025
View reviewed changes
Comment threadsrc/bootstrap/src/utils/helpers.rs Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Aug 6, 2025

Copy link
Copy Markdown
Member

r=me with the one comment fixed

@rustbotrustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Aug 6, 2025
@rustbot

rustbot commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbotrustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Aug 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU

BoxyUwU commented Aug 6, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=Mark-Simulacrum

@bors

bors commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7bc3462 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@fmeasefmease mentioned this pull request Aug 6, 2025
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge ofrust-lang#144997- BoxyUwU:bootstrap_bump, r=Mark-Sim…
ea47c11
…ulacrum
bump bootstrap compiler to 1.90 beta
There were significantly less `cfg(bootstrap)` and `cfg(not(bootstrap))` this release. Presumably due to the fact that we change the bootstrap stage orderings to reduce the need for them and it was successful 🙏
@ZalatharZalathar mentioned this pull request Aug 7, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge ofrust-lang#144997- BoxyUwU:bootstrap_bump, r=Mark-Sim…
c928e00
…ulacrum
bump bootstrap compiler to 1.90 beta
There were significantly less `cfg(bootstrap)` and `cfg(not(bootstrap))` this release. Presumably due to the fact that we change the bootstrap stage orderings to reduce the need for them and it was successful 🙏
@ZalatharZalathar mentioned this pull request Aug 7, 2025
Closed
bors added a commit that referenced this pull request Aug 7, 2025
@bors
Auto merge of#145039- Zalathar:rollup-98v9fbg, r=Zalathar
5f76d77
Rollup of 20 pull requests
Successful merges:
- #137831 (Tweak auto trait errors)
- #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching)
- #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order)
- #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure )
- #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
- #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps)
- #144133 (Stabilize const TypeId::of)
- #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling)
- #144473 (Address libunwind.a inconsistency issues in the bootstrap program)
- #144659 (bootstrap: refactor mingw dist and fix gnullvm)
- #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- #144807 (Streamline config in bootstrap)
- #144900 (Stabilize `unsigned_signed_diff` feature)
- #144903 (Rename `begin_panic_handler` to `panic_handler`)
- #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC)
- #144974 (compiler-builtins subtree update)
- #144997 (bump bootstrap compiler to 1.90 beta)
- #145004 (Couple of minor cleanups)
- #145009 (A couple small changes for rust-analyzer next-solver work)
- #145014 (Revert "Preserve the .debug_gdb_scripts section")
r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar

Zalathar commented Aug 7, 2025

Copy link
Copy Markdown
Member

Past bootstrap bumps tend to be rollup=never; should we do the same for this one?

@bors rollup=never p=1

@Zalathar

Zalathar commented Aug 7, 2025

Copy link
Copy Markdown
Member

Boosting this again so I can queue a rollup behind it.

@bors p=5

@bors

bors commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7bc3462 with merge cd43430...

@bors

bors commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing cd43430 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2025
@bors
bors merged commit cd43430 into rust-lang:masterAug 7, 2025
11 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 7, 2025
@github-actions

github-actionsBot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9b1a30e (parent) -> cd43430 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd434309efcf5dc68b253e5ef6ba40c1c43711c9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3821.8s -> 5200.1s (36.1%)
  2. pr-check-2: 2227.1s -> 2740.4s (23.0%)
  3. pr-check-1: 1482.8s -> 1771.5s (19.5%)
  4. x86_64-apple-1: 8057.2s -> 9526.1s (18.2%)
  5. x86_64-gnu-llvm-19: 2470.4s -> 2865.0s (16.0%)
  6. x86_64-rust-for-linux: 2566.1s -> 2943.1s (14.7%)
  7. x86_64-gnu-tools: 3312.8s -> 3791.3s (14.4%)
  8. i686-gnu-2: 5552.4s -> 6332.3s (14.0%)
  9. i686-gnu-1: 7253.3s -> 8129.0s (12.1%)
  10. i686-gnu-nopt-1: 7304.5s -> 8101.7s (10.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Aug 7, 2025
Merged
Closed
Closed
@rust-timer

rust-timer commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd43430): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.3%[0.3%, 0.3%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.5%[-0.5%, -0.5%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		3.0%[2.2%, 3.6%]4
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Cycles

Results (primary -2.3%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		5.1%[3.6%, 6.3%]7
Improvements ✅
(primary)		-2.3%[-2.3%, -2.3%]1
Improvements ✅
(secondary)		-2.7%[-2.9%, -2.6%]2
All ❌✅ (primary)-2.3%[-2.3%, -2.3%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.481s -> 465.283s (-0.04%)
Artifact size: 377.39 MiB -> 377.41 MiB (0.00%)

github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Aug 12, 2025
@bors
Auto merge ofrust-lang#144997- BoxyUwU:bootstrap_bump, r=Mark-Simul…
9224939
…acrum
bump bootstrap compiler to 1.90 beta
There were significantly less `cfg(bootstrap)` and `cfg(not(bootstrap))` this release. Presumably due to the fact that we change the bootstrap stage orderings to reduce the need for them and it was successful 🙏
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KobzolKobzolKobzol left review comments
@jieyouxujieyouxujieyouxu left review comments

Assignees

@emilyalbiniemilyalbini

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

11 participants

@BoxyUwU@rustbot@rust-log-analyzer@Mark-Simulacrum@bors@Zalathar@rust-timer@Kobzol@jieyouxu@thomcc@emilyalbini