Skip to content

Derive Hash for rustc_public types - #145018

Merged
bors merged 2 commits into
rust-lang:masterfrom
AlexanderPortland:rustc-public-hash
Aug 8, 2025
Merged

Derive Hash for rustc_public types#145018
bors merged 2 commits into
rust-lang:masterfrom
AlexanderPortland:rustc-public-hash

Conversation

@AlexanderPortland

@AlexanderPortlandAlexanderPortland commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

This derives Hash for the rustc_public versions of Rvalue, Place, Span, and all the types they contain. As far as I can tell, the internal versions of all these types already implement Hash, so it would be helpful if the public versions implemented it too!

@rustbot

rustbot commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
@rustbot

rustbot commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@AlexanderPortlandAlexanderPortland mentioned this pull request Aug 6, 2025
Closed
scottmcm
scottmcm reviewed Aug 7, 2025
View reviewed changes
Comment threadcompiler/rustc_public/src/ty.rs Outdated
}

#[derive(Clone, Copy, PartialEq, Eq, Serialize)]
impl<T: std::hash::Hash> std::hash::Hash for Placeholder<T> {

@scottmcmscottmcmAug 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this also derived? If it's deriving Eq and PartialEq, it should almost certainly be deriving Hash too.

@AlexanderPortlandAlexanderPortlandAug 7, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad! I didn't realize the derive macro could handle generics. Just fixed this now

@scottmcmscottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025
@AlexanderPortland

AlexanderPortland commented Aug 7, 2025

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2025
@scottmcm

scottmcm commented Aug 7, 2025

Copy link
Copy Markdown
Member

Sounds good to me; these things that are already derive(PartialEq, Eq) might as well derive(Hash) too.

@bors r+ rollup

@bors

bors commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit b9e6bd7 has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 7, 2025
@tgross35
Rollup merge ofrust-lang#145018- AlexanderPortland:rustc-public-has…
da9f352
…h, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
@tgross35tgross35 mentioned this pull request Aug 7, 2025
Closed
bors added a commit that referenced this pull request Aug 7, 2025
@bors
Auto merge of#145063- tgross35:rollup-mkyt3zj, r=tgross35
00d2994
Rollup of 8 pull requests
Successful merges:
- #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- #144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- #144900 (Stabilize `unsigned_signed_diff` feature)
- #144903 (Rename `begin_panic_handler` to `panic_handler`)
- #144974 (compiler-builtins subtree update)
- #145004 (Couple of minor cleanups)
- #145007 (Fix build/doc/test of error index generator)
- #145018 (Derive `Hash` for rustc_public types)
r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 7, 2025
@tgross35
Rollup merge ofrust-lang#145018- AlexanderPortland:rustc-public-has…
f0cc19d
…h, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
@tgross35tgross35 mentioned this pull request Aug 7, 2025
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 8, 2025
@tgross35
Rollup merge ofrust-lang#145018- AlexanderPortland:rustc-public-has…
09fffc5
…h, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
@tgross35tgross35 mentioned this pull request Aug 8, 2025
Merged
bors added a commit that referenced this pull request Aug 8, 2025
@bors
Auto merge of#145074- tgross35:rollup-0tillrm, r=tgross35
67d45f4
Rollup of 9 pull requests
Successful merges:
- #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- #144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- #144900 (Stabilize `unsigned_signed_diff` feature)
- #144903 (Rename `begin_panic_handler` to `panic_handler`)
- #144974 (compiler-builtins subtree update)
- #145007 (Fix build/doc/test of error index generator)
- #145018 (Derive `Hash` for rustc_public types)
- #145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- #145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 41b6da1 into rust-lang:masterAug 8, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 8, 2025
rust-timer added a commit that referenced this pull request Aug 8, 2025
@rust-timer
Unrolled build for#145018
8d3bdf1
Rollup merge of #145018 - AlexanderPortland:rustc-public-hash, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
github-actionsBot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Aug 9, 2025
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
e8ff6dc
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 9, 2025
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
3f64075
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 16, 2025
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
176ec11
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Aug 20, 2025
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
36dc064
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@tgross35
Rollup merge ofrust-lang#145018- AlexanderPortland:rustc-public-has…
0caa654
…h, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge ofrust-lang#145074- tgross35:rollup-0tillrm, r=tgross35
df5c261
Rollup of 9 pull requests
Successful merges:
- rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang#144974 (compiler-builtins subtree update)
- rust-lang#145007 (Fix build/doc/test of error index generator)
- rust-lang#145018 (Derive `Hash` for rustc_public types)
- rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@tgross35
Rollup merge ofrust-lang#145018- AlexanderPortland:rustc-public-has…
75ef74a
…h, r=scottmcm
Derive `Hash` for rustc_public types
This derives `Hash` for the rustc_public versions of `Rvalue`, `Place`, `Span`, and all the types they contain. As far as I can tell, the internal versions of all these types already implement `Hash`, so it would be helpful if the public versions implemented it too!
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#145074- tgross35:rollup-0tillrm, r=tgross35
d620aed
Rollup of 9 pull requests
Successful merges:
- rust-lang#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang#144974 (compiler-builtins subtree update)
- rust-lang#145007 (Fix build/doc/test of error index generator)
- rust-lang#145018 (Derive `Hash` for rustc_public types)
- rust-lang#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
5f03e4c
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jan 31, 2026
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
0e71f2f
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
@bors
Auto merge of #145074 - tgross35:rollup-0tillrm, r=tgross35
09ccecb
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled)
- rust-lang/rust#144857 (Port `#[allow_internal_unsafe]` to the new attribute system)
- rust-lang/rust#144900 (Stabilize `unsigned_signed_diff` feature)
- rust-lang/rust#144903 (Rename `begin_panic_handler` to `panic_handler`)
- rust-lang/rust#144974 (compiler-builtins subtree update)
- rust-lang/rust#145007 (Fix build/doc/test of error index generator)
- rust-lang/rust#145018 (Derive `Hash` for rustc_public types)
- rust-lang/rust#145045 (doc(library): Fix Markdown in `Iterator::by_ref`)
- rust-lang/rust#145046 (Fix doc comment of File::try_lock and File::try_lock_shared)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottmcmscottmcmscottmcm left review comments

Assignees

@scottmcmscottmcm

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexanderPortland@rustbot@scottmcm@bors