Skip to content

remove some unused private trait impls - #145111

Merged
bors merged 1 commit into
rust-lang:masterfrom
fee1-dead-contrib:push-rlvnyrztlkpq
Aug 11, 2025
Merged

remove some unused private trait impls#145111
bors merged 1 commit into
rust-lang:masterfrom
fee1-dead-contrib:push-rlvnyrztlkpq

Conversation

@fee1-dead

@fee1-deadfee1-dead commented Aug 8, 2025

Copy link
Copy Markdown
Member

they're neither required for completeness nor used

@rustbot

rustbot commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025
jieyouxu
jieyouxu approved these changes Aug 11, 2025
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow

@jieyouxu

jieyouxu commented Aug 11, 2025

Copy link
Copy Markdown
Member

r? jieyouxu @bors r+ rollup

@bors

bors commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 57dc64e has been approved by jieyouxu

It is now in the queue for this repository.

@rustbotrustbot assigned jieyouxu and unassigned davidtwcoAug 11, 2025
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 11, 2025
Merged
bors added a commit that referenced this pull request Aug 11, 2025
@bors
Auto merge of#145254- GuillaumeGomez:rollup-7bp43pv, r=GuillaumeGomez
1ebbd87
Rollup of 4 pull requests
Successful merges:
- #144966 ( Improve suggestion for "missing function argument" on multiline call)
- #145111 (remove some unused private trait impls)
- #145221 (Fix Cargo cross-compilation (take two))
- #145247 (Update `sysinfo` version to `0.37.0`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 77d7a2c into rust-lang:masterAug 11, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 11, 2025
rust-timer added a commit that referenced this pull request Aug 11, 2025
@rust-timer
Unrolled build for#145111
1537297
Rollup merge of #145111 - fee1-dead-contrib:push-rlvnyrztlkpq, r=jieyouxu
remove some unused private trait impls
they're neither required for completeness nor used
@fee1-dead
fee1-dead deleted the push-rlvnyrztlkpq branch October 22, 2025 00:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fee1-dead@rustbot@jieyouxu@bors@davidtwco